clean handler action

Author: ValyaB

internal/actions/approve_csr_handler.go

@@ -2,35 +2,18 @@ package actions
 
 import (
 	"context"
-	"time"
-
-	"github.com/sirupsen/logrus"
-	"k8s.io/client-go/kubernetes"
-
 	"github.com/castai/cluster-controller/internal/castai"
 )
 
-const (
-	approveCSRTimeout = 4 * time.Minute
-)
+// TODO deprecated action
 
 var _ ActionHandler = &ApproveCSRHandler{}
 
-func NewApproveCSRHandler(log logrus.FieldLogger, clientset kubernetes.Interface) *ApproveCSRHandler {
-	return &ApproveCSRHandler{
-		log:                    log,
-		clientset:              clientset,
-		initialCSRFetchTimeout: 5 * time.Minute,
-		csrFetchInterval:       5 * time.Second,
-	}
+func NewApproveCSRHandler() *ApproveCSRHandler {
+	return &ApproveCSRHandler{}
 }
 
-type ApproveCSRHandler struct {
-	log                    logrus.FieldLogger
-	clientset              kubernetes.Interface
-	initialCSRFetchTimeout time.Duration
-	csrFetchInterval       time.Duration
-}
+type ApproveCSRHandler struct{}
 
 func (h *ApproveCSRHandler) Handle(_ context.Context, _ *castai.ClusterAction) error {
 	return nil

internal/controller/controller.go

@@ -55,7 +55,7 @@ func NewService(
 			reflect.TypeOf(&castai.ActionDrainNode{}):         actions.NewDrainNodeHandler(log, clientset, cfg.Namespace),
 			reflect.TypeOf(&castai.ActionPatchNode{}):         actions.NewPatchNodeHandler(log, clientset),
 			reflect.TypeOf(&castai.ActionCreateEvent{}):       actions.NewCreateEventHandler(log, clientset),
-			reflect.TypeOf(&castai.ActionApproveCSR{}):        actions.NewApproveCSRHandler(log, clientset),
+			reflect.TypeOf(&castai.ActionApproveCSR{}):        actions.NewApproveCSRHandler(),
 			reflect.TypeOf(&castai.ActionChartUpsert{}):       actions.NewChartUpsertHandler(log, helmClient),
 			reflect.TypeOf(&castai.ActionChartUninstall{}):    actions.NewChartUninstallHandler(log, helmClient),
 			reflect.TypeOf(&castai.ActionChartRollback{}):     actions.NewChartRollbackHandler(log, helmClient, cfg.Version),