Linter

Author: Tsonov

loadtest/castai.go

@@ -85,7 +85,7 @@ func (c *CastAITestServer) GetActions(ctx context.Context, _ string) ([]*castai.
 		c.log.Info(fmt.Sprintf("No actions to return in %v", c.cfg.TimeoutWaitingForActions))
 		return nil, nil
 	case <-ctx.Done():
-		return nil, fmt.Errorf("context done with cause (%v), err (%v)", context.Cause(ctx), ctx.Err())
+		return nil, fmt.Errorf("context done with cause (%w), err (%w)", context.Cause(ctx), ctx.Err())
 	}
 
 	// Attempt to drain up to max items from the channel.
@@ -97,7 +97,7 @@ func (c *CastAITestServer) GetActions(ctx context.Context, _ string) ([]*castai.
 			// If we haven't received enough items, just flush.
 			return actionsToReturn, nil
 		case <-ctx.Done():
-			return nil, fmt.Errorf("context done with cause (%v), err (%v)", context.Cause(ctx), ctx.Err())
+			return nil, fmt.Errorf("context done with cause (%w), err (%w)", context.Cause(ctx), ctx.Err())
 		}
 	}
 

loadtest/http.go

@@ -1,15 +1,15 @@
 package loadtest
 
 import (
+	"context"
 	"encoding/json"
 	"fmt"
 	"net/http"
 
 	"github.com/castai/cluster-controller/internal/castai"
 )
 
-func NewHttpServer(cfg Config, testServer *CastAITestServer) error {
-
+func NewHttpServer(ctx context.Context, cfg Config, testServer *CastAITestServer) error {
 	http.HandleFunc("/v1/kubernetes/clusters/{cluster_id}/actions", func(w http.ResponseWriter, r *http.Request) {
 		result, err := testServer.GetActions(r.Context(), "")
 		if err != nil {
@@ -27,8 +27,6 @@ func NewHttpServer(cfg Config, testServer *CastAITestServer) error {
 			http.Error(w, err.Error(), http.StatusInternalServerError)
 			return
 		}
-
-		return
 	})
 
 	http.HandleFunc("/v1/kubernetes/clusters/{cluster_id}/actions/{action_id}/ack", func(w http.ResponseWriter, r *http.Request) {
@@ -45,8 +43,6 @@ func NewHttpServer(cfg Config, testServer *CastAITestServer) error {
 			http.Error(w, err.Error(), http.StatusInternalServerError)
 			return
 		}
-
-		return
 	})
 
 	http.HandleFunc("/v1/kubernetes/clusters/{cluster_id}/actions/logs", func(w http.ResponseWriter, r *http.Request) {
@@ -62,10 +58,8 @@ func NewHttpServer(cfg Config, testServer *CastAITestServer) error {
 			http.Error(w, err.Error(), http.StatusInternalServerError)
 			return
 		}
-
-		return
 	})
 
+	//nolint:gosec // Missing timeouts are not a real issue here.
 	return http.ListenAndServe(fmt.Sprintf(":%d", cfg.Port), nil)
-
 }

loadtest/scenarios/scenario.go

@@ -37,6 +37,7 @@ func RunScenario(
 	logger *slog.Logger,
 	clientset kubernetes.Interface,
 ) error {
+	//nolint:gosec // No point to use crypto/rand.
 	namespaceForTest := fmt.Sprintf("test-namespace-%d", rand.Int31())
 	logger = logger.With("namespace", namespaceForTest, "scenario", scenario.Name())
 

loadtest/scenarios/stuck_drain.go

@@ -17,7 +17,7 @@ import (
 	"github.com/castai/cluster-controller/internal/castai"
 )
 
-func StuckDrain(nodeCount int, deploymentReplicas int, log *slog.Logger) TestScenario {
+func StuckDrain(nodeCount, deploymentReplicas int, log *slog.Logger) TestScenario {
 	return &stuckDrainScenario{
 		nodeCount:          nodeCount,
 		deploymentReplicas: deploymentReplicas,
@@ -56,6 +56,7 @@ func (s *stuckDrainScenario) Preparation(ctx context.Context, namespace string,
 		s.log.Info(fmt.Sprintf("Creating deployment on node %s", nodeName))
 		deployment, pdb := DeploymentWithStuckPDB(fmt.Sprintf("fake-deployment-%s-%d", node.Name, i))
 		deployment.ObjectMeta.Namespace = namespace
+		//nolint:gosec // Not afraid of overflow here.
 		deployment.Spec.Replicas = lo.ToPtr(int32(s.deploymentReplicas))
 		deployment.Spec.Template.Spec.NodeName = nodeName
 		pdb.ObjectMeta.Namespace = namespace

loadtest/scenarios/util.go

@@ -13,7 +13,7 @@ func WaitUntil(ctx context.Context, duration time.Duration, condition func() boo
 			return false
 		default:
 		}
-		if time.Now().Sub(start) > duration {
+		if time.Since(start) > duration {
 			return false
 		}
 		if condition() {