Use helper to get type

Author: Tsonov

internal/actions/create_handler.go

@@ -3,7 +3,6 @@ package actions
 import (
 	"context"
 	"fmt"
-	"reflect"
 
 	jsonpatch "github.com/evanphx/json-patch"
 	"github.com/sirupsen/logrus"
@@ -45,7 +44,7 @@ func (h *CreateHandler) Handle(ctx context.Context, action *castai.ClusterAction
 
 	log := h.log.WithFields(logrus.Fields{
 		ActionIDLogField: action.ID,
-		"action":         reflect.TypeOf(action.Data()).String(),
+		"action":         action.GetType(),
 		"gvr":            req.GroupVersionResource.String(),
 		"name":           newObj.GetName(),
 	})

internal/actions/delete_handler.go

@@ -3,7 +3,6 @@ package actions
 import (
 	"context"
 	"fmt"
-	"reflect"
 
 	"github.com/sirupsen/logrus"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -36,7 +35,7 @@ func (h *DeleteHandler) Handle(ctx context.Context, action *castai.ClusterAction
 
 	log := h.log.WithFields(logrus.Fields{
 		"id":     action.ID,
-		"action": reflect.TypeOf(action.Data()).String(),
+		"action": action.GetType(),
 		"gvr":    req.ID.GroupVersionResource.String(),
 		"name":   req.ID.Name,
 	})

internal/actions/patch_handler.go

@@ -3,7 +3,6 @@ package actions
 import (
 	"context"
 	"fmt"
-	"reflect"
 
 	"github.com/samber/lo"
 	"github.com/sirupsen/logrus"
@@ -43,7 +42,7 @@ func (h *PatchHandler) Handle(ctx context.Context, action *castai.ClusterAction)
 
 	log := h.log.WithFields(logrus.Fields{
 		ActionIDLogField: action.ID,
-		"action":         reflect.TypeOf(action.Data()).String(),
+		"action":         action.GetType(),
 		"gvr":            req.ID.GroupVersionResource.String(),
 		"name":           req.ID.Name,
 	})

internal/actions/patch_node_handler.go

@@ -3,7 +3,6 @@ package actions
 import (
 	"context"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"reflect"
 	"strconv"
@@ -30,8 +29,6 @@ type PatchNodeHandler struct {
 	clientset kubernetes.Interface
 }
 
-var errAction = errors.New("not valid action")
-
 func (h *PatchNodeHandler) Handle(ctx context.Context, action *castai.ClusterAction) error {
 	req, ok := action.Data().(*castai.ActionPatchNode)
 	if !ok {

internal/actions/types.go

@@ -5,6 +5,7 @@ package actions
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/castai/cluster-controller/internal/castai"
@@ -16,6 +17,8 @@ const (
 	ActionIDLogField = "id"
 )
 
+var errAction = errors.New("not valid action")
+
 func newUnexpectedTypeErr(value, expectedType interface{}) error {
 	return fmt.Errorf("unexpected type %T, expected %T %w", value, expectedType, errAction)
 }