Add unit tests

Author: oanatmaria

castai/reservations/mapping_test.go

@@ -1,11 +1,12 @@
 package reservations
 
 import (
+	"testing"
+	"time"
+
 	"github.com/castai/terraform-provider-castai/castai/sdk"
 	"github.com/samber/lo"
 	"github.com/stretchr/testify/require"
-	"testing"
-	"time"
 )
 
 func TestMapCsvRecordsToReservationResources(t *testing.T) {

castai/resource_role_bindings.go

@@ -225,7 +225,6 @@ func resourceRoleBindingsCreate(ctx context.Context, data *schema.ResourceData,
 	}
 	scope := convertScopeToSDK(data)
 	scopes := convertScopesToSDK(data)
-	scopes = append(scopes, scope)
 
 	resp, err := client.RbacServiceAPICreateRoleBindingsWithResponse(ctx, organizationID, sdk.RbacServiceAPICreateRoleBindingsJSONRequestBody{
 		{
@@ -276,7 +275,6 @@ func resourceRoleBindingsUpdate(ctx context.Context, data *schema.ResourceData,
 	}
 	scope := convertScopeToSDK(data)
 	scopes := convertScopesToSDK(data)
-	scopes = append(scopes, scope)
 
 	resp, err := client.RbacServiceAPIUpdateRoleBindingWithResponse(ctx, organizationID, roleBindingID, sdk.RbacServiceAPIUpdateRoleBindingJSONRequestBody{
 		Definition: sdk.CastaiRbacV1beta1RoleBindingDefinition{
@@ -352,25 +350,27 @@ func assignRoleBindingData(roleBinding *sdk.CastaiRbacV1beta1RoleBinding, data *
 		return fmt.Errorf("setting role binding role id: %w", err)
 	}
 
-	if roleBinding.Definition.Scope.Organization != nil {
-		err := data.Set(FieldRoleBindingsScope, []any{
-			map[string]any{
-				FieldRoleBindingsScopeKind:       RoleBindingScopeKindOrganization,
-				FieldRoleBindingsScopeResourceID: roleBinding.Definition.Scope.Organization.Id,
-			},
-		})
-		if err != nil {
-			return fmt.Errorf("parsing scope organization: %w", err)
-		}
-	} else if roleBinding.Definition.Scope.Cluster != nil {
-		err := data.Set(FieldRoleBindingsScope, []any{
-			map[string]any{
-				FieldRoleBindingsScopeKind:       RoleBindingScopeKindCluster,
-				FieldRoleBindingsScopeResourceID: roleBinding.Definition.Scope.Cluster.Id,
-			},
-		})
-		if err != nil {
-			return fmt.Errorf("parsing scope cluster: %w", err)
+	if roleBinding.Definition.Scope != nil {
+		if roleBinding.Definition.Scope.Organization != nil {
+			err := data.Set(FieldRoleBindingsScope, []any{
+				map[string]any{
+					FieldRoleBindingsScopeKind:       RoleBindingScopeKindOrganization,
+					FieldRoleBindingsScopeResourceID: roleBinding.Definition.Scope.Organization.Id,
+				},
+			})
+			if err != nil {
+				return fmt.Errorf("parsing scope organization: %w", err)
+			}
+		} else if roleBinding.Definition.Scope.Cluster != nil {
+			err := data.Set(FieldRoleBindingsScope, []any{
+				map[string]any{
+					FieldRoleBindingsScopeKind:       RoleBindingScopeKindCluster,
+					FieldRoleBindingsScopeResourceID: roleBinding.Definition.Scope.Cluster.Id,
+				},
+			})
+			if err != nil {
+				return fmt.Errorf("parsing scope cluster: %w", err)
+			}
 		}
 	}
 

castai/resource_role_bindings_test.go

@@ -246,6 +246,103 @@ subjects.0.subject.2.kind = group
 subjects.0.subject.2.service_account_id = 
 subjects.0.subject.2.user_id = 
 Tainted = false
+`, data.State().String())
+	})
+
+	t.Run("when RbacServiceAPI respond with 200 then populate the state with scopes", func(t *testing.T) {
+		t.Parallel()
+
+		r := require.New(t)
+		mockClient := mock_sdk.NewMockClientInterface(gomock.NewController(t))
+
+		ctx := context.Background()
+		provider := &ProviderConfig{
+			api: &sdk.ClientWithResponses{
+				ClientInterface: mockClient,
+			},
+		}
+
+		organizationID := "4e4cd9eb-82eb-407e-a926-e5fef81cab50"
+		roleBindingID := "a83b7bf2-5a99-45d9-bcac-b969386e751f"
+		roleID := "4df39779-dfb2-48d3-91d8-7ee5bd2bca4b"
+		userID := "671b2ebb-f361-42f0-aa2f-3049de93f8c1"
+		serviceAccountID := "b11f5945-22ca-4101-a86e-d6e37f44a415"
+		groupID := "844d2bf2-870d-42da-a81c-4e19befc78fc"
+
+		body := io.NopCloser(bytes.NewReader([]byte(`{
+			"id": "` + roleBindingID + `",
+			"organizationId": "` + organizationID + `",
+			"name": "role-binding-name",
+			"description": "role-binding-description",
+			"definition": {
+			  "roleId": "` + roleID + `",
+			  "scopes": [
+				{
+				  "organization": {
+					"id": "` + organizationID + `"
+				  }
+				}
+			  ],
+			  "subjects": [
+				{
+				  "user": {
+					"id": "` + userID + `"
+				  }
+				},
+				{
+				  "serviceAccount": {
+					"id": "` + serviceAccountID + `"
+				  }
+				},
+				{
+				  "group": {
+					"id": "` + groupID + `"
+				  }
+				}
+			  ]
+			}
+		   }`)))
+
+		mockClient.EXPECT().
+			RbacServiceAPIGetRoleBinding(gomock.Any(), organizationID, roleBindingID).
+			Return(&http.Response{StatusCode: 200, Body: body, Header: map[string][]string{"Content-Type": {"json"}}}, nil)
+
+		stateValue := cty.ObjectVal(map[string]cty.Value{
+			"organization_id": cty.StringVal(organizationID),
+		})
+		state := terraform.NewInstanceStateShimmedFromValue(stateValue, 0)
+		state.ID = roleBindingID
+
+		resource := resourceRoleBindings()
+		data := resource.Data(state)
+
+		result := resource.ReadContext(ctx, data, provider)
+
+		r.Nil(result)
+		r.False(result.HasError())
+		r.Equal(`ID = `+roleBindingID+`
+description = role-binding-description
+name = role-binding-name
+organization_id = `+organizationID+`
+role_id = `+roleID+`
+scopes.# = 1
+scopes.0.kind = organization
+scopes.0.resource_id = `+organizationID+`
+subjects.# = 1
+subjects.0.subject.# = 3
+subjects.0.subject.0.group_id = 
+subjects.0.subject.0.kind = user
+subjects.0.subject.0.service_account_id = 
+subjects.0.subject.0.user_id = `+userID+`
+subjects.0.subject.1.group_id = 
+subjects.0.subject.1.kind = service_account
+subjects.0.subject.1.service_account_id = `+serviceAccountID+`
+subjects.0.subject.1.user_id = 
+subjects.0.subject.2.group_id = `+groupID+`
+subjects.0.subject.2.kind = group
+subjects.0.subject.2.service_account_id = 
+subjects.0.subject.2.user_id = 
+Tainted = false
 `, data.State().String())
 	})
 }