code review remarks

aldor007 · aldor007 · commit 17516f86e374 · 2025-03-21T13:11:23.000+01:00
diff --git a/castai/resource_node_configuration.go b/castai/resource_node_configuration.go
@@ -1326,7 +1326,7 @@ func fromAKSNodePublicIP(sdkPublicIp *sdk.NodeconfigV1AKSConfigPublicIP) []map[s
 	if sdkPublicIp.Tags != nil {
 		tags := make(map[string]interface{})
 		for _, tag := range *sdkPublicIp.Tags {
-			tags[*tag.IpTagType] = *tag.TagValue
+			tags[lo.FromPtr(tag.IpTagType)] = lo.FromPtr(tag.TagValue)
 		}
 		m["tags"] = tags
 	}

Original file line number	Diff line number	Diff line change
`@@ -1326,7 +1326,7 @@ func fromAKSNodePublicIP(sdkPublicIp *sdk.NodeconfigV1AKSConfigPublicIP) []map[s`
`1326`	`1326`	`if sdkPublicIp.Tags != nil {`
`1327`	`1327`	`tags := make(map[string]interface{})`
`1328`	`1328`	`for _, tag := range *sdkPublicIp.Tags {`
`1329`		`- tags[tag.IpTagType] = tag.TagValue`
	`1329`	`+ tags[lo.FromPtr(tag.IpTagType)] = lo.FromPtr(tag.TagValue)`
`1330`	`1330`	`}`
`1331`	`1331`	`m["tags"] = tags`
`1332`	`1332`	`}`