Add detachDisk to the default policy for faster drain/deletes. (#657)

* Add detachDisk to the default policy for faster drain/deletes.

* Generate sdk

* Adjust tests to change

* Adjust policy_test tests to change

* Attempt to fix acc test

Author: Tsonov

castai/data_source_gke_test.go

@@ -25,20 +25,20 @@ func Test_dataSourceGKEPoliciesRead(t *testing.T) {
 				loadBalancersTargetBackendPoolsFeature:      true,
 				loadBalancersUnmanagedInstanceGroupsFeature: true,
 			},
-			expected: 43, // -1 for the duplicate policy
+			expected: 44, // -1 for the duplicate policy
 			hasError: false,
 		},
 		{
 			name: "loadBalancersTargetBackendPoolsFeature",
 			features: map[string]bool{
 				loadBalancersTargetBackendPoolsFeature: true,
 			},
-			expected: 42, // -1 for the duplicate policy
+			expected: 43, // -1 for the duplicate policy
 			hasError: false,
 		},
 		{
 			name:     "empty features",
-			expected: 38,
+			expected: 39,
 			hasError: false,
 		},
 	}
@@ -85,14 +85,14 @@ func TestAccGKE_DataSourceGKEPolicies_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("data.castai_gke_user_policies.gke", "features.load_balancers_target_backend_pools", "true"),
 					resource.TestCheckResourceAttr("data.castai_gke_user_policies.gke", "features.load_balancers_unmanaged_instance_groups", "true"),
-					resource.TestCheckResourceAttr("data.castai_gke_user_policies.gke", "policy.#", "43"),
+					resource.TestCheckResourceAttr("data.castai_gke_user_policies.gke", "policy.#", "44"),
 				),
 			},
 			{
 				Config: testAccDataSourceGKEPoliciesConfigUpdated,
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("data.castai_gke_user_policies.gke", "features.load_balancers_target_backend_pools", "true"),
-					resource.TestCheckResourceAttr("data.castai_gke_user_policies.gke", "policy.#", "42"),
+					resource.TestCheckResourceAttr("data.castai_gke_user_policies.gke", "policy.#", "43"),
 				),
 			},
 		},

castai/policies/gke/iam-policy.json

@@ -14,6 +14,7 @@
       "compute.instances.setServiceAccount",
       "compute.instances.setMetadata",
       "compute.instances.setTags",
+      "compute.instances.detachDisk",
       "compute.instanceGroupManagers.get",
       "compute.instanceGroupManagers.update",
       "compute.instanceGroups.get",

castai/policies/gke/policy_test.go

@@ -1,8 +1,9 @@
 package gke
 
 import (
-	"github.com/stretchr/testify/require"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestPolicies(t *testing.T) {
@@ -21,7 +22,7 @@ func TestPolicies(t *testing.T) {
 		if !contains(userpolicy, wantClustersGet) || !contains(userpolicy, wantZonesGet) {
 			t.Fatalf("generated User policy document does not contain required policies")
 		}
-		require.Equal(t, 38, len(userpolicy))
+		require.Equal(t, 39, len(userpolicy))
 	})
 	t.Run("LoadBalancersTargetBackendPools policy", func(t *testing.T) {
 		lbTbpPolicy, err := GetLoadBalancersTargetBackendPoolsPolicy()