Skip to content

Commit 434377b

Browse files
Fix examples and bump default EKS version (#632)
* fix(examples): depend on infrastructure modules with castai-cluster module in EKS Otherwise the teardown don't always work, the infrastructure is cleaned up before Cast AI Helm Releases were destroyed. * chore(examples): bump default EKS version to 1.33 To avoid someone running these examples for longer running into issues, I don't want to go straight to 1.34 as that couldn't be applied to existing clusters (can't skip versions). Going to follow up with 1.34 soon though. * fix(examples): bump EKS cluster module to 14.1+ v14.1.0 pinned the omni-cluster module version and adopted to a change in the latest (2.0.0) version of that module. Earlier versions of the eks-cluster module will still pull 2.0.0 but won't work with that, so we need to require at least 14.1.0. Note that the `~> 14.0` version constraints were working, but I'm updating them to `~> 14.1` to signal the intent that 14.1+ is required. The real fix is updating the `13.x` version(s) to 14.1. * fix(examples): bump GKE cluster module to 10.1+ v10.1.0 pinned the omni-cluster module version and adopted to a change in the latest (2.0.0) version of that module. Earlier versions of the gke-cluster module will still pull 2.0.0 but won't work with that, so we need to require at least v10.1.0. * fix(examples): bump AKS cluster module to 10.3+ v10.3.0 pinned the omni-cluster module version and adopted to a change in the latest (2.0.0) version of that module. Earlier versions of the AKS module will still pull 2.0.0 but won't work with that, so we need to require at least v10.3.0. * chore(examples): removing eks/eks_cluster_webshop example This example is using the terraform-aws-eks-lb-controller module to install the AWS LB Controller but that module wasn't updated to work with Helm 3+ that we require now. I'm removing it to unblock CI now as I don't think we need this example. * fix(examples): clean up removed variable
1 parent de91533 commit 434377b

File tree

60 files changed

+48
-1088
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+48
-1088
lines changed

examples/aks/aks_cluster/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ provider "helm" {
2020
# Configure AKS cluster connection to CAST AI using CAST AI aks-cluster module.
2121
module "castai-aks-cluster" {
2222
source = "castai/aks/castai"
23-
version = "~> 9.0"
23+
version = "~> 10.3"
2424

2525
api_url = var.castai_api_url
2626
castai_api_token = var.castai_api_token

examples/aks/aks_cluster_arm_template/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ provider "helm" {
2020
# Configure AKS cluster connection to CAST AI using CAST AI aks-cluster module.
2121
module "castai-aks-cluster" {
2222
source = "castai/aks/castai"
23-
version = "~> 9.0"
23+
version = "~> 10.3"
2424

2525
api_url = var.castai_api_url
2626
castai_api_token = var.castai_api_token

examples/aks/aks_cluster_autoscaler_policies/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ provider "helm" {
2020
# Configure AKS cluster connection to CAST AI using CAST AI aks-cluster module.
2121
module "castai-aks-cluster" {
2222
source = "castai/aks/castai"
23-
version = "~> 9.0"
23+
version = "~> 10.3"
2424

2525
api_url = var.castai_api_url
2626
castai_api_token = var.castai_api_token

examples/aks/aks_cluster_azure_cni/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ provider "helm" {
2020
# Configure AKS cluster connection to CAST AI using CAST AI aks-cluster module.
2121
module "castai-aks-cluster" {
2222
source = "castai/aks/castai"
23-
version = "~> 9.0"
23+
version = "~> 10.3"
2424

2525
api_url = var.castai_api_url
2626
castai_api_token = var.castai_api_token

examples/aks/aks_cluster_existing/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ data "azurerm_kubernetes_cluster" "example" {
99
# Configure AKS cluster connection to CAST AI using CAST AI aks-cluster module.
1010
module "castai_aks_cluster" {
1111
source = "castai/aks/castai"
12-
version = "~> 10.0"
12+
version = "~> 10.3"
1313

1414
api_url = var.castai_api_url
1515
castai_api_token = var.castai_api_token

examples/aks/aks_cluster_with_proxy/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ locals {
77

88
module "castai-aks-cluster" {
99
source = "castai/aks/castai"
10-
version = "~> 9.0"
10+
version = "~> 10.3"
1111

1212
api_url = var.castai_api_url
1313
castai_api_token = var.castai_api_token

examples/aks/aks_cluster_with_security/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ data "azurerm_subscription" "current" {}
66
# Configure AKS cluster connection to CAST AI using CAST AI aks-cluster module with enabled Kvisor security agent.
77
module "castai-aks-cluster" {
88
source = "castai/aks/castai"
9-
version = "~> 9.0"
9+
version = "~> 10.3"
1010

1111
kvisor_grpc_addr = var.kvisor_grpc_addr
1212

examples/aks/aks_cluster_with_security_runtime_rules/castai.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ data "azurerm_subscription" "current" {}
66
# Configure AKS cluster connection to CAST AI using CAST AI aks-cluster module with enabled Kvisor security agent.
77
module "castai-aks-cluster" {
88
source = "castai/aks/castai"
9-
version = "~> 9.0"
9+
version = "~> 10.3"
1010

1111
kvisor_grpc_addr = var.kvisor_grpc_addr
1212

examples/eks/eks_cluster_access_entries/castai.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ resource "castai_eks_clusterid" "cluster_id" {
4949

5050
module "castai_eks_cluster" {
5151
source = "castai/eks-cluster/castai"
52-
version = "~> 14.0"
52+
version = "~> 14.1"
5353
api_url = var.castai_api_url
5454
castai_api_token = var.castai_api_token
5555
grpc_url = var.castai_grpc_url
@@ -79,5 +79,5 @@ module "castai_eks_cluster" {
7979

8080
// depends_on helps Terraform with creating proper dependencies graph in case of resource creation and in this case destroy.
8181
// module "castai-eks-cluster" has to be destroyed before module "castai_eks_role_iam".
82-
depends_on = [module.castai_eks_role_iam]
82+
depends_on = [module.castai_eks_role_iam, module.vpc, module.eks]
8383
}

examples/eks/eks_cluster_access_entries/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ variable "cluster_name" {
77
variable "cluster_version" {
88
type = string
99
description = "EKS cluster name version."
10-
default = "1.32"
10+
default = "1.33"
1111
}
1212

1313
variable "cluster_region" {

0 commit comments

Comments
 (0)