Add tests, improve docs and descriptions

Author: kasia-kujawa

castai/resource_node_template.go

@@ -651,21 +651,23 @@ func resourceNodeTemplate() *schema.Resource {
 					"Custom instances are only supported in GCP.",
 			},
 			FieldNodeTemplateGpu: {
-				Type:     schema.TypeList,
-				MaxItems: 1,
-				Optional: true,
+				Type:        schema.TypeList,
+				MaxItems:    1,
+				Optional:    true,
+				Description: "GPU configuration.",
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						FieldNodeTemplateEnableTimeSharing: {
 							Type:        schema.TypeBool,
 							Optional:    true,
+							Default:     false,
 							Description: "Enable/disable GPU time-sharing.",
 						},
 						FieldNodeTemplateDefaultSharedClientsPerGpu: {
 							Type:        schema.TypeInt,
 							Optional:    true,
 							Default:     1,
-							Description: "Defines default shared client per GPU.",
+							Description: "Defines default number of shared clients per GPU.",
 						},
 						FieldNodeTemplateSharingConfiguration: {
 							Type:        schema.TypeList,
@@ -681,7 +683,7 @@ func resourceNodeTemplate() *schema.Resource {
 									FieldNodeTemplateSharedClientsPerGpu: {
 										Type:        schema.TypeInt,
 										Required:    true,
-										Description: "Defines default shared clients per GPU.",
+										Description: "Defines number of shared clients for specific GPU device.",
 									},
 								},
 							},

castai/resource_node_template_test.go

@@ -682,6 +682,8 @@ func TestAccResourceNodeTemplate_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.#", "1"),
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.0.cpu_limit_enabled", "false"),
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.0.cpu_limit_max_cores", "0"),
+					resource.TestCheckResourceAttr(resourceName, "gpu.0.default_shared_clients_per_gpu", "1"),
+					resource.TestCheckResourceAttr(resourceName, "gpu.0.enable_time_sharing", "false"),
 				),
 			},
 			{
@@ -758,7 +760,8 @@ func TestAccResourceNodeTemplate_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.#", "1"),
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.0.cpu_limit_enabled", "true"),
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.0.cpu_limit_max_cores", "50"),
-					resource.TestCheckResourceAttr(resourceName, "constraints.0.bare_metal", "false"),
+					resource.TestCheckResourceAttr(resourceName, "gpu.0.default_shared_clients_per_gpu", "1"),
+					resource.TestCheckResourceAttr(resourceName, "gpu.0.enable_time_sharing", "false"),
 				),
 			},
 		},
@@ -805,6 +808,16 @@ func testAccNodeTemplateConfig(rName, clusterName string) string {
 				key = "%[1]s-taint-key-4"
 			}
 
+			gpu {
+			  default_shared_clients_per_gpu = 1
+			  enable_time_sharing            = false
+		
+			  sharing_configuration {
+				gpu_name = "L4"
+				shared_clients_per_gpu = 8
+			  }
+			}
+
 			constraints {
 				fallback_restore_rate_seconds = 1800
 				spot = true
@@ -870,6 +883,11 @@ func testNodeTemplateUpdated(rName, clusterName string) string {
 				effect = "NoSchedule"
 			}
 
+			gpu {
+			  default_shared_clients_per_gpu = 1
+			  enable_time_sharing            = false
+			}
+
 			constraints {
 				use_spot_fallbacks = true
 				spot = true