Merge branch 'master' into chore/imds-fixes-eks-examples

Author: primoz-hrovat

castai/resource_autoscaler_test.go

@@ -7,13 +7,16 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"os"
 	"reflect"
 	"strings"
 	"testing"
 
 	"github.com/golang/mock/gomock"
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
+	"github.com/hashicorp/terraform-plugin-testing/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/samber/lo"
 	"github.com/stretchr/testify/require"
 
@@ -968,3 +971,114 @@ func JSONBytesEqual(a, b []byte) (bool, error) {
 	}
 	return reflect.DeepEqual(j2, j), nil
 }
+
+func TestAccEKS_ResourceAutoscaler_basic(t *testing.T) {
+	rName := fmt.Sprintf("%v-autoscaler-%v", ResourcePrefix, acctest.RandString(8))
+	clusterName, _ := lo.Coalesce(os.Getenv("CLUSTER_NAME"), "cost-terraform")
+
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() { testAccPreCheck(t) },
+
+		ProviderFactories: providerFactories,
+		Steps: []resource.TestStep{
+			// Step 1: Create autoscaler with initial settings
+			{
+				Config: testAccAutoscalerConfig(rName, clusterName, true, false),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.enabled", "true"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.is_scoped_mode", "false"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_templates_partial_matching_enabled", "false"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.unschedulable_pods.0.enabled", "true"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.cluster_limits.0.enabled", "true"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.cluster_limits.0.cpu.0.min_cores", "1"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.cluster_limits.0.cpu.0.max_cores", "100"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_downscaler.0.enabled", "true"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_downscaler.0.empty_nodes.0.enabled", "true"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_downscaler.0.empty_nodes.0.delay_seconds", "120"),
+				),
+			},
+			// Step 2: Update autoscaler settings
+			{
+				Config: testAccAutoscalerConfig(rName, clusterName, false, true),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.enabled", "false"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.is_scoped_mode", "true"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_templates_partial_matching_enabled", "true"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.unschedulable_pods.0.enabled", "false"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.cluster_limits.0.enabled", "false"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.cluster_limits.0.cpu.0.min_cores", "2"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.cluster_limits.0.cpu.0.max_cores", "200"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_downscaler.0.enabled", "false"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_downscaler.0.empty_nodes.0.enabled", "false"),
+					resource.TestCheckResourceAttr("castai_autoscaler.test", "autoscaler_settings.0.node_downscaler.0.empty_nodes.0.delay_seconds", "300"),
+				),
+			},
+		},
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"aws": {
+				Source:            "hashicorp/aws",
+				VersionConstraint: "~> 5.0",
+			},
+		},
+	})
+}
+
+func testAccAutoscalerConfig(rName, clusterName string, enabled bool, updated bool) string {
+	isScopedMode := "false"
+	nodeTemplatesPartialMatchingEnabled := "false"
+	unschedulablePodsEnabled := "true"
+	clusterLimitsEnabled := "true"
+	minCores := 1
+	maxCores := 100
+	nodeDownscalerEnabled := "true"
+	emptyNodesEnabled := "true"
+	delaySeconds := 120
+
+	if updated {
+		isScopedMode = "true"
+		nodeTemplatesPartialMatchingEnabled = "true"
+		unschedulablePodsEnabled = "false"
+		clusterLimitsEnabled = "false"
+		minCores = 2
+		maxCores = 200
+		nodeDownscalerEnabled = "false"
+		emptyNodesEnabled = "false"
+		delaySeconds = 300
+	}
+
+	return ConfigCompose(testAccEKSClusterConfig(rName, clusterName), fmt.Sprintf(`
+resource "castai_autoscaler" "test" {
+  cluster_id = castai_eks_cluster.test.id
+
+  autoscaler_settings {
+    enabled                                = %t
+    is_scoped_mode                         = %s
+    node_templates_partial_matching_enabled = %s
+
+    unschedulable_pods {
+      enabled = %s
+    }
+
+    cluster_limits {
+      enabled = %s
+
+      cpu {
+        min_cores = %d
+        max_cores = %d
+      }
+    }
+
+    node_downscaler {
+      enabled = %s
+
+      empty_nodes {
+        enabled       = %s
+        delay_seconds = %d
+      }
+    }
+  }
+}
+`, enabled, isScopedMode, nodeTemplatesPartialMatchingEnabled,
+		unschedulablePodsEnabled, clusterLimitsEnabled, minCores, maxCores,
+		nodeDownscalerEnabled, emptyNodesEnabled, delaySeconds))
+}

castai/resource_node_template_test.go

@@ -627,7 +627,7 @@ func TestAccEKS_ResourceNodeTemplate_basic(t *testing.T) {
 	resourceName := "castai_node_template.test"
 	clusterName, _ := lo.Coalesce(os.Getenv("CLUSTER_NAME"), "cost-terraform")
 
-	resource.ParallelTest(t, resource.TestCase{
+	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
 		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
 		CheckDestroy:             testAccCheckNodeTemplateDestroy(rName),