KUBE-997: refactor

Author: ValyaB

castai/data_source_gke.go

@@ -8,7 +8,6 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 const (
@@ -27,16 +26,13 @@ func dataSourceGKEPolicies() *schema.Resource {
 		Schema: map[string]*schema.Schema{
 			fieldGKEPoliciesFeatures: {
 				Description: "Provide a list of GCP feature names to include the necessary policies for them to work.",
-				Type:        schema.TypeList,
+				Type:        schema.TypeMap,
 				ForceNew:    true,
 				Optional:    true,
 				Elem: &schema.Schema{
-					Type: schema.TypeString,
-					ValidateFunc: validation.StringInSlice([]string{
-						loadBalancersTargetBackendPoolsFeature,
-						loadBalancersUnmanagedInstanceGroupsFeature,
-					}, false),
+					Type: schema.TypeBool,
 				},
+				ValidateFunc: validateFeatureKeys,
 			},
 			fieldGKEPoliciesPolicy: {
 				Type:     schema.TypeList,
@@ -49,7 +45,7 @@ func dataSourceGKEPolicies() *schema.Resource {
 
 func dataSourceGKEPoliciesRead(_ context.Context, data *schema.ResourceData, _ interface{}) diag.Diagnostics {
 	// add policies per specified features
-	features, ok := data.Get(fieldGKEPoliciesFeatures).([]interface{})
+	featuresMap, ok := data.Get(fieldGKEPoliciesFeatures).(map[string]interface{})
 	if !ok {
 		return diag.FromErr(fmt.Errorf("failed to retrieve features"))
 	}
@@ -58,7 +54,11 @@ func dataSourceGKEPoliciesRead(_ context.Context, data *schema.ResourceData, _ i
 	policySet := make(map[string]struct{})
 
 	// Process each feature
-	for _, feature := range features {
+	for feature, enabled := range featuresMap {
+		if !enabled.(bool) {
+			continue
+		}
+
 		var err error
 		var policies []string
 
@@ -107,3 +107,17 @@ func appendArrayToMap(arr []string, m map[string]struct{}) map[string]struct{} {
 	}
 	return m
 }
+
+func validateFeatureKeys(val interface{}, key string) (warns []string, errs []error) {
+	allowedFeatures := map[string]struct{}{
+		loadBalancersTargetBackendPoolsFeature:      {},
+		loadBalancersUnmanagedInstanceGroupsFeature: {},
+	}
+
+	for k := range val.(map[string]interface{}) {
+		if _, ok := allowedFeatures[k]; !ok {
+			errs = append(errs, fmt.Errorf("%q contains an invalid feature key: %s", key, k))
+		}
+	}
+	return
+}

castai/data_source_gke_test.go

@@ -13,23 +13,23 @@ import (
 func Test_dataSourceGKEPoliciesRead(t *testing.T) {
 	tests := []struct {
 		name     string
-		features []interface{}
+		features map[string]bool
 		expected int
 		hasError bool
 	}{
 		{
 			name: "all features",
-			features: []interface{}{
-				loadBalancersTargetBackendPoolsFeature,
-				loadBalancersUnmanagedInstanceGroupsFeature,
+			features: map[string]bool{
+				loadBalancersTargetBackendPoolsFeature:      true,
+				loadBalancersUnmanagedInstanceGroupsFeature: true,
 			},
 			expected: 42, // -1 for the duplicate policy
 			hasError: false,
 		},
 		{
 			name: "loadBalancersTargetBackendPoolsFeature",
-			features: []interface{}{
-				loadBalancersTargetBackendPoolsFeature,
+			features: map[string]bool{
+				loadBalancersTargetBackendPoolsFeature: true,
 			},
 			expected: 41, // -1 for the duplicate policy
 			hasError: false,