fix: add DiffSuppressFunc to compare lists in GPU configuration

Author: kasia-kujawa

castai/resource_node_template.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"log"
 	"reflect"
+	"sort"
 	"strings"
 	"time"
 
@@ -651,28 +652,30 @@ func resourceNodeTemplate() *schema.Resource {
 					"Custom instances are only supported in GCP.",
 			},
 			FieldNodeTemplateGpu: {
-				Type:        schema.TypeList,
-				MaxItems:    1,
-				Optional:    true,
-				Description: "GPU configuration.",
+				Type:             schema.TypeList,
+				MaxItems:         1,
+				Optional:         true,
+				Description:      "GPU configuration.",
+				DiffSuppressFunc: compareLists,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						FieldNodeTemplateEnableTimeSharing: {
 							Type:        schema.TypeBool,
 							Optional:    true,
-							Default:     false,
+							Default:     nil,
 							Description: "Enable/disable GPU time-sharing.",
 						},
 						FieldNodeTemplateDefaultSharedClientsPerGpu: {
 							Type:        schema.TypeInt,
 							Optional:    true,
-							Default:     1,
+							Default:     nil,
 							Description: "Defines default number of shared clients per GPU.",
 						},
 						FieldNodeTemplateSharingConfiguration: {
-							Type:        schema.TypeList,
-							Optional:    true,
-							Description: "Defines GPU sharing configurations for GPU devices.",
+							Type:             schema.TypeList,
+							Optional:         true,
+							Description:      "Defines GPU sharing configurations for GPU devices.",
+							DiffSuppressFunc: compareLists,
 							Elem: &schema.Resource{
 								Schema: map[string]*schema.Schema{
 									FieldNodeTemplateSharedGpuName: {
@@ -1705,3 +1708,37 @@ func toTemplateConstraintsNodeAffinity(o map[string]any) *sdk.NodetemplatesV1Tem
 
 	return &out
 }
+
+// compareLists compares state of two lists
+// inspired by https://github.com/hashicorp/terraform-plugin-sdk/issues/477#issuecomment-1238807249
+func compareLists(key, oldValue, newValue string, d *schema.ResourceData) bool {
+	// The key is a path not the list itself, e.g. "gpu.0"
+	lastDotIndex := strings.LastIndex(key, ".")
+	if lastDotIndex != -1 {
+		key = string(key[:lastDotIndex])
+	}
+	oldData, newData := d.GetChange(key)
+	if oldData == nil || newData == nil {
+		return false
+	}
+
+	oldArray, okOldArray := oldData.([]interface{})
+	newArray, okNewArray := newData.([]interface{})
+	if okOldArray && okNewArray {
+		if len(oldArray) != len(newArray) {
+			return false
+		}
+		oldItems := make([]string, len(oldArray))
+		newItems := make([]string, len(newArray))
+		for i, oldItem := range oldArray {
+			oldItems[i] = fmt.Sprint(oldItem)
+		}
+		for i, newItem := range newArray {
+			newItems[i] = fmt.Sprint(newItem)
+		}
+		sort.Strings(oldItems)
+		sort.Strings(newItems)
+		return reflect.DeepEqual(oldItems, newItems)
+	}
+	return false
+}

castai/resource_node_template_test.go

@@ -682,8 +682,6 @@ func TestAccResourceNodeTemplate_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.#", "1"),
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.0.cpu_limit_enabled", "false"),
 					resource.TestCheckResourceAttr(resourceName, "constraints.0.resource_limits.0.cpu_limit_max_cores", "0"),
-					resource.TestCheckResourceAttr(resourceName, "gpu.0.default_shared_clients_per_gpu", "1"),
-					resource.TestCheckResourceAttr(resourceName, "gpu.0.enable_time_sharing", "false"),
 				),
 			},
 			{
@@ -808,16 +806,6 @@ func testAccNodeTemplateConfig(rName, clusterName string) string {
 				key = "%[1]s-taint-key-4"
 			}
 
-			gpu {
-			  default_shared_clients_per_gpu = 1
-			  enable_time_sharing            = false
-		
-			  sharing_configuration {
-				gpu_name = "L4"
-				shared_clients_per_gpu = 8
-			  }
-			}
-
 			constraints {
 				fallback_restore_rate_seconds = 1800
 				spot = true