New Typedef library #1889
linting.yml
on: pull_request
overcommit
6m 10s
rubocop
31s
rbs validate
1m 20s
.rubocop_todo.yml
1m 54s
Annotations
5 errors and 14 warnings
|
rubocop
Process completed with exit code 1.
|
|
rubocop
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
|
.rubocop_todo.yml
Process completed with exit code 1.
|
|
.rubocop_todo.yml
Process completed with exit code 1.
|
|
overcommit
Process completed with exit code 65.
|
|
rubocop
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683, ruby/setup-ruby@1a615958ad9d422dd932dc1d5823942ee002799f. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
rubocop:
lib/solargraph/typedef.rb#L41
[rubocop] reported by reviewdog 🐶
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Raw Output:
lib/solargraph/typedef.rb:41:14: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
rubocop:
lib/solargraph/pin/parameter.rb#L27
[rubocop] reported by reviewdog 🐶
Trailing whitespace detected.
Raw Output:
lib/solargraph/pin/parameter.rb:27:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
|
|
rubocop:
lib/solargraph/pin/parameter.rb#L26
[rubocop] reported by reviewdog 🐶
Use def without parentheses.
Raw Output:
lib/solargraph/pin/parameter.rb:26:35: C: Style/MethodDefParentheses: Use def without parentheses.
|
|
rubocop:
lib/solargraph/pin/parameter.rb#L26
[rubocop] reported by reviewdog 🐶
Put empty method definitions on a single line.
Raw Output:
lib/solargraph/pin/parameter.rb:26:7: C: Style/EmptyMethod: Put empty method definitions on a single line.
|
|
rubocop:
lib/solargraph/pin/callable.rb#L171
[rubocop] reported by reviewdog 🐶
Use def without parentheses.
Raw Output:
lib/solargraph/pin/callable.rb:171:31: C: Style/MethodDefParentheses: Use def without parentheses.
|
|
rubocop:
lib/solargraph/pin/base.rb#L732
[rubocop] reported by reviewdog 🐶
Memoized variable `@generics` does not match method name `typedef_generics`. Use `@typedef_generics` instead.
Raw Output:
lib/solargraph/pin/base.rb:732:9: C: Naming/MemoizedInstanceVariableName: Memoized variable `@generics` does not match method name `typedef_generics`. Use `@typedef_generics` instead.
|
|
rubocop:
lib/solargraph/pin/base.rb#L81
[rubocop] reported by reviewdog 🐶
Method `Solargraph::Pin::Base#expansions` is defined at both lib/solargraph/pin/base.rb:36 and lib/solargraph/pin/base.rb:81.
Raw Output:
lib/solargraph/pin/base.rb:81:7: W: Lint/DuplicateMethods: Method `Solargraph::Pin::Base#expansions` is defined at both lib/solargraph/pin/base.rb:36 and lib/solargraph/pin/base.rb:81.
|
|
rubocop:
lib/solargraph/pin/base.rb#L81
[rubocop] reported by reviewdog 🐶
Expected 1 empty line between method definitions; found 2.
Raw Output:
lib/solargraph/pin/base.rb:81:7: C: Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
|
|
rubocop:
lib/solargraph/pin/base.rb#L80
[rubocop] reported by reviewdog 🐶
Extra blank line detected.
Raw Output:
lib/solargraph/pin/base.rb:80:1: C: Layout/EmptyLines: Extra blank line detected.
|
|
rubocop:
lib/solargraph/complex_type.rb#L407
[rubocop] reported by reviewdog 🐶
Pass `&:to_typedef_types` as an argument to `map` instead of a block.
Raw Output:
lib/solargraph/complex_type.rb:407:17: C: Style/SymbolProc: Pass `&:to_typedef_types` as an argument to `map` instead of a block.
|
|
.rubocop_todo.yml
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
rbs validate
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
overcommit
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, actions/checkout@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|