Skip to content

Crash on "craft as last time" after reloading a save without restarting the game #10083

Description

@de43gy

Describe the bug

Pressing "craft as last time" crashes the game with EXCEPTION_ACCESS_VIOLATION,
but only if the current world was loaded after a save-and-quit to the main menu
within the same game session. The last debug.log line before the crash is:

ERROR DEBUGMSG : src\recipe_dictionary.cpp:68 [obj] invalid recipe id ""

If the game binary is fully restarted, the same keypress correctly shows
"Craft something first" instead of crashing. So the "last recipe" state seems
to survive the in-session world unload in a corrupted form (empty id, while the
"has crafted" state passes the guard) — the empty recipe_id lookup returns the
null recipe and the caller dereferences it.

Steps To Reproduce

  1. Start the game and load a world, craft anything (e.g. a cudgel)
  2. Save and exit to the main menu (Shift+S)
  3. Load the same world again WITHOUT closing the game
  4. Press "craft as last time"
  5. Access violation crash

Extra notes:

  • On a freshly started game the same keypress just prints "Craft something
    first" — the in-session reload is required.
  • Reproduced on nightlies 2931685 (2026-08-10) and 0c79898 (2026-08-16).
  • crash.log + crash.log.dmp available on request.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.26200 (Windows 11 Home)
  • Game Version: 0c79898-dirty (2026-08-16) [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Save File Version: V2 (compressed with sqlite 3)
  • Game Language: []
  • Mods loaded: [
    Bright Nights [bn],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    Limit Fungal Growth [limit_fungal_growth],
    Tablet e-book [tablet_ebook],
    Bionic Slots [cbm_slots],
    Lethal Zombies [lethal_zeds],
    Exotic ammo types [exotic_ammo],
    Aftershock [aftershock],
    Bio-Synth Robot expansion [gekkobots],
    Mutant NPCs [mutant_npcs],
    Psychiclysm [psychiclysm],
    Teleportation [teleportation_tech],
    Weather Variants [weather_variants],
    Wild Living [WildLiving],
    Advanced Gear [adv_gear],
    Advanced Technologies [advtech],
    anti-fungal gear [anti_fungal_gears],
    Arsenal Breach [arsenal_breach],
    BioCo Content [bioco],
    Bionic Space Expander [Bionic_Space_Expander],
    Bionics Systems Recipes [bio_recipes],
    Modular Turrets with No Blacklist [modular_turrets_no_blacklist],
    Bootleg Walkers [Bootleg_Walkers],
    CBM Equipment [CBM_Arms],
    Expanded Archery [ExArch],
    Growable Various Plants Flowerpot (uekibati) mod [Uekibati_mod],
    Homemade Fungicide [homemade_fungicide],
    Jump Pad [jump_pad],
    Large capacity storage CBMs [eps_cbm],
    More Armors [More_Armors],
    More Makeshift Stuff [makeshift_stuff],
    Rivtech Beam Swords [beamswordmod],
    Blazemod - Vehicle Additions Pack [blazemod],
    Crazy Labs [crazy_labs],
    Draco's Dog Mod [DracoDogMod],
    Mutant Animals [mutant_animals],
    Mutant Insects [mutant_insects],
    Salvaged Robots [Salvaged_Robots],
    Arcana and Magic Items [Arcana],
    Arcana/Aftershock Patchmod [Arcana_aftershock_Patch],
    Alternative Map Key [alt_map_key],
    Even More Mutations [even_more_mutations],
    Hydroponics [hydroponics],
    Jury-Rigged Robots [jury_rigged_robots],
    Merchant Mod [Merchant],
    More Survivor Stuff [more_survivor_stuff],
    Mug NPCs [mug_NPCs],
    NPC Recruitment Options [recruitment_options],
    Wandering Masters [wandering_masters],
    Alternative Basement Layouts [basement_extension],
    Caches [P_Caches],
    More Locations [more_locations],
    Morlock Village [morlock_village],
    Randomized Mall [randomized_mall],
    Ships From Oa Additional Buildings [Ships],
    Trailer Parks [trailerpark],
    Whaleys TALL Buildings [whaleys_tallbuild],
    Cars to Wrecks [cars_to_wrecks],
    Folding Parts pack [deoxymod],
    Shrub it off [shrub_mod],
    Vampiric Stuff [vamp_stuff],
    Vampiric Stuff + Arcana Mod Extension [vamp_stuff+arcana],
    SpeedyDex [speedydex],
    Vehicle Additions Additions [blaze_extension_M],
    Stats Through Skills [StatsThroughSkills],
    Project: Packrat [Jake's_Squirrel_mod],
    Transformers [ny_transformers],
    Cataclysm++ [Cata++],
    Arcana/Cata++ Patchmod [Arcana_Cata++_Patch],
    Cata++/Exotic ammo types Patchmod [Cata++_Exotic_Ammo_Patch],
    MST Extra [MST_Extra]
    ]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions