Fix #104 - return correct values in get_state call when subcourse not configured with completion.

danmarsden · danmarsden · commit 1c36364fc5d2 · 2025-02-20T21:07:52.000+13:00
diff --git a/classes/completion/custom_completion.php b/classes/completion/custom_completion.php
@@ -43,12 +43,12 @@ public function get_state(string $rule): int {
 
         if (empty($subcourse->completioncourse)) {
             // The rule not enabled, return early.
-            return $type;
+            return COMPLETION_UNKNOWN;
         }
 
         if (empty($subcourse->refcourse)) {
             // Misconfigured subcourse instance, behave as if was not enabled.
-            return $type;
+            return COMPLETION_INCOMPLETE;
         }
 
         // Check if the referenced course is completed.

Original file line number	Diff line number	Diff line change
`@@ -43,12 +43,12 @@ public function get_state(string $rule): int {`
`43`	`43`
`44`	`44`	`if (empty($subcourse->completioncourse)) {`
`45`	`45`	`// The rule not enabled, return early.`
`46`		`- return $type;`
	`46`	`+ return COMPLETION_UNKNOWN;`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`if (empty($subcourse->refcourse)) {`
`50`	`50`	`// Misconfigured subcourse instance, behave as if was not enabled.`
`51`		`- return $type;`
	`51`	`+ return COMPLETION_INCOMPLETE;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`// Check if the referenced course is completed.`