WIP more codechecker fixups

Author: matthewhilton

classes/check/tagging_status.php

@@ -29,28 +29,28 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class tagging_status extends check {
-	// TODO action link.
+    // TODO action link.
 
     /**
      * Get result
      * @return result
      */
-	public function get_result(): result {
-		if(!tag_manager::is_tagging_enabled_and_supported()) {
-			return new result(result::NA, 'Not enabled or supported by fs'); // TODO lang. 
-		}
+    public function get_result(): result {
+        if(!tag_manager::is_tagging_enabled_and_supported()) {
+            return new result(result::NA, 'Not enabled or supported by fs'); // TODO lang. 
+        }
 
-		// Do a tag set test.
+        // Do a tag set test.
         $config = \tool_objectfs\local\manager::get_objectfs_config();
         $client = \tool_objectfs\local\manager::get_client($config);
-		$result = $client->test_set_object_tag();
+        $result = $client->test_set_object_tag();
 
-		if ($result->success) {
-			// TODO lang.
-			return new result(result::OK, 'tagging success', $result->details);
-		} else {
-			// TODO lang.
-			return new result(result::ERROR, 'tagging failed', $result->details);
-		}
-	}
-}
+        if ($result->success) {
+            // TODO lang.
+            return new result(result::OK, 'tagging success', $result->details);
+        } else {
+            // TODO lang.
+            return new result(result::ERROR, 'tagging failed', $result->details);
+        }
+    }
+}

classes/local/store/object_file_system.php

@@ -353,7 +353,9 @@ public function copy_object_from_local_to_external_by_hash($contenthash, $object
         $finallocation = $initiallocation;
 
         if ($initiallocation === OBJECT_LOCATION_LOCAL) {
+
             $success = $this->copy_from_local_to_external($contenthash);
+
             if ($success) {
                 $finallocation = OBJECT_LOCATION_DUPLICATED;
             }

classes/local/store/s3/client.php

@@ -392,7 +392,6 @@ public function test_permissions($testdelete) {
         return $permissions;
     }
 
-
     /**
      * get_exception_details
      * @param \Exception $exception

classes/local/tag/file_type_source.php

@@ -60,4 +60,4 @@ public function get_value_for_contenthash(string $contenthash): ?string {
 
         return self::TYPE_UNCATEGORISED;
     }
-}
+}

classes/local/tag/tag_manager.php

@@ -257,4 +257,4 @@ private static function mark_object_tag_sync_status(string $contenthash, int $st
     private static function are_tags_different(array $a, array $b): bool {
         return $a !== $b;
     }
-}
+}

classes/local/tag/tag_source.php

@@ -41,4 +41,4 @@ public static function get_identifier(): string;
      * @return string
      */
     public function get_value_for_contenthash(string $contenthash): ?string;
-}
+}

classes/task/queue_objects_needing_tags.php

@@ -58,4 +58,4 @@ public function execute() {
             manager::queue_adhoc_task($task, true);
         }
     }
-}
+}

classes/task/update_object_tags.php

@@ -49,4 +49,4 @@ public function execute() {
         // TODO if this fails because of 404, just ignore since file is clearly not replicated yet
         tag_manager::replicate_local_to_external_tags_for_object($contenthash);
     }
-}
+}

tests/local/tagging_test.php

@@ -308,4 +308,4 @@ public function test_replicate_local_to_external_tags_for_object() {
         $status = $DB->get_field('tool_objectfs_objects', 'tagsyncstatus', ['id' => $object->id]);
         $this->assertEquals(tag_manager::SYNC_STATUS_SYNC_NOT_REQUIRED, $status);
     }
-}
+}