WR# 433576: When a file has 0 bytes do not mark it as error

Author: guillogo

classes/local/store/object_file_system.php

@@ -406,7 +406,7 @@ public function readfile(\stored_file $file) {
 
             $this->logger->log_object_read('readfile', $path, $file->get_filesize());
 
-            if (!$success) {
+            if ($success === false) {
                 manager::update_object_by_hash($file->get_contenthash(), OBJECT_LOCATION_ERROR);
             }
         }

classes/local/store/s3/file_system.php

@@ -59,7 +59,7 @@ public function readfile(\stored_file $file) {
         $this->get_logger()->end_timing();
         $this->get_logger()->log_object_read('readfile', $path, $file->get_filesize());
 
-        if (!$success) {
+        if ($success === false) {
             manager::update_object_by_hash($file->get_contenthash(), OBJECT_LOCATION_ERROR);
             throw new \file_exception('storedfilecannotreadfile', $file->get_filename());
         }