Skip to content
This repository was archived by the owner on Dec 3, 2019. It is now read-only.
This repository was archived by the owner on Dec 3, 2019. It is now read-only.

[wpr-go] Incorrect order of responses for requests with the same url #4645

@ulan

Description

@ulan

WPR seems to mix up the order of responses in findBestMatchInArchivedRequestSet.

Steps to reproduce:

  • cd $CHROMIUM_SRC
  • git cl patch 1761597
  • Live run: ./tools/perf/run_benchmark run v8.browsing_desktop --browser=system --output-format=html --story-filter='browse:tools:sheets' --show-stdout --pageset-repeat=1 --use-live-sites
  • Record: ./tools/perf/record_wpr '--story-filter=^browse\:tools\:sheets\:2019$' --browser=system desktop_system_health_story_set
  • Replay: ./tools/perf/run_benchmark run v8.browsing_desktop --browser=system --output-format=html --story-filter='browse:tools:sheets' --show-stdout --pageset-repeat=1

Expected: The replay runs without errors.
Actual: The web page shows "Error: Class$obf_1001: removeSent called when not waiting for ack"

Note that the live run may fail in future if the web page changes. Let me know if that happens and I'll adjust the JS code in the CL.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions