Rename suggestion selection highlight not visible in dark flavours

[mnemotic]

Is there an existing issue outlining your problem?

• I have searched the existing issues and they do not solve my problem.

Have you followed the instructions in the the pinned issue?

• I have followed the instructions in the pinned issue and they do not solve my problem.

Describe your problem.

There is no visible highlight of selection in the suggestion list of Rename dialog. This issue affect all dark themes: Mocha, Macchiato, and Frappe. Latte theme has a visible highlight (see attached screenshots).

Attach screenshots.

Mocha:

Macchiato:

Frappe:

Latte:

What IDE(s) are you seeing the problem on?

Rider 2024.2.3

Any additional comments?

No response

[sgoudham]

Hey 👋

I'm trying to reproduce this on Intellij 2024.2 but I'm not actually getting any suggestions when I try to rename a field. Are you using the built-in AI Assistant by any chance to power these suggestions?

Or is this somehow exclusive to Rider?

[mnemotic]

I think this could be specific to Rider / ReSharper plugin, but I'm not 100% positive on that. Definitely not AI Assistant. I have that disabled.

[sgoudham]

Can you provide the file that you were working on? I'd like to try and invoke the rename dialog on specifically the field shown in the screenshots

[mnemotic]

I don't see how that's relevant but I've attached a different file that has the same issue anyways.

Program.zip

I trigger the Rename dialog either by pressing F2 or through Refactor / Rename... menu item. Any member of a class or struct will get a Rename dialog; local variables get a suggestion list "in-line", without a Rename dialog and that list does have a highlight. You can try to rename index local variable and FindIndexOfFirstNonEmptyBin method in the attached code to see the difference. The latter should get a Rename dialog.

HTH

[mnemotic]

Is there anything I can do to contribute to troubleshooting this issue?

[sgoudham]

Hey, sorry I haven't had a chance to look at this.

I definitely can't reproduce this on Intellij as shown below so I'd have to guess it's a Rider specific thing

[mnemotic]

I also failed to reproduce this in IntelliJ. I think you're right about this being Rider-specific.

[sgoudham]

Not sure why I didn't think of this earlier, are you able to reproduce this behaviour on the default Dark colour scheme or any other colour schemes that offer both dark/light variants? That would let us know if it's a Rider specific problem caused by Catppuccin or if it's a bug with the underlying system.

[mnemotic]

Good thinking! I just tested this and all built-in and bundled dark themes, including Dark, have the selection highlight. I also tested two custom dark themes: One Dark and Gradianto. Both of these also have the selection highlight.

[sgoudham]

Well that doesn't make me too happy 😅

I'm honestly not really sure where to go from here, I know in the last year or two, JetBrains actually automatically control the contrast for some of the popups so we had to make some weird changes - not sure if those are coming into play here 🤔

I guess the next step is to try and find the key that's controlling the contrast and see if we can change it to see what happens / what other popups it affects.

[mnemotic]

Sorry to be the bearer of bad news. 😅

Is there anything I can do to assist?

[sgoudham]

I would like to check if this key is the reason why it's not showing up properly:

jetbrains/generateFlavours/ui.theme.json

Line 134 in 270eaff

"selectionBackground": "surface1",

i.e. if you changed it to something like surface2, recompiled the theme and installed it into your Rider IDE - does it look any different?

[mnemotic]

Changing selectionBackground from surface1 to surface2 changed the highlight color of the selected line for the "inline" rename suggestion list for local variables from #494D64 to #5B6078, making it appear brighter. It did not affect the highlight in Rename dialog in any way. 🙁

surface1 (#494D64)

surface2 (#5B6078)

[sgoudham]

I suppose it means that isn't the relevant key, if you install the Plugin Devkit plugin, you should get code completion for the ui.theme.json file and maybe there's a key in there that specifies the Rename dialog?