Skip to content

review #2

@ghost

Description

main.tf

Line 16: data object should be in data.tf
Line 40: data object should be in data.tf

Line 53: Do we really need to allow secretsmanager:GetSecretValue for all secrets? I think we can scope that down to try to follow the least privilege principle.

variables.tf

Line 7: regarding name, I would suggest enforcing kebab-case throughout the module , or moving to snake_case, but if we leave this as is, we could end up with a name like cost_alert-lambda-role. What is your preference?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions