Skip to content

Commit 45e9204

Browse files
committed
address review comment
1 parent d146f08 commit 45e9204

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

include/rocksdb/utilities/write_batch_with_index.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ class WBWIIterator {
8888
virtual bool HasOverWrittenSingleDel() const { return false; }
8989

9090
// Returns n where the current entry is the n-th update to the current key.
91+
// The update count starts from 1.
9192
// Only valid if WBWI is created with overwrite_key = true.
9293
virtual uint32_t GetUpdateCount() const { return 0; }
9394
};

utilities/write_batch_with_index/write_batch_with_index_internal.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,8 @@ struct WriteBatchIndexEntry {
165165
uint32_t column_family; // column family of the entry.
166166
// The following three fields are only maintained when the WBWI is created
167167
// with overwrite_key = true.
168-
uint32_t update_count; // number of updates for this key up to this entry.
168+
uint32_t update_count; // The number of updates (1-based) for this key up to
169+
// this entry.
169170
bool has_single_del; // whether single del was issued for this key
170171
bool has_overwritten_single_del; // whether a single del for this key was
171172
// overwritten by another key

0 commit comments

Comments
 (0)