Skip to content

Commit 0c20f0c

Browse files
committed
Fix Linux release assets and macOS code signing
1 parent 5714b40 commit 0c20f0c

2 files changed

Lines changed: 19 additions & 25 deletions

File tree

.github/workflows/build-macos.yml

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,6 @@ jobs:
6767
VERSION=$(sed -nE 's/^[[:space:]]*VERSION[[:space:]]+([0-9][0-9.]*)[[:space:]]*$/\1/p' CMakeLists.txt | head -1)
6868
echo "APP_VERSION=$VERSION" >> "$GITHUB_ENV"
6969
70-
- name: Deploy Qt frameworks
71-
run: $(brew --prefix qt)/bin/macdeployqt build/SigViewer.app
72-
7370
- name: Import Developer ID certificate
7471
env:
7572
MACOS_CERT_P12_BASE64: ${{ secrets.MACOS_CERT_P12_BASE64 }}
@@ -82,30 +79,15 @@ jobs:
8279
security import certificate.p12 -k build.keychain -P "$MACOS_CERT_PASSWORD" -T /usr/bin/codesign
8380
security set-key-partition-list -S apple-tool:,apple: -s -k "" build.keychain
8481
85-
- name: Sign .app bundle
86-
run: 'codesign --deep --force --options runtime --sign "Developer ID Application: CLEMENS BRUNNER (9UC2D22DW3)" build/SigViewer.app'
87-
88-
- name: Notarize .app bundle
89-
env:
90-
AC_USERNAME: ${{ secrets.AC_USERNAME }}
91-
AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
92-
run: |
93-
ditto -c -k --sequesterRsrc --keepParent build/SigViewer.app build/SigViewer.zip
94-
xcrun notarytool submit build/SigViewer.zip \
95-
--apple-id "$AC_USERNAME" \
96-
--password "$AC_PASSWORD" \
97-
--team-id 9UC2D22DW3 \
98-
--wait
99-
100-
- name: Staple .app bundle
101-
run: xcrun stapler staple build/SigViewer.app
82+
- name: Deploy Qt frameworks
83+
run: $(brew --prefix qt)/bin/macdeployqt build/SigViewer.app -sign-for-notarization="Developer ID Application: CLEMENS BRUNNER (9UC2D22DW3)"
10284

10385
- name: Create DMG
10486
run: |
10587
brew install create-dmg
10688
10789
mkdir dmg_staging
108-
cp -r build/SigViewer.app dmg_staging/
90+
ditto build/SigViewer.app dmg_staging/SigViewer.app
10991
11092
create-dmg \
11193
--volname "SigViewer" \
@@ -119,6 +101,18 @@ jobs:
119101
"build/SigViewer-${{ env.APP_VERSION }}.dmg" \
120102
"dmg_staging/"
121103
104+
- name: Notarize and staple DMG
105+
env:
106+
AC_USERNAME: ${{ secrets.AC_USERNAME }}
107+
AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
108+
run: |
109+
xcrun notarytool submit "build/SigViewer-${{ env.APP_VERSION }}.dmg" \
110+
--apple-id "$AC_USERNAME" \
111+
--password "$AC_PASSWORD" \
112+
--team-id 9UC2D22DW3 \
113+
--wait
114+
xcrun stapler staple "build/SigViewer-${{ env.APP_VERSION }}.dmg"
115+
122116
- name: Upload SigViewer artifact
123117
uses: actions/upload-artifact@v7
124118
with:

.github/workflows/release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ jobs:
3535
VERSION=${GITHUB_REF_NAME#v}
3636
mkdir -p release-assets
3737
38-
find artifacts/sigviewer-linux-x86_64 -type f -name 'sigviewer' \
39-
-exec tar -czf release-assets/sigviewer-${VERSION}-linux-x86_64.tar.gz -C "$(dirname {})" sigviewer \;
40-
find artifacts/sigviewer-linux-aarch64 -type f -name 'sigviewer' \
41-
-exec tar -czf release-assets/sigviewer-${VERSION}-linux-aarch64.tar.gz -C "$(dirname {})" sigviewer \;
38+
tar -czf release-assets/sigviewer-${VERSION}-linux-x86_64.tar.gz \
39+
-C artifacts/sigviewer-linux-x86_64 sigviewer
40+
tar -czf release-assets/sigviewer-${VERSION}-linux-aarch64.tar.gz \
41+
-C artifacts/sigviewer-linux-aarch64 sigviewer
4242
find artifacts/sigviewer-macos-arm64 -name '*.dmg' \
4343
-exec cp {} release-assets/sigviewer-${VERSION}-macos-arm64.dmg \;
4444
find artifacts/sigviewer-windows-x86_64 -name '*.exe' \

0 commit comments

Comments
 (0)