Remove impl pattern (#142)

* Remove impl pattern

* Remove impl pattern

* Remove invalid Windows path FileChannelManager::FileChannelManager

Author: cbrnr

CMakeLists.txt

@@ -77,8 +77,8 @@ set_target_properties(dep_libbiosig PROPERTIES
 # -- Sources -----------------------------------------------------------------
 qt_add_executable(sigviewer
     src/main.cpp
-    src/application_context_impl.cpp
-    src/application_context_impl.h
+    src/application_context.cpp
+    src/application_context.h
     src/command_executer.h
     src/file_context.cpp
     src/file_context.h
@@ -138,27 +138,26 @@ qt_add_executable(sigviewer
     src/file_handling/file_signal_writer_factory.cpp
     src/file_handling/file_signal_writer_factory.h
 
-    # file_handling_impl
-    src/file_handling_impl/biosig_basic_header.cpp
-    src/file_handling_impl/biosig_basic_header.h
-    src/file_handling_impl/biosig_reader.cpp
-    src/file_handling_impl/biosig_reader.h
-    src/file_handling_impl/biosig_writer.cpp
-    src/file_handling_impl/biosig_writer.h
-    src/file_handling_impl/channel_manager_impl.cpp
-    src/file_handling_impl/channel_manager_impl.h
-    src/file_handling_impl/event_manager_impl.cpp
-    src/file_handling_impl/event_manager_impl.h
-    src/file_handling_impl/event_table_file_reader.cpp
-    src/file_handling_impl/event_table_file_reader.h
-    src/file_handling_impl/evt_writer.cpp
-    src/file_handling_impl/evt_writer.h
-    src/file_handling_impl/file_handler_factory_registrator.h
-    src/file_handling_impl/xdf_reader.cpp
-    src/file_handling_impl/xdf_reader.h
+    # file_handling (impl)
+    src/file_handling/biosig_basic_header.cpp
+    src/file_handling/biosig_basic_header.h
+    src/file_handling/biosig_reader.cpp
+    src/file_handling/biosig_reader.h
+    src/file_handling/biosig_writer.cpp
+    src/file_handling/biosig_writer.h
+    src/file_handling/file_channel_manager.cpp
+    src/file_handling/file_channel_manager.h
+    src/file_handling/event_manager.cpp
+    src/file_handling/event_manager.h
+    src/file_handling/event_table_file_reader.cpp
+    src/file_handling/event_table_file_reader.h
+    src/file_handling/evt_writer.cpp
+    src/file_handling/evt_writer.h
+    src/file_handling/file_handler_factory_registrator.h
+    src/file_handling/xdf_reader.cpp
+    src/file_handling/xdf_reader.h
 
     # gui
-    src/gui/application_context.h
     src/gui/background_processes.cpp
     src/gui/background_processes.h
     src/gui/color_manager.cpp
@@ -169,110 +168,107 @@ qt_add_executable(sigviewer
     src/gui/gui_action_factory.cpp
     src/gui/gui_action_factory.h
     src/gui/gui_action_factory_registrator.h
+    src/gui/gui_helper_functions.cpp
+    src/gui/gui_helper_functions.h
+    src/gui/main_window.cpp
+    src/gui/main_window.h
+    src/gui/main_window_model.cpp
     src/gui/main_window_model.h
+    src/gui/processed_signal_channel_manager.cpp
+    src/gui/processed_signal_channel_manager.h
     src/gui/progress_bar.h
+    src/gui/select_shown_channels_dialog.cpp
+    src/gui/select_shown_channels_dialog.h
+    src/gui/signal_browser_mouse_handling.cpp
+    src/gui/signal_browser_mouse_handling.h
     src/gui/signal_view_settings.cpp
     src/gui/signal_view_settings.h
     src/gui/signal_visualisation_model.cpp
     src/gui/signal_visualisation_model.h
     src/gui/signal_visualisation_modes.h
     src/gui/signal_visualisation_view.h
+    src/gui/info_widgets/power_spectrum_info_widget.ui
 
-    # gui_impl
-    src/gui_impl/gui_helper_functions.cpp
-    src/gui_impl/gui_helper_functions.h
-    src/gui_impl/main_window.cpp
-    src/gui_impl/main_window.h
-    src/gui_impl/main_window_model_impl.cpp
-    src/gui_impl/main_window_model_impl.h
-    src/gui_impl/processed_signal_channel_manager.cpp
-    src/gui_impl/processed_signal_channel_manager.h
-    src/gui_impl/select_shown_channels_dialog.cpp
-    src/gui_impl/select_shown_channels_dialog.h
-    src/gui_impl/signal_browser_mouse_handling.cpp
-    src/gui_impl/signal_browser_mouse_handling.h
-    src/gui_impl/info_widgets/power_spectrum_info_widget.ui
-
-    # gui_impl/commands
-    src/gui_impl/commands/adapt_channel_view_gui_command.cpp
-    src/gui_impl/commands/adapt_channel_view_gui_command.h
-    src/gui_impl/commands/adapt_event_view_gui_command.cpp
-    src/gui_impl/commands/adapt_event_view_gui_command.h
-    src/gui_impl/commands/close_file_gui_command.cpp
-    src/gui_impl/commands/close_file_gui_command.h
-    src/gui_impl/commands/event_editing_gui_command.cpp
-    src/gui_impl/commands/event_editing_gui_command.h
-    src/gui_impl/commands/help_gui_command.cpp
-    src/gui_impl/commands/help_gui_command.h
-    src/gui_impl/commands/mouse_mode_gui_command.cpp
-    src/gui_impl/commands/mouse_mode_gui_command.h
-    src/gui_impl/commands/open_file_gui_command.cpp
-    src/gui_impl/commands/open_file_gui_command.h
-    src/gui_impl/commands/save_gui_command.cpp
-    src/gui_impl/commands/save_gui_command.h
-    src/gui_impl/commands/signal_processing_gui_command.cpp
-    src/gui_impl/commands/signal_processing_gui_command.h
-    src/gui_impl/commands/undo_redo_gui_command.cpp
-    src/gui_impl/commands/undo_redo_gui_command.h
-    src/gui_impl/commands/zoom_gui_command.cpp
-    src/gui_impl/commands/zoom_gui_command.h
+    # gui/commands
+    src/gui/commands/adapt_channel_view_gui_command.cpp
+    src/gui/commands/adapt_channel_view_gui_command.h
+    src/gui/commands/adapt_event_view_gui_command.cpp
+    src/gui/commands/adapt_event_view_gui_command.h
+    src/gui/commands/close_file_gui_command.cpp
+    src/gui/commands/close_file_gui_command.h
+    src/gui/commands/event_editing_gui_command.cpp
+    src/gui/commands/event_editing_gui_command.h
+    src/gui/commands/help_gui_command.cpp
+    src/gui/commands/help_gui_command.h
+    src/gui/commands/mouse_mode_gui_command.cpp
+    src/gui/commands/mouse_mode_gui_command.h
+    src/gui/commands/open_file_gui_command.cpp
+    src/gui/commands/open_file_gui_command.h
+    src/gui/commands/save_gui_command.cpp
+    src/gui/commands/save_gui_command.h
+    src/gui/commands/signal_processing_gui_command.cpp
+    src/gui/commands/signal_processing_gui_command.h
+    src/gui/commands/undo_redo_gui_command.cpp
+    src/gui/commands/undo_redo_gui_command.h
+    src/gui/commands/zoom_gui_command.cpp
+    src/gui/commands/zoom_gui_command.h
 
-    # gui_impl/dialogs
-    src/gui_impl/dialogs/about_dialog.ui
-    src/gui_impl/dialogs/basic_header_info_dialog.cpp
-    src/gui_impl/dialogs/basic_header_info_dialog.h
-    src/gui_impl/dialogs/channel_dialog.ui
-    src/gui_impl/dialogs/channel_selection_dialog.cpp
-    src/gui_impl/dialogs/channel_selection_dialog.h
-    src/gui_impl/dialogs/event_time_selection_dialog.cpp
-    src/gui_impl/dialogs/event_time_selection_dialog.h
-    src/gui_impl/dialogs/event_time_selection_dialog.ui
-    src/gui_impl/dialogs/event_type_selection_dialog.ui
-    src/gui_impl/dialogs/event_types_selection_dialog.cpp
-    src/gui_impl/dialogs/event_types_selection_dialog.h
-    src/gui_impl/dialogs/resampling_dialog.cpp
-    src/gui_impl/dialogs/resampling_dialog.h
-    src/gui_impl/dialogs/resampling_dialog.ui
-    src/gui_impl/dialogs/scale_channel_dialog.cpp
-    src/gui_impl/dialogs/scale_channel_dialog.h
-    src/gui_impl/dialogs/scale_channel_dialog.ui
+    # gui/dialogs
+    src/gui/dialogs/about_dialog.ui
+    src/gui/dialogs/basic_header_info_dialog.cpp
+    src/gui/dialogs/basic_header_info_dialog.h
+    src/gui/dialogs/channel_dialog.ui
+    src/gui/dialogs/channel_selection_dialog.cpp
+    src/gui/dialogs/channel_selection_dialog.h
+    src/gui/dialogs/event_time_selection_dialog.cpp
+    src/gui/dialogs/event_time_selection_dialog.h
+    src/gui/dialogs/event_time_selection_dialog.ui
+    src/gui/dialogs/event_type_selection_dialog.ui
+    src/gui/dialogs/event_types_selection_dialog.cpp
+    src/gui/dialogs/event_types_selection_dialog.h
+    src/gui/dialogs/resampling_dialog.cpp
+    src/gui/dialogs/resampling_dialog.h
+    src/gui/dialogs/resampling_dialog.ui
+    src/gui/dialogs/scale_channel_dialog.cpp
+    src/gui/dialogs/scale_channel_dialog.h
+    src/gui/dialogs/scale_channel_dialog.ui
 
-    # gui_impl/event_table
-    src/gui_impl/event_table/event_table_view_model.cpp
-    src/gui_impl/event_table/event_table_view_model.h
-    src/gui_impl/event_table/event_table_widget.cpp
-    src/gui_impl/event_table/event_table_widget.h
-    src/gui_impl/event_table/event_table_widget.ui
+    # gui/event_table
+    src/gui/event_table/event_table_view_model.cpp
+    src/gui/event_table/event_table_view_model.h
+    src/gui/event_table/event_table_widget.cpp
+    src/gui/event_table/event_table_widget.h
+    src/gui/event_table/event_table_widget.ui
 
-    # gui_impl/signal_browser
-    src/gui_impl/signal_browser/adapt_browser_view_widget.cpp
-    src/gui_impl/signal_browser/adapt_browser_view_widget.h
-    src/gui_impl/signal_browser/adapt_browser_view_widget.ui
-    src/gui_impl/signal_browser/event_context_menu.cpp
-    src/gui_impl/signal_browser/event_context_menu.h
-    src/gui_impl/signal_browser/event_creation_widget.cpp
-    src/gui_impl/signal_browser/event_creation_widget.h
-    src/gui_impl/signal_browser/event_creation_widget.ui
-    src/gui_impl/signal_browser/event_editing_widget.cpp
-    src/gui_impl/signal_browser/event_editing_widget.h
-    src/gui_impl/signal_browser/event_editing_widget.ui
-    src/gui_impl/signal_browser/event_graphics_item.cpp
-    src/gui_impl/signal_browser/event_graphics_item.h
-    src/gui_impl/signal_browser/label_widget.cpp
-    src/gui_impl/signal_browser/label_widget.h
-    src/gui_impl/signal_browser/signal_browser_graphics_view.h
-    src/gui_impl/signal_browser/signal_browser_model_4.cpp
-    src/gui_impl/signal_browser/signal_browser_model_4.h
-    src/gui_impl/signal_browser/signal_browser_view.cpp
-    src/gui_impl/signal_browser/signal_browser_view.h
-    src/gui_impl/signal_browser/signal_graphics_item.cpp
-    src/gui_impl/signal_browser/signal_graphics_item.h
-    src/gui_impl/signal_browser/signal_grid_graphics_item.cpp
-    src/gui_impl/signal_browser/signal_grid_graphics_item.h
-    src/gui_impl/signal_browser/x_axis_widget_4.cpp
-    src/gui_impl/signal_browser/x_axis_widget_4.h
-    src/gui_impl/signal_browser/y_axis_widget_4.cpp
-    src/gui_impl/signal_browser/y_axis_widget_4.h
+    # gui/signal_browser
+    src/gui/signal_browser/adapt_browser_view_widget.cpp
+    src/gui/signal_browser/adapt_browser_view_widget.h
+    src/gui/signal_browser/adapt_browser_view_widget.ui
+    src/gui/signal_browser/event_context_menu.cpp
+    src/gui/signal_browser/event_context_menu.h
+    src/gui/signal_browser/event_creation_widget.cpp
+    src/gui/signal_browser/event_creation_widget.h
+    src/gui/signal_browser/event_creation_widget.ui
+    src/gui/signal_browser/event_editing_widget.cpp
+    src/gui/signal_browser/event_editing_widget.h
+    src/gui/signal_browser/event_editing_widget.ui
+    src/gui/signal_browser/event_graphics_item.cpp
+    src/gui/signal_browser/event_graphics_item.h
+    src/gui/signal_browser/label_widget.cpp
+    src/gui/signal_browser/label_widget.h
+    src/gui/signal_browser/signal_browser_graphics_view.h
+    src/gui/signal_browser/signal_browser_model_4.cpp
+    src/gui/signal_browser/signal_browser_model_4.h
+    src/gui/signal_browser/signal_browser_view.cpp
+    src/gui/signal_browser/signal_browser_view.h
+    src/gui/signal_browser/signal_graphics_item.cpp
+    src/gui/signal_browser/signal_graphics_item.h
+    src/gui/signal_browser/signal_grid_graphics_item.cpp
+    src/gui/signal_browser/signal_grid_graphics_item.h
+    src/gui/signal_browser/x_axis_widget_4.cpp
+    src/gui/signal_browser/x_axis_widget_4.h
+    src/gui/signal_browser/y_axis_widget_4.cpp
+    src/gui/signal_browser/y_axis_widget_4.h
 
     # signal_processing
     src/signal_processing/FFTReal.cpp
@@ -339,7 +335,7 @@ target_include_directories(sigviewer PRIVATE src)
 # AUTOUIC needs to know every directory that contains a .ui file.
 set_target_properties(sigviewer PROPERTIES
     AUTOUIC_SEARCH_PATHS
-        "${CMAKE_SOURCE_DIR}/src/gui_impl/dialogs;${CMAKE_SOURCE_DIR}/src/gui_impl/event_table;${CMAKE_SOURCE_DIR}/src/gui_impl/signal_browser;${CMAKE_SOURCE_DIR}/src/gui_impl/info_widgets;${CMAKE_SOURCE_DIR}/src/tests"
+        "${CMAKE_SOURCE_DIR}/src/gui/dialogs;${CMAKE_SOURCE_DIR}/src/gui/event_table;${CMAKE_SOURCE_DIR}/src/gui/signal_browser;${CMAKE_SOURCE_DIR}/src/gui/info_widgets;${CMAKE_SOURCE_DIR}/src/tests"
 )
 
 target_link_libraries(sigviewer PRIVATE