Skip to content

Commit 64b1eb5

Browse files
committed
Get everything compiling
Game tests are running but not passing. Well, on Fabric, there's some fun classpath issues on NF. Classic. - Update NF to use new transfer code. Generic peripherals don't work yet, as the capabilities aren't wired up correctly. Suspect we're gonna have to tear out that code.
1 parent ef1923d commit 64b1eb5

File tree

27 files changed

+192
-196
lines changed

27 files changed

+192
-196
lines changed

buildSrc/src/main/kotlin/cc-tweaked.fabric.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,5 +68,5 @@ tasks.ideaSyncTask {
6868
tasks.named("checkDependencyConsistency", DependencyCheck::class.java) {
6969
val libs = project.extensions.getByType<VersionCatalogsExtension>().named("libs")
7070
// Minecraft depends on asm, but Fabric forces it to a more recent version
71-
override(libs.findLibrary("asm").get(), "9.8")
71+
override(libs.findLibrary("asm").get(), "9.9")
7272
}

projects/common/src/datagen/java/dan200/computercraft/data/DataProviders.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
import net.minecraft.client.renderer.texture.atlas.SpriteSource;
2222
import net.minecraft.client.renderer.texture.atlas.SpriteSources;
2323
import net.minecraft.client.renderer.texture.atlas.sources.SingleFile;
24-
import net.minecraft.client.resources.model.AtlasIds;
2524
import net.minecraft.core.HolderLookup;
2625
import net.minecraft.core.RegistrySetBuilder;
26+
import net.minecraft.data.AtlasIds;
2727
import net.minecraft.data.DataProvider;
2828
import net.minecraft.data.PackOutput;
2929
import net.minecraft.data.registries.RegistryPatchGenerator;

projects/common/src/datagen/java/dan200/computercraft/data/LootTableProvider.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import net.minecraft.world.level.storage.loot.functions.CopyComponentsFunction;
2424
import net.minecraft.world.level.storage.loot.functions.CopyNameFunction;
2525
import net.minecraft.world.level.storage.loot.parameters.LootContextParamSets;
26+
import net.minecraft.world.level.storage.loot.parameters.LootContextParams;
2627
import net.minecraft.world.level.storage.loot.predicates.AnyOfCondition;
2728
import net.minecraft.world.level.storage.loot.predicates.ExplosionCondition;
2829
import net.minecraft.world.level.storage.loot.predicates.LootItemBlockStatePropertyCondition;
@@ -92,15 +93,15 @@ private static void selfDrop(BiConsumer<ResourceKey<LootTable>, LootTable.Builde
9293
private static void namedBlockDrop(BiConsumer<ResourceKey<LootTable>, LootTable.Builder> add, Supplier<? extends Block> wrapper) {
9394
blockDrop(
9495
add, wrapper,
95-
LootItem.lootTableItem(wrapper.get()).apply(CopyNameFunction.copyName(CopyNameFunction.NameSource.BLOCK_ENTITY)),
96+
LootItem.lootTableItem(wrapper.get()).apply(CopyNameFunction.copyName(new CopyNameFunction.Source(LootContextParams.BLOCK_ENTITY))),
9697
ExplosionCondition.survivesExplosion()
9798
);
9899
}
99100

100101
private static void computerDrop(BiConsumer<ResourceKey<LootTable>, LootTable.Builder> add, Supplier<? extends Block> block) {
101102
blockDrop(
102103
add, block,
103-
LootItem.lootTableItem(block.get()).apply(CopyComponentsFunction.copyComponents(CopyComponentsFunction.Source.BLOCK_ENTITY)),
104+
LootItem.lootTableItem(block.get()).apply(CopyComponentsFunction.copyComponentsFromBlockEntity(LootContextParams.BLOCK_ENTITY)),
104105
AnyOfCondition.anyOf(
105106
BlockNamedEntityLootCondition.BUILDER,
106107
HasComputerIdLootCondition.BUILDER,

projects/common/src/datagen/java/dan200/computercraft/data/RecipeProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ private ItemPredicate itemPredicate(TagKey<Item> item) {
447447
}
448448

449449
private static ItemStack playerHead(String name, String uuid) {
450-
return DataComponentUtil.createStack(Items.PLAYER_HEAD, DataComponents.PROFILE, new ResolvableProfile(new GameProfile(UUID.fromString(uuid), name)));
450+
return DataComponentUtil.createStack(Items.PLAYER_HEAD, DataComponents.PROFILE, ResolvableProfile.createResolved(new GameProfile(UUID.fromString(uuid), name)));
451451
}
452452

453453
private ShapedSpecBuilder customShaped(RecipeCategory category, ItemStack result) {

projects/common/src/main/java/dan200/computercraft/shared/peripheral/generic/methods/AbstractEnergyMethods.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public final String id() {
4040
* @return The energy stored in this block, in FE.
4141
*/
4242
@LuaFunction(mainThread = true)
43-
public abstract int getEnergy(T energy);
43+
public abstract long getEnergy(T energy);
4444

4545
/**
4646
* Get the maximum amount of energy this block can store.
@@ -49,5 +49,5 @@ public final String id() {
4949
* @return The energy capacity of this block.
5050
*/
5151
@LuaFunction(mainThread = true)
52-
public abstract int getEnergyCapacity(T energy);
52+
public abstract long getEnergyCapacity(T energy);
5353
}

projects/common/src/testFixtures/java/dan200/computercraft/test/shared/WithMinecraft.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public void beforeAll(ExtensionContext context) {
3131
}
3232

3333
public static void bootstrap() {
34-
SharedConstants.tryDetectVersion();
3534
ServiceLoader.load(SetupHook.class, SetupHook.class.getClassLoader()).forEach(SetupHook::run);
35+
SharedConstants.tryDetectVersion();
3636
Bootstrap.bootStrap();
3737
}
3838
}

projects/common/src/testMod/java/dan200/computercraft/mixin/gametest/GameTestServerMixin.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import net.minecraft.server.MinecraftServer;
1111
import net.minecraft.server.Services;
1212
import net.minecraft.server.WorldStem;
13-
import net.minecraft.server.level.progress.ChunkProgressListenerFactory;
13+
import net.minecraft.server.level.progress.LevelLoadListener;
1414
import net.minecraft.server.packs.repository.PackRepository;
1515
import net.minecraft.world.level.storage.LevelStorageSource;
1616
import org.spongepowered.asm.mixin.Mixin;
@@ -22,7 +22,10 @@
2222

2323
@Mixin(GameTestServer.class)
2424
abstract class GameTestServerMixin extends MinecraftServer {
25-
GameTestServerMixin(Thread serverThread, LevelStorageSource.LevelStorageAccess storageSource, PackRepository packRepository, WorldStem worldStem, Proxy proxy, DataFixer fixerUpper, Services services, ChunkProgressListenerFactory progressListenerFactory) {
25+
GameTestServerMixin(
26+
Thread serverThread, LevelStorageSource.LevelStorageAccess storageSource, PackRepository packRepository,
27+
WorldStem worldStem, Proxy proxy, DataFixer fixerUpper, Services services, LevelLoadListener progressListenerFactory
28+
) {
2629
super(serverThread, storageSource, packRepository, worldStem, proxy, fixerUpper, services, progressListenerFactory);
2730
}
2831

projects/common/src/testMod/kotlin/dan200/computercraft/gametest/Computer_Test.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import dan200.computercraft.gametest.api.*
1313
import dan200.computercraft.shared.ModRegistry
1414
import dan200.computercraft.test.core.assertArrayEquals
1515
import dan200.computercraft.test.core.computer.getApi
16+
import net.minecraft.client.input.KeyEvent
1617
import net.minecraft.core.BlockPos
1718
import net.minecraft.core.Direction
1819
import net.minecraft.gametest.framework.GameTestHelper
@@ -155,8 +156,8 @@ class Computer_Test {
155156
// Press a key on the client
156157
thenOnClient {
157158
val screen = minecraft.screen as AbstractComputerScreen<*>
158-
screen.keyPressed(GLFW.GLFW_KEY_A, 0, 0)
159-
screen.keyReleased(GLFW.GLFW_KEY_A, 0, 0)
159+
screen.keyPressed(KeyEvent(GLFW.GLFW_KEY_A, 0, 0))
160+
screen.keyReleased(KeyEvent(GLFW.GLFW_KEY_A, 0, 0))
160161
}
161162
// And assert it is handled and sent back to the client
162163
thenIdle(2)

projects/common/src/testMod/kotlin/dan200/computercraft/gametest/Disk_Drive_Test.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class Disk_Drive_Test {
122122
thenWaitUntil {
123123
val drive = helper.getBlockEntity(drivePos, DiskDriveBlockEntity::class.java)
124124
if (!drive.getItem(0).has(ModRegistry.DataComponents.DISK_ID.get())) {
125-
helper.fail("Disk has no item", drivePos)
125+
helper.abort("Disk has no item", drivePos)
126126
}
127127
}
128128
}

projects/common/src/testMod/kotlin/dan200/computercraft/gametest/Monitor_Test.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class Monitor_Test {
4545
val tile = context.getBlockEntity(pos, MonitorBlockEntity::class.java)
4646

4747
if (tile.width != 1 || tile.height != 1) {
48-
context.fail("Tile has width and height of ${tile.width}x${tile.height}, but should be 1x1", pos)
48+
context.abort("Tile has width and height of ${tile.width}x${tile.height}, but should be 1x1", pos)
4949
}
5050
}
5151
}

0 commit comments

Comments
 (0)