Questions for the new LuaTable changes

[SirEndii]

Greetings,
I am moving to CC 1.116.0 and migrate everything table related we do(mainly filters as arguments). I like that new system, it's much cleaner than just calling that helper class a ton of times, that it not utilizes Optional instead is also very helpful.

But to my question, after I adapted everything, I get an interesting error every time I am trying to access something from the IArgument of a function. Cannot use getTableUnsafe after IArguments has been closed.
I am trying to get a LuaTable instance from an IArgument, just like we did before, but with a Map.

Looking at the VarargArguments class, the instance seems to be closed, but what I don't understand is A) why is it closed and B) what exactly does that mean, why does it need to be closed
I am not enlightened enough to understand the whole lua, cobalt, arg story, but I am very interested in what exactly happens here and what the right thing is to do.

Stacktrace: https://gist.github.com/SirEndii/5b5890b093f38a356c95e63a47bb888e
Relevant snippet: https://gist.github.com/SirEndii/62059fc13e56effe2560dc7e25adef36

Also, when I am already here, I have a second question related to the sources of CC.
I am not able to attach sources into IDEA, I have the forge dependency declared inside the build.gradle, and I am unable to attach the from gradle downloaded .sources jar into IDEA. I thought maybe it also wants the core dependency, so I added that one as a compileOnly which partly works, I am able to see the source class files or every java file inside the core artifact.
But when I then try to open classes from the forge-1.116.0 package, it just fails. I tried to attach the cc-tweaked-1.21.1-forge-1.116.0-sources.jar which gradle downloaed for me and is now inside the .gradle cache folder, but that one sadly does not work. IDEA does not spit any errors, when I then try to re-open any class from that artifact, I only see the decompiled version.

Do I somehow need to trick gradle in doing everything right and automatically

[SquidDev]

Ahh, you just want to do new ObjectLuaTable(args.getTable(0));! Really getTable should return a LuaTable directly, but we can't do that without breaking API compat.

getTableUnsafe provides a LuaTable implementation that accesses the underlying table directly. This is useful for high-performance code (e.g. speaker.playAudio), as it allows us to read the table without copying the whole thing. However, it's only safe when used from the Lua thread (hence the Unsafe bit!).

Also, when I am already here, I have a second question related to the sources of CC. [...] Do I somehow need to trick gradle in doing everything right and automatically

Oh, apparently the Forge sources got entirely clobbered, sorry! I'm really not sure how this happened — forge-api is fine, as are the other common and fabric sources. Will have a look.

[SirEndii]

Alrighty, thank you for the clarification

I see, the unsafe part can be very handy for the smart glasses since nothing there runs on the main thread.

Oh, apparently the Forge sources got entirely clobbered, sorry! I'm really not sure how this happened — forge-api is fine, as are the other common and fabric sources. Will have a look.

That would be beautiful, I sometimes need to browse through some methods to debug stuff, and it's just impossible 😅
I have this issue since I ported AP to 1.21.1 but I never reported it oops

[SirEndii]

Hey @SquidDev, another question. I noticed that one can't use LuaTable as a lua function parameter directly. Is that by intention? I jused assumed that I can just replace my Map<?, ?> with a LuaTable<?, ?> but that sadly does not work.

[00:47:28] [Server thread/ERROR] [da.co.co.as.Generator/]: Unknown parameter type dan200.computercraft.api.lua.LuaTable for method de.srendi.advancedperipherals.common.addons.computercraft.peripheral.InventoryManagerPeripheral.removeItemFromPlayer.

[SquidDev]

Is that by intention?

Currently the only argument types supported by @LuaFunction are those provided by the getXyz methods. But agreed, it make sense to support LuaTable too — have added that in 00475b9.