Fix 2-PIN comparison doc to use new 2-3 card comps + SHAPs

[jeancochrane]

Now that ccao-data/model-res-avm#360 has landed, SHAPs and comps should be correct for 2-3 card parcels. The new approach for comps and SHAPs for these parcels, in brief, is to compute SHAPs and comps for the "frankencard" (the largest card in the parcel by building sq ft, whose building sq ft is then modified to be the sum of building sq ft for all cards in the parcel), then copy those SHAPs and comps over to the smaller cards in the parcel.

This new approach means that when we display SHAPs and comps for these parcels, we should only display them for the frankencard, and we should also display the summed building sq ft whenever we show characteristics for the parcel. Let's update the 2-PIN comparison report to reflect this new approach.

This is only for 2025 on; model runs prior to that do not use this multicard technique.

[Damonamajor]

@jeancochrane I'm trying to wrap my head around the if-else statements.

It seems as though any year before this year should need to specify the card if there are more than 1. Then use the comps and shaps for that card.

Because we built this to work with the Frankencard (selecting the larger of 2 /3 card pins) and requiring selection of 4 + card pins, we are already using this technique. We also sum the sq_ft characteristics for the 2/3 card PINs. So unless we added a variable representing frankencard, this method should already be implemented.

Does that sound right to you?

In that vein, does it make sense to create a frankencard indicator or some way to track it in the outputs, even if it seems pretty easy to compute?

[jeancochrane]

@Damonamajor I totally forgot we already designed this report to support the 2-3 card changes 🤦‍♀ I think the only action items here are then:

1. Swap the default run ID from 2025-02-11-charming-eric to 2025-04-25-fancy-free-billy
2. QC: Run a test for each type of parcel (single-card, small (2-3 card) multi-card, large (>3 card) multicard) and make sure the report pulls comps and SHAPs as expected

[Damonamajor]

Do we want to add a stop for 2/3 card properties before this year?

[jeancochrane]

Yeah, I think you're right that we should enforce card numbers for 2-3 card parcels prior to 2025.