Merge pull request #5540 from ccnmtl/eslint

Upgrade eslint

Author: nikolas

eslint.config.mjs

@@ -0,0 +1,97 @@
+import react from "eslint-plugin-react";
+import security from "eslint-plugin-security";
+import globals from "globals";
+import babelParser from "@babel/eslint-parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [...compat.extends(
+    "eslint:recommended",
+    "plugin:cypress/recommended",
+    "plugin:react/recommended",
+),
+security.configs.recommended,
+{
+    plugins: {
+        react,
+        security,
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.browser,
+            ...globals.node,
+            ...globals.jquery,
+            Backbone: true,
+            _: true,
+        },
+
+        parser: babelParser,
+        ecmaVersion: 6,
+        sourceType: "module",
+
+        parserOptions: {
+            ecmaFeatures: {
+                jsx: true,
+            },
+        },
+    },
+
+    settings: {
+        react: {
+            version: "detect",
+        },
+    },
+
+    rules: {
+        indent: ["error", 4],
+        "linebreak-style": ["error", "unix"],
+
+        "no-unused-vars": ["error", {
+            vars: "all",
+            args: "none",
+        }],
+
+        quotes: ["error", "single"],
+        semi: ["error", "always"],
+
+        "max-len": [2, {
+            code: 80,
+            tabWidth: 4,
+            ignoreUrls: true,
+        }],
+
+        "space-before-function-paren": ["error", "never"],
+        "space-in-parens": ["error", "never"],
+        "no-trailing-spaces": ["error"],
+
+        "key-spacing": ["error", {
+            beforeColon: false,
+        }],
+
+        "func-call-spacing": ["error", "never"],
+        "security/detect-buffer-noassert": 1,
+        "security/detect-child-process": 1,
+        "security/detect-disable-mustache-escape": 1,
+        "security/detect-eval-with-expression": 1,
+        "security/detect-new-buffer": 1,
+        "security/detect-no-csrf-before-method-override": 1,
+        "security/detect-non-literal-fs-filename": 1,
+        "security/detect-non-literal-regexp": 1,
+        "security/detect-non-literal-require": 0,
+        "security/detect-object-injection": 0,
+        "security/detect-possible-timing-attacks": 1,
+        "security/detect-pseudoRandomBytes": 1,
+        "security/detect-unsafe-regex": 1,
+    },
+}];

media/js/app/assetmgr/asset.js

@@ -1269,7 +1269,6 @@
             } else if (template_label === 'asset-annotation-current') {
                 self.$parent.find('#annotation-current').html(rendered);
             } else {
-                // eslint-disable-next-line no-console
                 console.error('Didn\'t attach template for:', template_label);
             }
 

media/js/app/assetmgr/collection.js

@@ -501,14 +501,12 @@ CollectionList.prototype.createAssetThumbs = function(assets) {
             asset.y = 0;
             asset.zoom = 1;
 
-            /* eslint-disable no-empty */
             try {
                 view.html.push(objDiv, {asset: asset});
                 view.setState(asset);
             } catch (e) {
                 console.error(e);
             }
-            /* eslint-enable no-empty */
         }
     }
 };
@@ -545,7 +543,6 @@ CollectionList.prototype.createThumbs = function(assets) {
                     if (t.length > 0) {
                         t[0].appendChild(objDiv);
                     } else {
-                        // eslint-disable-next-line no-console
                         console.error('CollectionList error!');
                     }
 

media/js/app/assetmgr/collectionwidget.js

@@ -43,7 +43,6 @@ var CollectionWidget = function() {
         self.vocabulary = vocabularyReq[0].objects;
         self.postInitialize();
     }).fail(function() {
-        // eslint-disable-next-line no-console
         console.error('Loading error in CollectionWidget constructor');
     });
 };
@@ -421,7 +420,6 @@ CollectionWidget.prototype.createThumbs = function(assets) {
                 if (t.length > 0) {
                     t[0].appendChild(objDiv);
                 } else {
-                    // eslint-disable-next-line no-console
                     console.error('CollectionWidget error!');
                 }
 

media/js/app/discussion/discussionpanel.js

@@ -147,7 +147,7 @@ DiscussionPanelHandler.prototype.set_comment_content = function(content) {
         if (self.tinymce) {
             self.tinymce.setContent(content.comment);
         }
-    } catch (e) {
+    } catch {
         /*
          * IE totally SUX: throws some object error here. probably tinymce's
          * fault

media/js/app/taxonomy/taxonomy.js

@@ -590,7 +590,7 @@
                         pL = data[skos_uri][
                             'http:\/\/onomy.org\/onomy-ns#parentLabel']
                             .value.trim();
-                    } catch (e) {
+                    } catch {
                         pL = undefined;
                     }
                 }
@@ -611,7 +611,7 @@
                             var re = 'http:\/\/www.w3.org\/2004' +
                                 '\/02\/skos\/core#broader';
                             parent_uri = data[skos_uri][re].value.trim();
-                        } catch (e) {
+                        } catch {
                             parent_uri = '';
                         }
 

media/js/app/util.js

@@ -78,7 +78,6 @@ function switcher(event, a) {
     return false;
 }
 
-// eslint-disable-next-line no-unused-vars
 function updateUserSetting(user, setting, value) {
     jQuery.post('/setting/' + user + '/', {name: setting, value: value});
 }
@@ -123,7 +122,6 @@ function toggleHelpOverlay(btn, user, helpContentId) {
     return false;
 }
 
-// eslint-disable-next-line no-unused-vars
 function getCookie(name) {
     var dc = document.cookie;
     var prefix = name + '=';
@@ -143,7 +141,6 @@ function getCookie(name) {
     return unescape(dc.substring(begin + prefix.length, end));
 }
 
-// eslint-disable-next-line no-unused-vars
 function setCookie(name, value, expires, path, domain, secure) {
     document.cookie = name + '=' + escape(value) +
         ((expires) ? '; expires=' + expires.toGMTString() : '') +