Skip to content

Commit 86c646f

Browse files
committed
Addressed review comments
1 parent e15edd7 commit 86c646f

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

src/main/java/io/cdap/e2e/pages/actions/CdfNameSpaceAdminActions.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -102,23 +102,23 @@ public static void selectHamburgerMenuList(String listName) {
102102
* keyValuePair as key
103103
*/
104104
public static void enterKeyValuePreferences(String preferenceProperty, String keyValuePair) {
105-
String pluginPropertyDataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
105+
String dataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
106106
preferenceProperty);
107-
if (pluginPropertyDataCyAttribute == null) {
108-
pluginPropertyDataCyAttribute = preferenceProperty;
107+
if (dataCyAttribute == null) {
108+
dataCyAttribute = preferenceProperty;
109109
}
110110
Map<String, String> properties =
111111
JsonUtils.convertKeyValueJsonArrayToMap(PluginPropertyUtils.pluginProp(keyValuePair));
112112
int index = 0;
113113
for (Map.Entry<String, String> entry : properties.entrySet()) {
114114
if (index != 0) {
115115
ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.locateAddRowButtonProperty(
116-
pluginPropertyDataCyAttribute, index - 1));
116+
dataCyAttribute, index - 1));
117117
}
118118
ElementHelper.sendKeys(CdfNameSpaceAdminLocators.locateKeyProperty(
119-
pluginPropertyDataCyAttribute, index), entry.getKey());
119+
dataCyAttribute, index), entry.getKey());
120120
ElementHelper.sendKeys(CdfNameSpaceAdminLocators.locateValueProperty(
121-
pluginPropertyDataCyAttribute, index), entry.getValue());
121+
dataCyAttribute, index), entry.getValue());
122122
index++;
123123
}
124124
}
@@ -131,13 +131,13 @@ public static void enterKeyValuePreferences(String preferenceProperty, String ke
131131
* fetched from it else Provisioner is used as it is.
132132
*/
133133
public static void selectProvisioner(String provisionerName) {
134-
String pluginPropertyDataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
134+
String dataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
135135
provisionerName);
136-
if (pluginPropertyDataCyAttribute == null) {
137-
pluginPropertyDataCyAttribute = provisionerName;
136+
if (dataCyAttribute == null) {
137+
dataCyAttribute = provisionerName;
138138
}
139139
ElementHelper.clickOnElement(
140-
CdfNameSpaceAdminLocators.locateProvisionerInList(pluginPropertyDataCyAttribute));
140+
CdfNameSpaceAdminLocators.locateProvisionerInList(dataCyAttribute));
141141
}
142142

143143
/**
@@ -180,13 +180,13 @@ public static void verifyIfResetValidatedSuccessfully() {
180180
* fetched from it else type of action is used as it is.
181181
*/
182182
public static void clickCreateButtonComputeProfile(String buttonType) {
183-
String pluginPropertyDataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
183+
String dataCyAttribute = PluginPropertyUtils.getPluginPropertyDataCyAttribute(
184184
buttonType);
185-
if (pluginPropertyDataCyAttribute == null) {
186-
pluginPropertyDataCyAttribute = buttonType;
185+
if (dataCyAttribute == null) {
186+
dataCyAttribute = buttonType;
187187
}
188188
ElementHelper.clickOnElement(
189-
CdfNameSpaceAdminLocators.locateButtonType(pluginPropertyDataCyAttribute));
189+
CdfNameSpaceAdminLocators.locateButtonType(dataCyAttribute));
190190
}
191191

192192
/**

0 commit comments

Comments
 (0)