Optimize generated CRD size

Author: vsethi09

Makefile

@@ -57,7 +57,7 @@ vet: ## Run go vet against code.
 
 .PHONY: test
 test: manifests generate fmt vet envtest ## Run tests.
-	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" ETCD_MAX_REQUEST_BYTES=2500000 go test ./... -coverprofile cover.out
+	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test ./... -coverprofile cover.out
 
 ##@ Build
 
@@ -110,7 +110,6 @@ $(LOCALBIN):
 KUSTOMIZE ?= $(LOCALBIN)/kustomize
 CONTROLLER_GEN ?= $(LOCALBIN)/controller-gen
 ENVTEST ?= $(LOCALBIN)/setup-envtest
-ETCD_MAX_REQUEST_BYTES=2500000
 
 ## Tool Versions
 KUSTOMIZE_VERSION ?= v3.8.7

api/v1alpha1/cdapmaster_types.go

@@ -128,6 +128,14 @@ type CDAPMasterSpec struct {
 	// Mutations can include adding init containers, tolerations and node selectors to pods. To use mutations,
 	// the admission control webhook should be enabled in the cdap operator.
 	MutationConfigs []MutationConfig `json:"mutationConfigs,omitempty"`
+	// StartupProbe is specification for the startup probe for CDAP system services.
+	// This is an optional field which ensures that the application is fully initialized
+	// before it starts receiving traffic.
+	// To disable the startup probe: either omit or set the field to nil.
+	// To enable the startup probe: set it to a pointer to a SystemMetricsExporterSpec
+	// struct (can be an empty struct). CDAPServiceSpec.EnableStartupProbe field also needs
+	// to be set to true for the deployment services which require startup probe to be enabled.
+	StartupProbe *StartupProbeSpec `json:"startupProbe,omitempty"`
 }
 
 // CDAPServiceSpec defines the base set of specifications applicable to all master services.
@@ -176,9 +184,9 @@ type CDAPServiceSpec struct {
 	Lifecycle *corev1.Lifecycle `json:"lifecycle,omitempty"`
 	// Affinity describes node affinity scheduling rules for the service.
 	Affinity *corev1.Affinity `json:"affinity,omitempty"`
-	// StartupProbe describes the startupProbe to indicates that the Pod has
-	// successfully initialized.
-	StartupProbe *corev1.Probe `json:"startupProbe,omitempty"`
+	// EnableStartupProbe is an optional field to indicate if StatusProbe should
+	// be enabled for the container.
+	EnableStartupProbe *bool `json:"enableStartupProbe,omitempty"`
 }
 
 // CDAPScalableServiceSpec defines the base specification for master services that can have more than one instance.
@@ -298,6 +306,24 @@ type SystemMetricExporterSpec struct {
 	CDAPServiceSpec `json:",inline"`
 }
 
+type StartupProbeSpec struct {
+	// For Probe config see:
+	// https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes.
+
+	// Number of seconds after the container has started before probes are initiated.
+	// Defaults to 0 seconds. Minimum value is 0.
+	InitialDelaySeconds *int32 `json:"initialDelaySeconds,omitempty"`
+	// How often (in seconds) to perform the probe.
+	// Default to 10 seconds. The minimum value is 1.
+	PeriodSeconds *int32 `json:"periodSeconds,omitempty"`
+	// Number of seconds after which the probe times out.
+	// Defaults to 1 second. Minimum value is 1.
+	TimeoutSeconds *int32 `json:"timeoutSeconds,omitempty"`
+	// Number of consecutive failures before considering the service not ready.
+	// Defaults to 3. Minimum value is 1.
+	FailureThreshold *int32 `json:"failureThreshold,omitempty"`
+}
+
 // CDAPMasterStatus defines the observed state of CDAPMaster
 type CDAPMasterStatus struct {
 	status.Meta          `json:",inline"`