Skip to content

Commit d32626e

Browse files
committed
account for null reference names in validation
1 parent fa251ed commit d32626e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

format-common/src/main/java/io/cdap/plugin/format/plugin/AbstractFileSinkConfig.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,9 @@ public void validate(FailureCollector collector) {
8585
}
8686

8787
public void validate(FailureCollector collector, Map<String, String> arguments) {
88-
IdUtils.validateReferenceName(referenceName, collector);
88+
if (!Strings.isNullOrEmpty(referenceName)) {
89+
IdUtils.validateReferenceName(referenceName, collector);
90+
}
8991
if (suffix != null && !containsMacro(NAME_SUFFIX)) {
9092
try {
9193
new SimpleDateFormat(suffix);

format-common/src/main/java/io/cdap/plugin/format/plugin/AbstractFileSourceConfig.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ public void validate() {
141141
}
142142

143143
public void validate(FailureCollector collector) {
144-
IdUtils.validateReferenceName(referenceName, collector);
144+
if (!Strings.isNullOrEmpty(referenceName)) {
145+
IdUtils.validateReferenceName(referenceName, collector);
146+
}
145147
try {
146148
getSchema();
147149
} catch (IllegalArgumentException e) {

0 commit comments

Comments
 (0)