handle error case for refUpdated event translation

Signed-off-by: Jalander Ramagiri <[email protected]>

Author: Jalander Ramagiri

pkg/gerrit/event_test.go

@@ -1,40 +1,40 @@
-package gerrit
-
-import (
-	"net/http"
-	"os"
-	"testing"
-)
-
-func TestHandleTranslateProjectCreatedEvent(t *testing.T) {
-	event, err := os.ReadFile("testdata/project-created.json")
-	if err != nil {
-		t.Fatalf("Failed to read project-created.json file: %v", err)
-	}
-	headers := http.Header{}
-	headers.Set("X-Origin-Url", "http://gerrit.est.tech")
-
-	cdEvent, err := HandleTranslateGerritEvent(string(event), headers)
-	if err != nil {
-		t.Errorf("Expected RepositoryCreated CDEvent to be successful.")
-		return
-	}
-	Log().Info("Handle project-created gerrit event into dev.cdevents.repository.created is successful ", cdEvent)
-}
-
-func TestHandleTranslateProjectHeadUpdatedEvent(t *testing.T) {
-
-	event, err := os.ReadFile("testdata/project-head-updated.json")
-	if err != nil {
-		t.Fatalf("Failed to read project-head-updated.json file: %v", err)
-	}
-	headers := http.Header{}
-	headers.Set("X-Origin-Url", "http://gerrit.est.tech")
-
-	cdEvent, err := HandleTranslateGerritEvent(string(event), headers)
-	if err != nil {
-		t.Errorf("Expected RepositoryModified CDEvent to be successful.")
-		return
-	}
-	Log().Info("Handle project-head-updated gerrit event into dev.cdevents.repository.modified is successful ", cdEvent)
-}
+package gerrit
+
+import (
+	"net/http"
+	"os"
+	"testing"
+)
+
+func TestHandleTranslateProjectCreatedEvent(t *testing.T) {
+	event, err := os.ReadFile("testdata/project-created.json")
+	if err != nil {
+		t.Fatalf("Failed to read project-created.json file: %v", err)
+	}
+	headers := http.Header{}
+	headers.Set("X-Origin-Url", "http://gerrit.est.tech")
+
+	cdEvent, err := HandleTranslateGerritEvent(string(event), headers)
+	if err != nil {
+		t.Errorf("Expected RepositoryCreated CDEvent to be successful.")
+		return
+	}
+	Log().Info("Handle project-created gerrit event into dev.cdevents.repository.created is successful ", cdEvent)
+}
+
+func TestHandleTranslateProjectHeadUpdatedEvent(t *testing.T) {
+
+	event, err := os.ReadFile("testdata/project-head-updated.json")
+	if err != nil {
+		t.Fatalf("Failed to read project-head-updated.json file: %v", err)
+	}
+	headers := http.Header{}
+	headers.Set("X-Origin-Url", "http://gerrit.est.tech")
+
+	cdEvent, err := HandleTranslateGerritEvent(string(event), headers)
+	if err != nil {
+		t.Errorf("Expected RepositoryModified CDEvent to be successful.")
+		return
+	}
+	Log().Info("Handle project-head-updated gerrit event into dev.cdevents.repository.modified is successful ", cdEvent)
+}

pkg/gerrit/translate_events.go

@@ -82,6 +82,9 @@ func (pEvent *GerritEvent) HandleRefUpdatedEvent() (string, error) {
 			return "", err
 		}
 		Log().Info("Translated ref-updated gerrit event into dev.cdevents.branch.deleted CDEvent: ", cdEvent)
+	} else {
+		Log().Info("Ignoring handling ref-updated gerrit event for refName : ", refUpdated.RefUpdate.RefName)
+		return "", errors.New("ignoring translating ref-updated gerrit event")
 	}
 
 	return cdEvent, nil