Add PGS to SRT OCR subtitle extraction

Implement OCR conversion for PGS (Presentation Graphic Stream) subtitles
to SRT format using pgsrip library with auto-detection of required tools.

Features:
- Auto-detect Tesseract OCR from PATH or Subtitle Edit installations
- Auto-detect MKVToolNix (mkvextract/mkvmerge) from standard locations
- Support for multiple language codes (2-letter, 3-letter, names)
- Automatic cleanup of temporary .sup files after conversion
- Works when running FastFlix from source

Known limitation:
Due to an upstream issue in pgsrip v0.1.12, this feature does not work
in PyInstaller-built executables. Users needing PGS OCR should run
FastFlix from source with: python -m fastflix

Dependencies added:
- pgsrip (OCR engine for PGS subtitles)
- pytesseract (Tesseract OCR Python wrapper)
- babelfish (language code handling)
- cleanit, trakit (metadata handling)
- opencv-python, pysrt (image/subtitle processing)

Author: mikeSGman

README.md

@@ -94,11 +94,9 @@ FastFlix can extract subtitles from video files in various formats (SRT, ASS, SS
 ## PGS to SRT OCR
 
 **Requirements**:
-- Tesseract OCR 4.x or higher
-- MKVToolNix (mkvextract, mkvmerge)
-- pgsrip Python library
-
-**Known Limitation**: PGS OCR only works when running FastFlix from source (`python -m fastflix`), not in PyInstaller-built executables due to a bug in pgsrip v0.1.12. See [WINDOWS_BUILD.md](WINDOWS_BUILD.md#pgs-to-srt-ocr-conversion-pyinstaller-builds) for details.
+- Tesseract OCR 4.x or higher (auto-detected from PATH or Subtitle Edit installations)
+- MKVToolNix (mkvextract, mkvmerge) (auto-detected from standard install locations)
+- pgsrip Python library (included in FastFlix)
 
 # HDR
 

WINDOWS_BUILD.md

@@ -120,20 +120,11 @@ The FastFlix executable doesn't include FFmpeg. You need to:
 
 ## Known Limitations
 
-### PGS to SRT OCR Conversion (PyInstaller builds)
+### PGS to SRT OCR (PyInstaller builds)
 
-The PGS to SRT OCR feature works perfectly when running FastFlix from source (`python -m fastflix`), but has a known issue in PyInstaller-built executables:
+Due to an upstream issue in pgsrip v0.1.12, PGS to SRT OCR conversion does not work in PyInstaller-built executables. The feature works perfectly when running from source (`python -m fastflix`).
 
-**Issue**: The pgsrip library (v0.1.12) has a bug where `MediaPath.create_temp_folder()` doesn't work correctly in frozen PyInstaller executables. This causes mkvextract to fail with exit code 2.
-
-**Workaround**: If you need PGS OCR functionality, run FastFlix from source instead of using the compiled executable.
-
-**Requirements** (when running from source):
-- Tesseract OCR 4.x or higher (auto-detected from PATH or Subtitle Edit installations)
-- MKVToolNix (mkvextract, mkvmerge) (auto-detected from PATH or standard install locations)
-- pgsrip Python library (installed via pip)
-
-This is a known upstream bug in pgsrip when used with PyInstaller and cannot be fixed without patching the pgsrip library itself.
+If you need PGS OCR functionality, please run FastFlix from source instead of using the compiled executable.
 
 ## Notes
 

fastflix/__main__.py

@@ -8,61 +8,14 @@
 from fastflix.entry import main
 
 
-def patch_pgsrip_for_pyinstaller():
-    """Monkey-patch pgsrip to fix temp folder creation in PyInstaller.
-
-    pgsrip's MediaPath.create_temp_folder() doesn't work correctly in frozen
-    PyInstaller executables, so we patch MkvPgs.read_data to handle it.
-    """
-    try:
-        import tempfile
-        from subprocess import check_output
-
-        # Import pgsrip.mkv module to patch it
-        from pgsrip import mkv as pgsrip_mkv
-
-        @classmethod
-        def patched_read_data(cls, media_path, track_id, temp_folder):
-            """Patched version that ensures temp_folder exists as a directory"""
-            # Check if temp_folder exists as a directory
-            temp_folder_path = Path(temp_folder)
-            if not temp_folder_path.exists() or not temp_folder_path.is_dir():
-                # Create our own temp folder if pgsrip's creation failed
-                temp_folder = tempfile.mkdtemp(prefix=f"{Path(str(media_path)).stem}_", suffix=".pgsrip")
-
-            lang_ext = f".{str(media_path.language)}" if media_path.language else ""
-            sup_file = os.path.join(temp_folder, f"{track_id}{lang_ext}.sup")
-            cmd = ["mkvextract", str(media_path), "tracks", f"{track_id}:{sup_file}"]
-            check_output(cmd)
-            with open(sup_file, mode="rb") as f:
-                return f.read()
-
-        # Apply the monkey-patch
-        pgsrip_mkv.MkvPgs.read_data = patched_read_data
-        print("DEBUG: pgsrip monkey-patch applied successfully")
-    except ImportError as e:
-        # pgsrip not installed, skip patching
-        print(f"DEBUG: pgsrip monkey-patch skipped - ImportError: {e}")
-    except Exception as e:
-        # Other error during patching
-        print(f"DEBUG: pgsrip monkey-patch failed - {type(e).__name__}: {e}")
-
-
 def setup_ocr_environment():
     """Set up environment variables for OCR tools early in app startup.
 
     This is necessary for PyInstaller frozen executables where os.environ
     modifications later in the code don't properly propagate to subprocesses.
     """
-    import tempfile
     from fastflix.models.config import find_ocr_tool
 
-    # Ensure TEMP/TMP point to standard locations for PyInstaller compatibility
-    # pgsrip creates temp folders and needs writable temp directory
-    temp_dir = tempfile.gettempdir()
-    os.environ["TEMP"] = temp_dir
-    os.environ["TMP"] = temp_dir
-
     # Find tesseract and add to PATH
     tesseract_path = find_ocr_tool("tesseract")
     if tesseract_path:
@@ -76,9 +29,6 @@ def setup_ocr_environment():
         mkvtoolnix_dir = str(Path(mkvmerge_path).parent)
         os.environ["PATH"] = f"{mkvtoolnix_dir}{os.pathsep}{os.environ.get('PATH', '')}"
 
-    # Patch pgsrip AFTER environment is set up
-    patch_pgsrip_for_pyinstaller()
-
 
 def start_fastflix():
     exit_code = 2

fastflix/widgets/background_tasks.py

@@ -233,13 +233,11 @@ def _convert_sup_to_srt(self, sup_filepath: str) -> bool:
 
             # Set environment variables for pgsrip to find tesseract and mkvextract
             if self.app.fastflix.config.tesseract_path:
-                # Add tesseract directory to PATH so pytesseract can find it
                 tesseract_dir = str(Path(self.app.fastflix.config.tesseract_path).parent)
                 os.environ["PATH"] = f"{tesseract_dir}{os.pathsep}{os.environ.get('PATH', '')}"
                 os.environ["TESSERACT_CMD"] = str(self.app.fastflix.config.tesseract_path)
 
             if self.app.fastflix.config.mkvmerge_path:
-                # Add MKVToolNix directory to PATH so pgsrip can find mkvextract
                 mkvtoolnix_dir = str(Path(self.app.fastflix.config.mkvmerge_path).parent)
                 os.environ["PATH"] = f"{mkvtoolnix_dir}{os.pathsep}{os.environ.get('PATH', '')}"
 
@@ -278,8 +276,6 @@ def _convert_sup_to_srt(self, sup_filepath: str) -> bool:
             pgsrip.rip(media, options)
 
             # Find newly created .srt files
-            # Note: Can't use glob with video filename directly because special chars like []
-            # are interpreted as glob patterns. Instead, find new .srt files.
             current_srts = set(video_path.parent.glob("*.srt"))
             new_srts = current_srts - existing_srts