Adding automatic downloads for rigaya encoders on Windows

cdgriffith · cdgriffith · commit 34bb96bf990f · 2025-05-03T14:53:13.000-05:00
diff --git a/CHANGES b/CHANGES
@@ -1,7 +1,8 @@
 # Changelog
 
-## Version 5.11.1
+## Version 5.12.0
 
+* Adding automatic downloads for rigaya encoders on Windows
 * Fixing custom_crf not being found (thanks to Norbert)
 
 ## Version 5.11.0
diff --git a/fastflix/application.py b/fastflix/application.py
@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 import logging
+import platform
 import sys
 
 import coloredlogs
@@ -13,9 +14,10 @@
 from fastflix.models.fastflix_app import FastFlixApp
 from fastflix.program_downloads import ask_for_ffmpeg, grab_stable_ffmpeg
 from fastflix.resources import main_icon, breeze_styles_path
-from fastflix.shared import file_date, message, latest_fastflix, DEVMODE
+from fastflix.shared import file_date, message, latest_fastflix, DEVMODE, yes_no_message
 from fastflix.widgets.container import Container
 from fastflix.widgets.progress_bar import ProgressBar, Task
+from fastflix.gpu_detect import automatic_rigaya_download
 
 logger = logging.getLogger("fastflix")
 
@@ -169,6 +171,7 @@ def app_setup(
     app.fastflix.config = Config()
     init_fastflix_directories(app)
     init_logging(app)
+    logger.debug(f"GUI logging initialized, saving to {app.fastflix.log_path}")
     upgraded = app.fastflix.config.upgrade_check()
     if upgraded:
         # No translation will be possible in this case
@@ -215,6 +218,19 @@ def app_setup(
 
     logger.setLevel(app.fastflix.config.logging_level)
 
+    if platform.system() == "Windows":
+        if app.fastflix.config.auto_gpu_check is None:
+            app.fastflix.config.auto_gpu_check = yes_no_message(
+                "Do you want FastFlix to automatically detect your GPUs and download the optional encoders for them?\n\nThis will include downloading 7zip on Windows platform.",
+                title="Allow Optional Downloads",
+            )
+        if app.fastflix.config.auto_gpu_check:
+            ProgressBar(
+                app, [Task(name=t("Detect GPUs"), command=automatic_rigaya_download)], signal_task=True, can_cancel=True
+            )
+
+    app.fastflix.config.save()
+
     startup_tasks = [
         Task(t("Gather FFmpeg version"), ffmpeg_configuration),
         Task(t("Gather FFprobe version"), ffprobe_configuration),
@@ -246,7 +262,6 @@ def start_app(worker_queue, status_queue, log_queue, queue_list, queue_lock, por
     # import tracemalloc
     #
     # tracemalloc.start()
-
     app = app_setup(
         enable_scaling=enable_scaling,
         portable_mode=portable_mode,
diff --git a/fastflix/encoders/nvencc_av1/settings_panel.py b/fastflix/encoders/nvencc_av1/settings_panel.py
@@ -141,13 +141,9 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 11, 0, 1, 4)
-        grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)
 
         self.setLayout(grid)
         self.hide()
diff --git a/fastflix/encoders/nvencc_avc/settings_panel.py b/fastflix/encoders/nvencc_avc/settings_panel.py
@@ -137,9 +137,6 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 11, 0, 1, 4)
diff --git a/fastflix/encoders/nvencc_hevc/settings_panel.py b/fastflix/encoders/nvencc_hevc/settings_panel.py
@@ -141,9 +141,6 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 11, 0, 1, 4)
diff --git a/fastflix/encoders/qsvencc_av1/settings_panel.py b/fastflix/encoders/qsvencc_av1/settings_panel.py
@@ -146,14 +146,9 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 11, 0, 1, 4)
-        grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)
-
         self.setLayout(grid)
         self.hide()
         self.hdr10plus_signal.connect(self.done_hdr10plus_extract)
diff --git a/fastflix/encoders/qsvencc_avc/settings_panel.py b/fastflix/encoders/qsvencc_avc/settings_panel.py
@@ -136,14 +136,9 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 11, 0, 1, 4)
-        grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)
-        grid.addWidget(QtWidgets.QLabel(t("QSVEncC Encoder support is still experimental!")), 11, 5, 1, 1)
 
         self.setLayout(grid)
         self.hide()
diff --git a/fastflix/encoders/qsvencc_hevc/settings_panel.py b/fastflix/encoders/qsvencc_hevc/settings_panel.py
@@ -138,14 +138,9 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 11, 0, 1, 4)
-        grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)
-        grid.addWidget(QtWidgets.QLabel(t("QSVEncC Encoder support is still experimental!")), 11, 5, 1, 1)
 
         self.setLayout(grid)
         self.hide()
diff --git a/fastflix/encoders/vceencc_av1/settings_panel.py b/fastflix/encoders/vceencc_av1/settings_panel.py
@@ -128,13 +128,9 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 12, 0, 1, 4)
-        grid.addWidget(warning_label, 12, 4, 1, 1, alignment=QtCore.Qt.AlignRight)
 
         self.setLayout(grid)
         self.hide()
diff --git a/fastflix/encoders/vceencc_avc/settings_panel.py b/fastflix/encoders/vceencc_avc/settings_panel.py
@@ -123,9 +123,6 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 12, 0, 1, 4)
diff --git a/fastflix/encoders/vceencc_hevc/settings_panel.py b/fastflix/encoders/vceencc_hevc/settings_panel.py
@@ -126,9 +126,6 @@ def __init__(self, parent, main, app: FastFlixApp):
             )
         )
 
-        warning_label = QtWidgets.QLabel()
-        warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))
-
         guide_label.setAlignment(QtCore.Qt.AlignBottom)
         guide_label.setOpenExternalLinks(True)
         grid.addWidget(guide_label, 12, 0, 1, 4)
diff --git a/fastflix/entry.py b/fastflix/entry.py
@@ -157,6 +157,7 @@ def main(portable_mode=False):
         exit_status = 1
 
         try:
+            logger.info("Preparing separate process for GUI - this may take a moment")
             gui_proc = Process(
                 target=separate_app_process,
                 args=(worker_queue, status_queue, log_queue, queue_list, queue_lock, portable_mode),
diff --git a/fastflix/flix.py b/fastflix/flix.py
@@ -478,8 +478,12 @@ def ffmpeg_audio_encoders(app, config: Config) -> List:
 
 
 def ffmpeg_opencl_support(app, config: Config) -> bool:
+    if app.fastflix.config.opencl_support is not None:
+        app.fastflix.opencl_support = app.fastflix.config.opencl_support
+        return app.fastflix.opencl_support
     cmd = execute([f"{config.ffmpeg}", "-hide_banner", "-log_level", "error", "-init_hw_device", "opencl:0.0", "-h"])
     app.fastflix.opencl_support = cmd.returncode == 0
+    app.fastflix.config.opencl_support = app.fastflix.opencl_support
     return app.fastflix.opencl_support
 
 
diff --git a/fastflix/gpu_detect.py b/fastflix/gpu_detect.py
@@ -0,0 +1,132 @@
+# -*- coding: utf-8 -*-
+from dataclasses import dataclass
+import logging
+
+
+from fastflix.program_downloads import find_seven_zip_windows, download_rigaya, download_7zip
+
+import platform
+
+system = platform.system()
+logger = logging.getLogger("fastflix")
+
+
+@dataclass
+class DetectGPU:
+    NVIDIA: bool = False
+    AMD: bool = False
+    INTEL: bool = False
+    fingerprint: str = None
+
+    def exist(self):
+        return self.NVIDIA or self.AMD or self.INTEL
+
+    def __str__(self):
+        output = "GPU types detected: "
+        if self.NVIDIA:
+            output += " NVIDIA "
+        if self.AMD:
+            output += " AMD "
+        if self.INTEL:
+            output += " INTEL "
+        return output
+
+
+def windows_gpu_detect():
+    import wmi
+
+    computer = wmi.WMI()
+    gpu_info = computer.Win32_VideoController()
+    detected_gpus = DetectGPU()
+    fingerprinter = set()
+    for adapter in gpu_info:
+        adapter_type = adapter.AdapterCompatibility.split()[0].upper()
+        if adapter_type == "NVIDIA":
+            detected_gpus.NVIDIA = True
+            fingerprinter.add(adapter.VideoProcessor)
+        elif adapter_type == "AMD":
+            detected_gpus.AMD = True
+            fingerprinter.add(adapter.VideoProcessor)
+        elif adapter_type == "INTEL":
+            detected_gpus.INTEL = True
+            fingerprinter.add(adapter.VideoProcessor)
+    detected_gpus.fingerprint = "~~".join(sorted(list(fingerprinter)))
+    return detected_gpus
+
+
+def gpu_detect():
+    if system == "Linux":
+        return linux_gpu_detect()
+    elif system == "Windows":
+        return windows_gpu_detect()
+    else:
+        print("Unsupported OS")
+        return DetectGPU()
+
+
+def automatic_rigaya_download(config, app, signal, stop_signal):
+    if config.gpu_fingerprint:
+        logger.debug(f"GPU fingerprint already set: {config.gpu_fingerprint}")
+        return
+    signal.emit(0)
+    gpus = gpu_detect()
+    logger.info(f"Detected GPUs: {gpus}")
+    if not gpus.exist():
+        return
+    config.gpu_fingerprint = gpus.fingerprint
+
+    signal.emit(25)
+
+    if not config.seven_zip or not config.seven_zip.exists():
+        config.seven_zip = find_seven_zip_windows()
+        if not config.seven_zip:
+            config.seven_zip = download_7zip(stop_signal)
+
+    signal.emit(50)
+
+    if gpus.NVIDIA and not config.nvencc:
+        logger.info("Going to download NVEncC")
+        config.nvencc = download_rigaya(stop_signal, seven_zip_path=config.seven_zip, app_name="NVEnc")
+
+    signal.emit(70)
+    if gpus.AMD and not config.vceencc:
+        logger.info("Going to download VCEncC")
+        config.vceencc = download_rigaya(stop_signal, seven_zip_path=config.seven_zip, app_name="VCEEnc")
+
+    signal.emit(90)
+    if gpus.INTEL and not config.qsvencc:
+        logger.info("Going to download QSVEncC")
+        config.qsvencc = download_rigaya(stop_signal, seven_zip_path=config.seven_zip, app_name="QSVEnc")
+
+
+def update_rigaya_encoders(config, app, signal, stop_signal):
+    signal.emit(0)
+    gpus = gpu_detect()
+    logger.info(f"Detected GPUs: {gpus}")
+    if not gpus.exist():
+        return
+    config.gpu_fingerprint = gpus.fingerprint
+
+    signal.emit(25)
+
+    if not config.seven_zip or not config.seven_zip.exists():
+        config.seven_zip = find_seven_zip_windows()
+        if not config.seven_zip:
+            config.seven_zip = download_7zip(stop_signal)
+
+    signal.emit(50)
+
+    if gpus.NVIDIA:
+        logger.info("Going to download NVEncC")
+        config.nvencc = download_rigaya(stop_signal, seven_zip_path=config.seven_zip, app_name="NVEnc")
+
+    signal.emit(70)
+    if gpus.AMD:
+        logger.info("Going to download VCEncC")
+        config.vceencc = download_rigaya(stop_signal, seven_zip_path=config.seven_zip, app_name="VCEEnc")
+
+    signal.emit(90)
+    if gpus.INTEL:
+        logger.info("Going to download QSVEncC")
+        config.qsvencc = download_rigaya(stop_signal, seven_zip_path=config.seven_zip, app_name="QSVEnc")
+    signal.emit(100)
diff --git a/fastflix/models/config.py b/fastflix/models/config.py
@@ -131,6 +131,10 @@ class Config(BaseModel):
     portable_mode: bool = False
     ui_scale: str = "1"
     clean_old_logs: bool = True
+    auto_gpu_check: bool | None = None
+    gpu_fingerprint: str | None = None
+    opencl_support: bool | None = None
+    seven_zip: Path | None = None
     sane_audio_selection: list = Field(
         default_factory=lambda: [
             "aac",
@@ -274,7 +278,18 @@ def load(self, portable_mode=False):
                 "there may be non-recoverable errors while loading it."
             )
 
-        paths = ("work_path", "ffmpeg", "ffprobe", "hdr10plus_parser", "nvencc", "output_directory", "source_directory")
+        paths = (
+            "work_path",
+            "ffmpeg",
+            "ffprobe",
+            "hdr10plus_parser",
+            "nvencc",
+            "output_directory",
+            "source_directory",
+            "seven_zip",
+            "vceencc",
+            "qsvencc",
+        )
         for key, value in data.items():
             if key == "profiles":
                 self.profiles = {}
@@ -328,7 +343,7 @@ def load(self, portable_mode=False):
         #     self.nvencc_encoders = []
         #     self.qsvencc_encoders = []
 
-        self.check_hw_encoders()
+        # self.check_hw_encoders()
 
     def check_hw_encoders(self):
         if self.nvencc:
diff --git a/fastflix/program_downloads.py b/fastflix/program_downloads.py
diff --git a/fastflix/version.py b/fastflix/version.py
diff --git a/fastflix/widgets/about.py b/fastflix/widgets/about.py
diff --git a/fastflix/widgets/container.py b/fastflix/widgets/container.py
diff --git a/pyproject.toml b/pyproject.toml
diff --git a/tests/assets/wmi_intel_laptop.txt b/tests/assets/wmi_intel_laptop.txt
diff --git a/tests/assets/wmi_nvidia_4070_laptop.txt b/tests/assets/wmi_nvidia_4070_laptop.txt

Original file line number	Diff line number	Diff line change
`@@ -141,13 +141,9 @@ def __init__(self, parent, main, app: FastFlixApp):`
`141`	`141`	`)`
`142`	`142`	`)`
`143`	`143`
`144`		`- warning_label = QtWidgets.QLabel()`
`145`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`146`		`-`
`147`	`144`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`148`	`145`	`guide_label.setOpenExternalLinks(True)`
`149`	`146`	`grid.addWidget(guide_label, 11, 0, 1, 4)`
`150`		`- grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)`
`151`	`147`
`152`	`148`	`self.setLayout(grid)`
`153`	`149`	`self.hide()`
Original file line number	Diff line number	Diff line change
`@@ -137,9 +137,6 @@ def __init__(self, parent, main, app: FastFlixApp):`
`137`	`137`	`)`
`138`	`138`	`)`
`139`	`139`
`140`		`- warning_label = QtWidgets.QLabel()`
`141`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`142`		`-`
`143`	`140`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`144`	`141`	`guide_label.setOpenExternalLinks(True)`
`145`	`142`	`grid.addWidget(guide_label, 11, 0, 1, 4)`
Original file line number	Diff line number	Diff line change
`@@ -141,9 +141,6 @@ def __init__(self, parent, main, app: FastFlixApp):`
`141`	`141`	`)`
`142`	`142`	`)`
`143`	`143`
`144`		`- warning_label = QtWidgets.QLabel()`
`145`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`146`		`-`
`147`	`144`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`148`	`145`	`guide_label.setOpenExternalLinks(True)`
`149`	`146`	`grid.addWidget(guide_label, 11, 0, 1, 4)`
Original file line number	Diff line number	Diff line change
`@@ -146,14 +146,9 @@ def __init__(self, parent, main, app: FastFlixApp):`
`146`	`146`	`)`
`147`	`147`	`)`
`148`	`148`
`149`		`- warning_label = QtWidgets.QLabel()`
`150`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`151`		`-`
`152`	`149`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`153`	`150`	`guide_label.setOpenExternalLinks(True)`
`154`	`151`	`grid.addWidget(guide_label, 11, 0, 1, 4)`
`155`		`- grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)`
`156`		`-`
`157`	`152`	`self.setLayout(grid)`
`158`	`153`	`self.hide()`
`159`	`154`	`self.hdr10plus_signal.connect(self.done_hdr10plus_extract)`
Original file line number	Diff line number	Diff line change
`@@ -136,14 +136,9 @@ def __init__(self, parent, main, app: FastFlixApp):`
`136`	`136`	`)`
`137`	`137`	`)`
`138`	`138`
`139`		`- warning_label = QtWidgets.QLabel()`
`140`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`141`		`-`
`142`	`139`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`143`	`140`	`guide_label.setOpenExternalLinks(True)`
`144`	`141`	`grid.addWidget(guide_label, 11, 0, 1, 4)`
`145`		`- grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)`
`146`		`- grid.addWidget(QtWidgets.QLabel(t("QSVEncC Encoder support is still experimental!")), 11, 5, 1, 1)`
`147`	`142`
`148`	`143`	`self.setLayout(grid)`
`149`	`144`	`self.hide()`
Original file line number	Diff line number	Diff line change
`@@ -138,14 +138,9 @@ def __init__(self, parent, main, app: FastFlixApp):`
`138`	`138`	`)`
`139`	`139`	`)`
`140`	`140`
`141`		`- warning_label = QtWidgets.QLabel()`
`142`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`143`		`-`
`144`	`141`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`145`	`142`	`guide_label.setOpenExternalLinks(True)`
`146`	`143`	`grid.addWidget(guide_label, 11, 0, 1, 4)`
`147`		`- grid.addWidget(warning_label, 11, 4, 1, 1, alignment=QtCore.Qt.AlignRight)`
`148`		`- grid.addWidget(QtWidgets.QLabel(t("QSVEncC Encoder support is still experimental!")), 11, 5, 1, 1)`
`149`	`144`
`150`	`145`	`self.setLayout(grid)`
`151`	`146`	`self.hide()`
Original file line number	Diff line number	Diff line change
`@@ -128,13 +128,9 @@ def __init__(self, parent, main, app: FastFlixApp):`
`128`	`128`	`)`
`129`	`129`	`)`
`130`	`130`
`131`		`- warning_label = QtWidgets.QLabel()`
`132`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`133`		`-`
`134`	`131`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`135`	`132`	`guide_label.setOpenExternalLinks(True)`
`136`	`133`	`grid.addWidget(guide_label, 12, 0, 1, 4)`
`137`		`- grid.addWidget(warning_label, 12, 4, 1, 1, alignment=QtCore.Qt.AlignRight)`
`138`	`134`
`139`	`135`	`self.setLayout(grid)`
`140`	`136`	`self.hide()`
Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,6 @@ def __init__(self, parent, main, app: FastFlixApp):`
`123`	`123`	`)`
`124`	`124`	`)`
`125`	`125`
`126`		`- warning_label = QtWidgets.QLabel()`
`127`		`- warning_label.setPixmap(QtGui.QIcon(get_icon("onyx-warning", self.app.fastflix.config.theme)).pixmap(22))`
`128`		`-`
`129`	`126`	`guide_label.setAlignment(QtCore.Qt.AlignBottom)`
`130`	`127`	`guide_label.setOpenExternalLinks(True)`
`131`	`128`	`grid.addWidget(guide_label, 12, 0, 1, 4)`