Skip to content

Commit 428eb08

Browse files
committed
Add audio profile title options and fix dropdown styling
1 parent c3bf659 commit 428eb08

12 files changed

Lines changed: 352 additions & 51 deletions

File tree

CHANGES

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
# Changelog
22

3-
## Version 5.12.5
3+
## Version 5.13.0
44

5-
* Fixing window resizing beyond screen boundaries when switching profiles on macOS
5+
* Adding #712 audio profile title options: No Title, Generate Title, and Custom Title
66
* Adding async queue saving to prevent GUI blocking during queue operations
77
* Adding atomic file writes for queue to prevent corruption from interrupted saves
88
* Adding file-based locking for queue operations to prevent race conditions between instances
99
* Adding graceful shutdown handling for worker process and background threads
10+
* Fixing window resizing beyond screen boundaries when switching profiles on macOS
1011
* Fixing potential GUI freeze when log queue fills up during encoding
1112
* Fixing file handle leaks in command runner when process startup fails
1213
* Fixing crash when dragging non-video content over the main window

fastflix/data/languages.yaml

Lines changed: 105 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11272,3 +11272,108 @@ Error checking subtitle format for track:
1127211272
ukr: 'Примітка: час початку та закінчення ігнорується'
1127311273
kor: '참고: 시작 및 종료 시간은 무시됩니다.'
1127411274
ron: 'Notă: ora de început și de sfârșit vor fi ignorate'
11275+
Shutdown signal received from GUI:
11276+
eng: Shutdown signal received from GUI
11277+
deu: Von der GUI empfangenes Abschaltsignal
11278+
fra: Signal d'arrêt reçu de l'interface graphique
11279+
ita: Segnale di spegnimento ricevuto dalla GUI
11280+
spa: Señal de apagado recibida de GUI
11281+
jpn: GUIからシャットダウン信号を受信
11282+
rus: Сигнал выключения, полученный от графического интерфейса пользователя
11283+
por: Sinal de encerramento recebido da GUI
11284+
swe: Avstängningssignal mottagen från GUI
11285+
pol: Sygnał wyłączenia odebrany z GUI
11286+
chs: 从图形用户界面接收到关机信号
11287+
ukr: Отримано сигнал вимкнення від графічного інтерфейсу
11288+
kor: GUI에서 수신한 종료 신호
11289+
ron: Semnal de închidere primit de la GUI
11290+
Worker shutting down gracefully:
11291+
eng: Worker shutting down gracefully
11292+
deu: Worker wird ordnungsgemäß heruntergefahren
11293+
fra: Le travailleur s'arrête en douceur
11294+
ita: L'operaio si spegne con grazia
11295+
spa: El trabajador se apaga correctamente
11296+
jpn: 優雅にシャットダウンするワーカー
11297+
rus: Грациозное завершение работы
11298+
por: Encerramento gracioso do trabalhador
11299+
swe: Arbetstagaren stängs av på ett elegant sätt
11300+
pol: Pracownik wyłącza się z wdziękiem
11301+
chs: 工人优雅地关闭
11302+
ukr: Працівник граціозно вимикається
11303+
kor: 우아하게 종료되는 작업자
11304+
ron: Închiderea grațioasă a lucrătorului
11305+
Original Title:
11306+
eng: Original Title
11307+
deu: Originaltitel
11308+
fra: Titre original
11309+
ita: Titolo originale
11310+
spa: Título original
11311+
jpn: 原題
11312+
rus: Оригинальное название
11313+
por: Título original
11314+
swe: Originaltitel
11315+
pol: Tytuł oryginału
11316+
chs: 原标题
11317+
ukr: Оригінальна назва
11318+
kor: 원본 제목
11319+
ron: Titlu original
11320+
No Title:
11321+
eng: No Title
11322+
deu: Kein Titel
11323+
fra: Sans titre
11324+
ita: Nessun titolo
11325+
spa: Sin título
11326+
jpn: タイトルなし
11327+
rus: Без названия
11328+
por: Sem título
11329+
swe: Ingen titel
11330+
pol: Bez tytułu
11331+
chs: 无标题
11332+
ukr: Без назви
11333+
kor: 제목 없음
11334+
ron: Fără titlu
11335+
Generate Title:
11336+
eng: Generate Title
11337+
deu: Titel generieren
11338+
fra: Générer un titre
11339+
ita: Generare il titolo
11340+
spa: Generar título
11341+
jpn: タイトルの生成
11342+
rus: Создать название
11343+
por: Gerar título
11344+
swe: Generera titel
11345+
pol: Wygeneruj tytuł
11346+
chs: 生成标题
11347+
ukr: Згенерувати заголовок
11348+
kor: 제목 생성
11349+
ron: Generarea titlului
11350+
Enter custom title:
11351+
eng: Enter custom title
11352+
deu: Benutzerdefinierten Titel eingeben
11353+
fra: Saisir un titre personnalisé
11354+
ita: Inserire un titolo personalizzato
11355+
spa: Introducir título personalizado
11356+
jpn: カスタムタイトルを入力
11357+
rus: Введите пользовательское название
11358+
por: Introduzir título personalizado
11359+
swe: Ange egen titel
11360+
pol: Wprowadź niestandardowy tytuł
11361+
chs: 输入自定义标题
11362+
ukr: Введіть власну назву
11363+
kor: 사용자 지정 제목 입력
11364+
ron: Introduceți titlul personalizat
11365+
Custom Title:
11366+
eng: Custom Title
11367+
deu: Benutzerdefinierter Titel
11368+
fra: Titre personnalisé
11369+
ita: Titolo personalizzato
11370+
spa: Título personalizado
11371+
jpn: カスタムタイトル
11372+
rus: Пользовательское название
11373+
por: Título personalizado
11374+
swe: Anpassad titel
11375+
pol: Tytuł niestandardowy
11376+
chs: 自定义标题
11377+
ukr: Користувацька назва
11378+
kor: 사용자 지정 제목
11379+
ron: Titlu personalizat

fastflix/data/styles/breeze_styles/dark/stylesheet.qss

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ QMenuBar::item
276276

277277
QMenuBar::item:selected
278278
{
279-
background: transparent;
279+
background-color: #3daee9;
280280
}
281281

282282
QMenuBar::item:disabled
@@ -295,7 +295,9 @@ QMenuBar::item:pressed
295295
QMenu
296296
{
297297
color: #eff0f1;
298+
background-color: #1d2023;
298299
margin: 0.09em;
300+
border: 1px solid #76797c;
299301
}
300302

301303
QMenu::icon
@@ -394,10 +396,6 @@ QAbstractItemView
394396
border-radius: 0.09em;
395397
}
396398

397-
QMenuBar::item:focus:!disabled
398-
{
399-
border: 0.05em solid #3daee9;
400-
}
401399

402400
QTabWidget:focus,
403401
QCheckBox:focus,
@@ -667,11 +665,6 @@ QFrame[frameShape="6"]:hover
667665
border: 0.05em solid #3daee9;
668666
}
669667

670-
/* Don't provide an outline if we have a widget that takes up the space. */
671-
QFrame[frameShape] QAbstractItemView:hover
672-
{
673-
border: 0em solid black;
674-
}
675668

676669
/**
677670
* Note: I can't really change the background of the toolbars
@@ -865,7 +858,13 @@ QComboBox QAbstractItemView
865858
background-color: #1d2023;
866859
selection-background-color: #2a79a3;
867860
outline-color: 0em;
868-
border-radius: 0.09em;
861+
border-radius: 4px;
862+
border: 2px solid #76797c;
863+
}
864+
865+
QComboBox QAbstractItemView::item
866+
{
867+
border: none;
869868
}
870869

871870
QComboBox::drop-down
@@ -1475,6 +1474,12 @@ QListView
14751474
padding: 0.2em;
14761475
}
14771476

1477+
QComboBox QListView
1478+
{
1479+
background-color: #1d2023;
1480+
border: 2px solid #76797c;
1481+
}
1482+
14781483
QTableView::item,
14791484
QListView::item,
14801485
QTreeView::item

fastflix/data/styles/breeze_styles/light/stylesheet.qss

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ QMenuBar::item
276276

277277
QMenuBar::item:selected
278278
{
279-
background: transparent;
279+
background-color: rgba(51, 164, 223, 0.5);
280280
}
281281

282282
QMenuBar::item:disabled
@@ -295,7 +295,9 @@ QMenuBar::item:pressed
295295
QMenu
296296
{
297297
color: #31363b;
298+
background-color: #e0e1e2;
298299
margin: 0.09em;
300+
border: 1px solid #76797c;
299301
}
300302

301303
QMenu::icon
@@ -394,10 +396,6 @@ QAbstractItemView
394396
border-radius: 0.09em;
395397
}
396398

397-
QMenuBar::item:focus:!disabled
398-
{
399-
border: 0.05em solid rgba(51, 164, 223, 0.5);
400-
}
401399

402400
QTabWidget:focus,
403401
QCheckBox:focus,
@@ -667,11 +665,6 @@ QFrame[frameShape="6"]:hover
667665
border: 0.05em solid rgba(51, 164, 223, 0.5);
668666
}
669667

670-
/* Don't provide an outline if we have a widget that takes up the space. */
671-
QFrame[frameShape] QAbstractItemView:hover
672-
{
673-
border: 0em solid black;
674-
}
675668

676669
/**
677670
* Note: I can't really change the background of the toolbars
@@ -862,10 +855,16 @@ QComboBox:hover:pressed:editable
862855
QComboBox QAbstractItemView
863856
{
864857
/* This happens for the drop-down menu always, whether editable or not.*/
865-
background-color: #eff0f1;
858+
background-color: #e0e1e2;
866859
selection-background-color: rgba(45, 147, 200, 0.5);
867860
outline-color: 0em;
868-
border-radius: 0.09em;
861+
border-radius: 4px;
862+
border: 2px solid #76797c;
863+
}
864+
865+
QComboBox QAbstractItemView::item
866+
{
867+
border: none;
869868
}
870869

871870
QComboBox::drop-down
@@ -1475,6 +1474,12 @@ QListView
14751474
padding: 0.2em;
14761475
}
14771476

1477+
QComboBox QListView
1478+
{
1479+
background-color: #e0e1e2;
1480+
border: 2px solid #76797c;
1481+
}
1482+
14781483
QTableView::item,
14791484
QListView::item,
14801485
QTreeView::item

fastflix/data/styles/breeze_styles/onyx/stylesheet.qss

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ QMenuBar::item
277277

278278
QMenuBar::item:selected
279279
{
280-
background: transparent;
280+
background-color: #3daee9;
281281
}
282282

283283
QMenuBar::item:disabled
@@ -296,7 +296,9 @@ QMenuBar::item:pressed
296296
QMenu
297297
{
298298
color: #eff0f1;
299+
background-color: #1d2023;
299300
margin: 0.09em;
301+
border: 1px solid #76797c;
300302
}
301303

302304
QMenu::icon
@@ -395,10 +397,6 @@ QAbstractItemView
395397
border-radius: 0.09em;
396398
}
397399

398-
QMenuBar::item:focus:!disabled
399-
{
400-
border: 0.05em solid #3daee9;
401-
}
402400

403401
QTabWidget:focus,
404402
QCheckBox:focus,
@@ -668,11 +666,6 @@ QFrame[frameShape="6"]:hover
668666
border: 0.05em solid #3daee9;
669667
}
670668

671-
/* Don't provide an outline if we have a widget that takes up the space. */
672-
QFrame[frameShape] QAbstractItemView:hover
673-
{
674-
border: 0em solid black;
675-
}
676669

677670
/**
678671
* Note: I can't really change the background of the toolbars
@@ -866,7 +859,13 @@ QComboBox QAbstractItemView
866859
background-color: #1d2023;
867860
selection-background-color: #2a79a3;
868861
outline-color: 0em;
869-
border-radius: 0.09em;
862+
border-radius: 4px;
863+
border: 2px solid #76797c;
864+
}
865+
866+
QComboBox QAbstractItemView::item
867+
{
868+
border: none;
870869
}
871870

872871
QComboBox::drop-down
@@ -1476,6 +1475,12 @@ QListView
14761475
padding: 0.2em;
14771476
}
14781477

1478+
QComboBox QListView
1479+
{
1480+
background-color: #1d2023;
1481+
border: 2px solid #76797c;
1482+
}
1483+
14791484
QTableView::item,
14801485
QListView::item,
14811486
QTreeView::item

fastflix/encoders/common/audio.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,19 @@ def build_audio(audio_tracks, audio_file_index=0):
5656
for track in audio_tracks:
5757
if not track.enabled:
5858
continue
59-
command_list.append(
60-
f"-map {audio_file_index}:{track.index} "
61-
f'-metadata:s:{track.outdex} title="{track.title}" '
62-
f'-metadata:s:{track.outdex} handler="{track.title}"'
63-
)
59+
if track.title:
60+
command_list.append(
61+
f"-map {audio_file_index}:{track.index} "
62+
f'-metadata:s:{track.outdex} title="{track.title}" '
63+
f'-metadata:s:{track.outdex} handler="{track.title}"'
64+
)
65+
else:
66+
# No title - clear any existing title metadata
67+
command_list.append(
68+
f"-map {audio_file_index}:{track.index} "
69+
f'-metadata:s:{track.outdex} title="" '
70+
f'-metadata:s:{track.outdex} handler=""'
71+
)
6472
if track.language:
6573
command_list.append(f"-metadata:s:{track.outdex} language={track.language}")
6674
if not track.conversion_codec or track.conversion_codec == "none":

0 commit comments

Comments
 (0)