* Changing SVT-AV1 to single pass only due to ffmpeg not allowing passlog files properly

* Changing SVT-AV1 to CRF quantization mode by default
* Fixing #642 Possible to create a profile without bitrate specified for audio stream (thanks to Xoanon88)
* Fixing #646 PydanticSerializationUnexpectedValue warning during startup (thanks to Noelle Leigh)
* Fixing how program is centered on multiple monitors

Author: cdgriffith

CHANGES

@@ -1,5 +1,13 @@
 # Changelog
 
+## Version 5.10.1
+
+* Changing SVT-AV1 to single pass only due to ffmpeg not allowing passlog files properly
+* Changing SVT-AV1 to CRF quantization mode by default
+* Fixing #642 Possible to create a profile without bitrate specified for audio stream (thanks to Xoanon88)
+* Fixing #646 PydanticSerializationUnexpectedValue warning during startup (thanks to Noelle Leigh)
+* Fixing how program is centered on multiple monitors
+
 ## Version 5.10.0
 
 * Adding global disable interlace check (thanks to Hexenhammer)

fastflix/application.py

@@ -196,8 +196,7 @@ def app_setup(
         sys.exit(1)
 
     if app.fastflix.config.theme != "system":
-        QtCore.QDir.addSearchPath(app.fastflix.config.theme, str(breeze_styles_path / app.fastflix.config.theme))
-        file = QtCore.QFile(f"{app.fastflix.config.theme}:stylesheet.qss")
+        file = QtCore.QFile(str(breeze_styles_path / app.fastflix.config.theme / "stylesheet.qss"))
         file.open(QtCore.QFile.OpenModeFlag.ReadOnly | QtCore.QFile.OpenModeFlag.Text)
         stream = QtCore.QTextStream(file)
         data = stream.readAll()
@@ -233,7 +232,9 @@ def app_setup(
     container = Container(app)
     container.show()
 
-    container.move(QtGui.QGuiApplication.primaryScreen().availableGeometry().center() - container.rect().center())
+    # container.move(QtGui.QGuiApplication.primaryScreen().availableGeometry().center() - container.rect().center())
+    screen_geometry = QtGui.QGuiApplication.primaryScreen().availableGeometry()
+    container.move(screen_geometry.center() - container.rect().center())
 
     if not app.fastflix.config.disable_version_check:
         latest_fastflix(app=app, show_new_dialog=False)
@@ -257,7 +258,7 @@ def start_app(worker_queue, status_queue, log_queue, queue_list, queue_lock, por
     )
 
     try:
-        app.exec_()
+        app.exec()
     except Exception:
         logger.exception("Error while running FastFlix")
         raise

fastflix/encoders/common/setting_panel.py

@@ -346,7 +346,10 @@ def _add_modes(
         disable_custom_qp=False,
         show_bitrate_passes=False,
         disable_bitrate=False,
+        qp_display_name=None,
     ):
+        if not qp_display_name:
+            qp_display_name = qp_name.upper()
         self.recommended_bitrates = recommended_bitrates
         self.recommended_qps = recommended_qps
         self.qp_name = qp_name
@@ -403,7 +406,7 @@ def _add_modes(
             bitrate_box_layout.addWidget(self.widgets.custom_bitrate)
             bitrate_box_layout.addWidget(QtWidgets.QLabel("k"))
 
-            self.qp_radio = QtWidgets.QRadioButton(qp_name.upper())
+            self.qp_radio = QtWidgets.QRadioButton(qp_display_name)
             self.qp_radio.setChecked(True)
             self.qp_radio.setFixedWidth(80)
             self.qp_radio.setToolTip(qp_help)

fastflix/encoders/svt_av1/command_builder.py

@@ -77,7 +77,7 @@ def convert_me(two_numbers, conversion_rate=50_000) -> str:
         beginning += f" -svtav1-params \"{':'.join(svtav1_params)}\" "
 
     if not settings.single_pass:
-        pass_log_file = fastflix.current_video.work_path / f"pass_log_file_{secrets.token_hex(10)}"
+        pass_log_file = f"pass_log_file_{secrets.token_hex(10)}"
         beginning += f'-passlogfile "{pass_log_file}" '
 
     pass_type = "bitrate" if settings.bitrate else "QP"

fastflix/encoders/svt_av1/settings_panel.py

@@ -70,7 +70,7 @@ def __init__(self, parent, main, app: FastFlixApp):
 
         self.widgets = Box(fps=None, mode=None, segment_size=None)
 
-        self.mode = "QP"
+        self.mode = "CRF"
 
         grid.addLayout(self.init_preset(), 0, 0, 1, 2)
         grid.addLayout(self.init_pix_fmt(), 1, 0, 1, 2)
@@ -80,7 +80,7 @@ def __init__(self, parent, main, app: FastFlixApp):
         grid.addLayout(self.init_sc_detection(), 4, 0, 1, 2)
         grid.addLayout(self.init_max_mux(), 5, 0, 1, 2)
         grid.addLayout(self.init_modes(), 0, 2, 5, 4)
-        grid.addLayout(self.init_single_pass(), 6, 2, 1, 1)
+        # grid.addLayout(self.init_single_pass(), 6, 2, 1, 1)
         grid.addLayout(self.init_svtav1_params(), 5, 2, 1, 4)
 
         grid.setRowStretch(8, 1)
@@ -130,13 +130,13 @@ def init_sc_detection(self):
             label="Scene Detection", options=["false", "true"], widget_name="sc_detection", opt="scene_detection"
         )
 
-    def init_single_pass(self):
-        return self._add_check_box(
-            label="Single Pass",
-            widget_name="single_pass",
-            tooltip="Single Pass Encoding",
-            opt="single_pass",
-        )
+    # def init_single_pass(self):
+    #     return self._add_check_box(
+    #         label="Single Pass",
+    #         widget_name="single_pass",
+    #         tooltip="Single Pass Encoding",
+    #         opt="single_pass",
+    #     )
 
     def init_preset(self):
         return self._add_combo_box(
@@ -151,7 +151,7 @@ def init_qp_or_crf(self):
         return self._add_combo_box(
             label="Quantization Mode",
             widget_name="qp_mode",
-            options=["qp", "crf"],
+            options=["crf", "qp"],
             tooltip="Use CRF or QP",
             opt="qp_mode",
         )
@@ -174,7 +174,7 @@ def init_svtav1_params(self):
         return layout
 
     def init_modes(self):
-        return self._add_modes(recommended_bitrates, recommended_qp, qp_name="qp")
+        return self._add_modes(recommended_bitrates, recommended_qp, qp_name="qp", qp_display_name="CRF/QP")
 
     def mode_update(self):
         self.widgets.custom_qp.setDisabled(self.widgets.qp.currentText() != "Custom")
@@ -188,7 +188,8 @@ def update_video_encoder_settings(self):
             speed=self.widgets.speed.currentText(),
             tile_columns=self.widgets.tile_columns.currentText(),
             tile_rows=self.widgets.tile_rows.currentText(),
-            single_pass=self.widgets.single_pass.isChecked(),
+            # single_pass=self.widgets.single_pass.isChecked(),
+            single_pass=True,
             scene_detection=bool(self.widgets.sc_detection.currentIndex()),
             qp_mode=self.widgets.qp_mode.currentText(),
             pix_fmt=self.widgets.pix_fmt.currentText().split(":")[1].strip(),

fastflix/models/config.py

@@ -24,7 +24,6 @@
 from fastflix.rigaya_helpers import get_all_encoder_formats_and_devices
 
 logger = logging.getLogger("fastflix")
-
 ffmpeg_folder = Path(user_data_dir("FFmpeg", appauthor=False, roaming=True))
 
 NO_OPT = object()
@@ -109,8 +108,8 @@ class Config(BaseModel):
     nvencc: Path | None = Field(default_factory=lambda: where("NVEncC64") or where("NVEncC"))
     vceencc: Path | None = Field(default_factory=lambda: where("VCEEncC64") or where("VCEEncC"))
     qsvencc: Path | None = Field(default_factory=lambda: where("QSVEncC64") or where("QSVEncC"))
-    output_directory: Path | None = False
-    source_directory: Path | None = False
+    output_directory: Path | None = None
+    source_directory: Path | None = None
     output_name_format: str = "{source}-fastflix-{rand_4}"
     flat_ui: bool = True
     language: str = "eng"
@@ -288,6 +287,12 @@ def load(self, portable_mode=False):
             if key in self and key not in ("config_path", "version"):
                 setattr(self, key, Path(value) if key in paths and value else value)
 
+        if self.output_directory is False:
+            self.output_directory = None
+
+        if self.source_directory is False:
+            self.source_directory = None
+
         if not self.ffmpeg or not self.ffmpeg.exists():
             self.ffmpeg = find_ffmpeg_file("ffmpeg", raise_on_missing=True)
         if not self.ffprobe or not self.ffprobe.exists():

fastflix/models/encode.py

@@ -497,7 +497,7 @@ class SVTAV1Settings(EncoderSettings):
     single_pass: bool = False
     speed: str = "7"  # Renamed preset in svtav1 encoder
     qp: Optional[Union[int, float]] = 24
-    qp_mode: str = "qp"
+    qp_mode: str = "crf"
     bitrate: Optional[str] = None
     svtav1_params: list[str] = Field(default_factory=list)
 

fastflix/version.py

@@ -1,4 +1,4 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
-__version__ = "5.10.0"
+__version__ = "5.10.1"
 __author__ = "Chris Griffith"

fastflix/widgets/settings.py

@@ -351,12 +351,12 @@ def save(self):
             restart_needed = True
         self.app.fastflix.config.hdr10plus_parser = new_hdr10_parser
 
-        new_output_path = False
+        new_output_path = None
         if self.output_path_line_edit.text().strip() and not self.default_output_dir.isChecked():
             new_output_path = Path(self.output_path_line_edit.text())
         self.app.fastflix.config.output_directory = new_output_path
 
-        new_source_path = False
+        new_source_path = None
         if self.source_path_line_edit.text().strip() and not self.default_source_dir.isChecked():
             new_source_path = Path(self.source_path_line_edit.text())
         self.app.fastflix.config.source_directory = new_source_path

fastflix/widgets/windows/audio_conversion.py

@@ -3,10 +3,10 @@
 
 from PySide6 import QtWidgets, QtGui
 
+from fastflix.exceptions import FastFlixError
 from fastflix.models.fastflix_app import FastFlixApp
 from fastflix.models.encode import AudioTrack
-
-
+from fastflix.shared import error_message
 from fastflix.language import t
 
 __all__ = ["AudioConversion"]