fix: rendering vended log diffs (#2243)

When the data source for vended logs gets updated and a new diff is
generated we would previously see the diff for `LogTypes` in the place
of both `LogTypes` and `Destinations`. This looks odd and masks any
changes that may have happened to `destinations` when the diff is
rendered.
Added logic to ensure that `logTypes` and `destinations` are displayed
correctly also adjusted several variable names.

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aws-amplify-bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: 3 people

packages/@aws-cdk/service-spec-importers/src/diff-fmt.ts

@@ -373,14 +373,15 @@ export class DiffFormatter {
 
   private renderVendedLogListDiff(diff: ScalarDiff<VendedLog | undefined>, tree: PrintableTree[], diffShown: string) {
     if (diff.old && diff.new) {
-      const oldList = new Set(diff.old.logTypes);
-      const newList = new Set(diff.new.logTypes);
-      const addedTypes = [...newList].filter((t) => !oldList.has(t));
-      const removedTypes = [...oldList].filter((t) => !newList.has(t));
-      if (addedTypes.length > 0 || removedTypes.length > 0) {
+      // the array should correspond to the value of diffShown
+      const oldList = new Set(diffShown === 'logTypes' ? diff.new.logTypes : diff.new.destinations);
+      const newList = new Set(diffShown === 'logTypes' ? diff.new.logTypes : diff.new.destinations);
+      const added = [...newList].filter((t) => !oldList.has(t));
+      const removed = [...oldList].filter((t) => !newList.has(t));
+      if (added.length > 0 || removed.length > 0) {
         const bullets: PrintableTree[] = [];
-        removedTypes.forEach((type) => bullets.push(new PrintableTree(`- ${type}`).colorize(chalk.red)));
-        addedTypes.forEach((type) => bullets.push(new PrintableTree(`+ ${type}`).colorize(chalk.green)));
+        removed.forEach((obj) => bullets.push(new PrintableTree(`- ${obj}`).colorize(chalk.red)));
+        added.forEach((obj) => bullets.push(new PrintableTree(`+ ${obj}`).colorize(chalk.green)));
         tree.push(new PrintableTree(`${diffShown}:`).addBullets(bullets));
       }
     }