From 516d04bfc4cebd8d5c7bbf476ca77bb1da9a9f78 Mon Sep 17 00:00:00 2001 From: Gasser Date: Thu, 20 Nov 2025 11:28:17 +0100 Subject: [PATCH 1/2] refactor: rename EventBridge types --- packages/@aws-cdk/service-spec-types/src/types/common.ts | 6 ++++++ packages/@aws-cdk/service-spec-types/src/types/database.ts | 6 +++--- packages/@aws-cdk/service-spec-types/src/types/event.ts | 4 ++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/packages/@aws-cdk/service-spec-types/src/types/common.ts b/packages/@aws-cdk/service-spec-types/src/types/common.ts index 19767ce6f..999d6c1a6 100644 --- a/packages/@aws-cdk/service-spec-types/src/types/common.ts +++ b/packages/@aws-cdk/service-spec-types/src/types/common.ts @@ -52,6 +52,12 @@ export interface NullType { readonly type: 'null'; } +/** + * + * T is the entity type for compound objects. + * + * For example: TypeDefinition, EventTypeDefinition. + */ export interface GenericDefinitionReference { readonly type: 'ref'; readonly reference: Reference; diff --git a/packages/@aws-cdk/service-spec-types/src/types/database.ts b/packages/@aws-cdk/service-spec-types/src/types/database.ts index e58991c1f..2396fa024 100644 --- a/packages/@aws-cdk/service-spec-types/src/types/database.ts +++ b/packages/@aws-cdk/service-spec-types/src/types/database.ts @@ -2,7 +2,7 @@ import { promises as fs } from 'fs'; import { gunzipSync } from 'zlib'; import { Database, entityCollection, fieldIndex, stringCmp } from '@cdklabs/tskb'; import { IsAugmentedResource, ResourceAugmentation } from './augmentations'; -import { HasEvent, Event, EventUsesType, EventTypeDefinition } from './event'; +import { ResourceHasEvent, Event, EventUsesType, EventTypeDefinition } from './event'; import { DimensionSet, Metric, @@ -63,7 +63,7 @@ export function emptyDatabase() { serviceHasMetric: r.relationship('service', 'metric'), resourceHasDimensionSet: r.relationship('resource', 'dimensionSet'), serviceHasDimensionSet: r.relationship('service', 'dimensionSet'), - hasEvent: r.relationship('resource', 'event'), + resourceHasEvent: r.relationship('resource', 'event'), eventUsesType: r.relationship('event', 'eventTypeDefinition'), }), ); @@ -83,7 +83,7 @@ export type SpecDatabase = ReturnType; * Helpers for working with a SpecDatabase */ export class RichSpecDatabase { - constructor(private readonly db: SpecDatabase) {} + constructor(private readonly db: SpecDatabase) { } /** * Find all resources of a given type diff --git a/packages/@aws-cdk/service-spec-types/src/types/event.ts b/packages/@aws-cdk/service-spec-types/src/types/event.ts index fafbdc6cf..8c86f0ad9 100644 --- a/packages/@aws-cdk/service-spec-types/src/types/event.ts +++ b/packages/@aws-cdk/service-spec-types/src/types/event.ts @@ -34,7 +34,7 @@ export interface Event extends Entity { */ readonly resourcesField: Array; /** - * rootProperty has the reference for the root proprety for this event + * rootProperty has the reference for the root property for this event */ readonly rootProperty: Reference; } @@ -44,7 +44,7 @@ export interface ResourceField { fieldName?: string; } -export type HasEvent = Relationship; +export type ResourceHasEvent = Relationship; export type EventProperties = Record; export interface EventProperty { From da997b2d43a34ad27dddfd2f576cc0da8f5fd95a Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 20 Nov 2025 10:43:59 +0000 Subject: [PATCH 2/2] chore: self mutation Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- packages/@aws-cdk/service-spec-types/src/types/database.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/service-spec-types/src/types/database.ts b/packages/@aws-cdk/service-spec-types/src/types/database.ts index 2396fa024..fe3cf358b 100644 --- a/packages/@aws-cdk/service-spec-types/src/types/database.ts +++ b/packages/@aws-cdk/service-spec-types/src/types/database.ts @@ -83,7 +83,7 @@ export type SpecDatabase = ReturnType; * Helpers for working with a SpecDatabase */ export class RichSpecDatabase { - constructor(private readonly db: SpecDatabase) { } + constructor(private readonly db: SpecDatabase) {} /** * Find all resources of a given type