Minor things

Author: cdoublev

doc/README.md

@@ -116,22 +116,23 @@ Before the introduction of these at-rules and nested style and group rules, it c
 Instead of modifying this behavior to interpret rules, the CSSWG decided to represent lists of declarations appearing after a nested rule, with a `CSSStyleDeclaration` contained in `CSSNestedDeclarations`, which is a "transparent" rule that only contains this list of declarations.
 
 ```css
-/* CSSStyleRule { */
+/* CSSStyleRule {              */
 style {
-  /* CSSStyleRule.style { */
+  /* .style: {                 */
   foo: 1;
   bar: 1;
   /* } */
-  /* CSSStyleRule.cssRules { */
+  /* .cssRules: [              */
   @media all {}
   /*   CSSNestedDeclarations { */
-  /*     CSSNestedDeclarations.style { */
+  /*     .style {              */
   baz: 1;
   qux: 1;
-  /*     } */
-  /*   } */
-  /* } */
+  /*     },                    */
+  /*   },                      */
+  /* ],                        */
 }
+/* }                           */
 ```
 
 `CSSStyleDeclaration` is now extended by subclasses defined with a restricted set of property and descriptor attributes: `CSSStyleProperties`, `CSSFontFaceDescriptors`, `CSSPageDescriptors`, etc. Their names also helped to remove confusion about the context in which these declarations are accepted.
@@ -174,7 +175,7 @@ To overcome these challenges, this library defines the following requirements fo
 
 A CSS parser must validate rules and declarations *in the context*, which is not defined anywhere nor passed as an argument.
 
-When grouping at-rules like `@media` and `@supports` are nested in a style rule, the grammar of their block value changes. When using `CSSRule.insertRule()`, the node representing `CSSRule` does not exist. So the context must be initialized with its CSSOM representation.
+When grouping at-rules like `@media` and `@supports` are nested in a style rule, the grammar of their block value changes. When using `CSSGroupingRule.insertRule()`, the node representing `CSSGroupingRule` does not exist. So the context must be initialized with its CSSOM representation.
 
 The context representation must allow accessing the parent rule definition, which must tell:
 

lib/cssom/CSSFontFeatureValuesMap-impl.js

@@ -17,6 +17,7 @@ export default class CSSFontFeatureValuesMapImpl {
      * @param {object} privateData
      */
     constructor(globalObject, args, { name, node, parentRule, parentStyleSheet }) {
+        this._globalObject = globalObject
         this.parentRule = parentRule
         this.parentStyleSheet = parentStyleSheet
         if (node) {

lib/cssom/CSSRuleList-impl.js

@@ -12,6 +12,7 @@ export default class CSSRuleListImpl {
      * @param {object} privateData
      */
     constructor(globalObject, args, { rules }) {
+        this._globalObject = globalObject
         this._rules = rules
     }
 

lib/cssom/MediaList-impl.js

@@ -31,6 +31,7 @@ function parseMediaQuery(input) {
 export default class MediaListImpl {
 
     constructor(globalObject, args, { list = createList([], ',', ['<media-query-list>']) }) {
+        this._globalObject = globalObject
         this._list = list
     }
 

lib/error.js

@@ -78,18 +78,14 @@ export const UPDATE_LOCKED_STYLESHEET_ERROR = {
 
 /**
  * @param {object} description
- * @param {boolean} [silent]
  * @returns {DOMException|Error}
  */
-export function create({ context, message, name, type: Type = SyntaxError }, silent = !environment.test) {
+export function create({ message, name, type: Type = 'SyntaxError' }) {
     if (name) {
         return new DOMException(message, name)
     }
-    if (!silent) {
-        if (context) {
-            console.log(`---\n\n${context}\n\n---`)
-        }
-        console.error(`${Type.name}: ${message}`)
+    if (environment.test) {
+        console.error(`${Type}: ${message}`)
     }
     return new Type(message)
 }

lib/match/media.js

@@ -177,7 +177,7 @@ function matchFeature(feature, operator, value, window) {
         case 'update':
             return value === 'fast'
         default:
-            throw Error('Unhandled feature')
+            throw RangeError('Unexpected feature')
     }
 }
 

lib/parse/definition.js

@@ -5,7 +5,6 @@ import { isDigit, isIdentifierCharacter, startsWithIdentifier } from '../utils/s
 import Stream from './stream.js'
 import arbitrary from './arbitrary.js'
 import { canonicalize } from '../values/dimensions.js'
-import { create as error } from '../error.js'
 import forgiving from '../values/forgiving.js'
 import properties from '../properties/definitions.js'
 import types from '../values/definitions.js'
@@ -83,7 +82,7 @@ function consumeRange(chars, infinity = Infinity) {
                 break
         }
     }
-    throw error({ message: `Missing "${closingToken}"` })
+    throw SyntaxError(`Missing "${closingToken}"`)
 }
 
 /**

lib/parse/grammar.js

@@ -212,7 +212,7 @@ function match(node) {
         case 'token':
             return matchToken(node)
         default:
-            throw RangeError('Unrecognized node definition type')
+            throw RangeError('Unexpected node definition type')
     }
 }
 

lib/parse/parser.js

@@ -126,7 +126,7 @@ function isInvalidNamespaceRule(list, rule) {
 }
 
 /**
- * @param {CSSRuleListImpl[]} list
+ * @param {CSSRuleImpl[]} list
  * @param {string} input
  * @param {number} index
  * @param {object} context
@@ -172,17 +172,17 @@ function insertRule(list, input, index, context, allowImport) {
 }
 
 /**
- * @param {CSSRuleListImpl[]} list
+ * @param {CSSRuleImpl[]} list
  * @param {number} index
  * @see {@link https://drafts.csswg.org/cssom-1/#remove-a-css-rule}
  */
 function removeRule(list, index) {
     if (list.length <= index) {
-        throw error(INVALID_RULE_INDEX_ERROR, true)
+        throw error(INVALID_RULE_INDEX_ERROR)
     }
     const rule = list[index]
     if (isInvalidNamespaceRule(list, rule)) {
-        throw error(INVALID_NAMESPACE_STATE_ERROR, true)
+        throw error(INVALID_NAMESPACE_STATE_ERROR)
     }
     list.splice(index, 1)
     rule.parentStyleSheet = null

lib/parse/simplify.js

@@ -5,7 +5,6 @@ import { canonicalize, getCanonicalUnitFromType } from '../values/dimensions.js'
 import { clamp, isNegativeZero, round, sign, toDegrees, toRadians } from '../utils/math.js'
 import { getCalculationType, matchNumericType, types as numericTypes } from './types.js'
 import { isCalculation, isCombinable, isList, isNumeric, isOmitted } from '../utils/value.js'
-import { create as error } from '../error.js'
 
 /**
  * @param {object} node
@@ -290,7 +289,7 @@ export function simplifyCalculation(node, resolutionType) {
                     }
                 }).value, ['<calc-value'])
             default:
-                throw error({ message: `Unrecognized math function "${name}"` })
+                throw SyntaxError(`Unexpected math function "${name}"`)
         }
     } else if (name === 'min' || name === 'max') {
         if (value.length === 1) {