Skip to content

Commit 0538498

Browse files
authored
Fix the log level in the run-generate-reports celery task (#2490)
1 parent 8820fc9 commit 0538498

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

app/celery/scheduled_tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ def beat_inbox_sms_priority():
393393
@notify_celery.task(name="run-generate-reports")
394394
@statsd(namespace="tasks")
395395
def run_generate_reports():
396-
current_app.logger.error("starting run-generate-reports")
396+
current_app.logger.info("starting run-generate-reports")
397397

398398
# query for reports that have been requested but haven't been generated yet
399399
requested_reports = Report.query.filter(Report.status.in_([ReportStatus.REQUESTED.value])).order_by(Report.requested_at).all()

tests/app/celery/test_scheduled_tasks.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,6 @@ def test_mark_jobs_complete(
630630

631631
def test_run_generate_reports(mocker, notify_db_session, sample_user, sample_service):
632632
mock_logger = mocker.patch("app.celery.scheduled_tasks.current_app.logger.info")
633-
mock_error_logger = mocker.patch("app.celery.scheduled_tasks.current_app.logger.error")
634633
mock_generate_report = mocker.patch("app.celery.scheduled_tasks.generate_report.apply_async")
635634

636635
# Create some reports in REQUESTED status
@@ -665,8 +664,8 @@ def test_run_generate_reports(mocker, notify_db_session, sample_user, sample_ser
665664
scheduled_tasks.run_generate_reports()
666665

667666
# Check logging
668-
mock_error_logger.assert_called_once_with("starting run-generate-reports")
669-
assert mock_logger.call_count == 2
667+
assert mock_logger.call_count == 3
668+
mock_logger.assert_any_call("starting run-generate-reports")
670669
mock_logger.assert_any_call(f"calling generate_report for Report ID {report1.id}")
671670
mock_logger.assert_any_call(f"calling generate_report for Report ID {report2.id}")
672671

0 commit comments

Comments
 (0)