fix(color): cleanup equality operator#641
Open
slook wants to merge 1 commit into
Open
Conversation
isinstance() it is way too slow while painting the canvas buffers.
slook
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed performance regression of the buffer painting since #638 ...
isinstance()call in__eq__()... This is used for==,!=andinoperators so it is too expensive to use here.if any(colors is None...)which avoids doing equality tests of the valuesinlist inpaintCanvas().scrollbarwhich always raisedAttributeErrorsince onlyclassStyleis used there.The changes in this PR are the only instances I can find in the codebase where the
otherargument could have beenNone. As such, the slow checking of theothertype withisinstance()shall no longer be required any more.If there are other callers which call this equality operator with something other than a
TTkColorobject, then that calling code ought to be caught and fixed instead of silently catching wrong types here.