fix: gofmt + keep executor's cancellable ctx for task commands (staticcheck SA4009)

Author: LauJosefsen

actions/features_test.go

@@ -12,8 +12,8 @@ import (
 func TestEnabledFeaturesForProject(t *testing.T) {
 	cfg := &config.GitteConfig{
 		FeatureGates: map[string]config.FeatureGate{
-			"feat-on":         {},                                                          // empty scope → applies to all projects
-			"feat-off":        {},                                                          // disabled in state
+			"feat-on":         {},                                                        // empty scope → applies to all projects
+			"feat-off":        {},                                                        // disabled in state
 			"feat-scoped-out": {Scope: config.FeatureScope{Projects: []string{"other"}}}, // enabled but scoped to a different project
 		},
 	}

actions/runner.go

@@ -288,7 +288,11 @@ func runGroupTask(
 	reg *telemetry.SpanRegistry,
 ) (err error) {
 	actionCtx := tracker.ActionContext(telemetry.ActionOf(taskName))
-	ctx, span := telemetry.Tracer().Start(actionCtx, "action.run "+taskName)
+	// Parent the task span under the action span, but keep running under the
+	// executor's incoming (cancellable) context so cancellation still propagates
+	// to the command — attach the span to ctx rather than replacing ctx.
+	_, span := telemetry.Tracer().Start(actionCtx, "action.run "+taskName)
+	ctx = trace.ContextWithSpan(ctx, span)
 	reg.Set(taskName, span.SpanContext())
 	setActionAttrs(span, taskName, projName, strings.Join(cmds, " "))
 	if feats := enabledFeaturesForProject(cfg, st, projName, proj); len(feats) > 0 {

telemetry/action_tracker_test.go

@@ -100,7 +100,7 @@ func TestActionTracker_RecordsTaskErrorOnActionSpan(t *testing.T) {
 	tr.OnStart("a:build:sn")
 	tr.OnStart("b:build:sn")
 	tr.OnFinish("a:build:sn", errors.New("build failed")) // one task fails
-	tr.OnFinish("b:build:sn", nil)                          // last finishes -> span ends
+	tr.OnFinish("b:build:sn", nil)                        // last finishes -> span ends
 
 	spans := exp.GetSpans()
 	var build *tracetest.SpanStub

telemetry/logs_test.go

@@ -8,8 +8,8 @@ import (
 	"github.com/cego/gitte/executor"
 	"go.opentelemetry.io/otel/log"
 	"go.opentelemetry.io/otel/log/global"
-	"go.opentelemetry.io/otel/trace"
 	sdklog "go.opentelemetry.io/otel/sdk/log"
+	"go.opentelemetry.io/otel/trace"
 )
 
 func TestSpanRegistry_SetGetDelete(t *testing.T) {

telemetry/telemetry.go

@@ -21,8 +21,8 @@ import (
 	otlplog "go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp"
 	"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
 	otellog "go.opentelemetry.io/otel/log/global"
-	"go.opentelemetry.io/otel/sdk/resource"
 	sdklog "go.opentelemetry.io/otel/sdk/log"
+	"go.opentelemetry.io/otel/sdk/resource"
 	sdktrace "go.opentelemetry.io/otel/sdk/trace"
 	"go.opentelemetry.io/otel/trace"
 )