Fix createService not passing registry auth correctly

Dockerode's createService single-arg codepath does NOT extract
authconfig from the options object (unlike createImage and
service.update which do). Passing {…serviceSpec, authconfig}
resulted in the entire service spec being serialized as the
X-Registry-Auth header, which the registry cannot parse.

Use the two-argument form createService(auth, opts) so the auth
config is correctly sent as the X-Registry-Auth header.

Author: firecow

src/docker-api.ts

@@ -1,10 +1,9 @@
-import Dockerode, {ConfigInfo, NetworkInspectInfo, Service} from "dockerode";
+import Dockerode, {AuthConfigObject, ConfigInfo, NetworkInspectInfo, Service} from "dockerode";
 import {initServiceSpec, sortServiceSpec} from "./service-spec.js";
 import {HashedConfigs} from "./hashed-config.js";
 import {assertString} from "./asserts.js";
 import {SwarmAppConfig} from "./swarm-app-config.js";
 import {resolveAuthConfig} from "./docker-config.js";
-import {AuthConfigObject} from "dockerode";
 import timers from "timers/promises";
 import assert from "assert";
 
@@ -128,7 +127,11 @@ export async function upsertServices ({dockerode, config, current, appName, hash
         const foundService = current.services.find((s) => s.Spec?.Name === `${appName}_${serviceName}`);
         if (!foundService) {
             console.log(`Creating service ${appName}_${serviceName}`);
-            await dockerode.createService({...serviceSpec, authconfig});
+            if (authconfig) {
+                await dockerode.createService(authconfig, serviceSpec);
+            } else {
+                await dockerode.createService(serviceSpec);
+            }
         } else {
             serviceSpec.version = foundService.Version?.Index ?? 0;
             console.log(`Updating service ${appName}_${serviceName}`);