Add optical SD check and output in post boundary step #2077
Conversation
…vector of volume IDs
…nd adds SDParams construction to setup/model
…s construction in global test base
…ed geometry params in global test when constructing sd params
sethrj
added
enhancement
…try and inp::detectors (empty if no detectors) and fix geant setup to load SDs properly
Test summary 499 files 810 suites 27s ⏱️ For more details on these failures, see this check. Results for commit 4953dad. ♻️ This comment has been updated with latest results. |
…r killing particles in SD regions now
…onstructor still storing vector of detector structs, even if empty
sethrj
changed the title
| { | ||
| auto energy = track.particle().energy(); | ||
| // TODO print energy when killing at SD | ||
| std::cout << "Detector hit in volume " << iv_id.get() |
There was a problem hiding this comment.
Can't have a cout in a CELER_FUNCTION.
| { | ||
| // Re-entrant into the pre-volume | ||
| auto geo = track.geometry(); | ||
| // auto geo = track.geometry(); |
|
|
||
| namespace celeritas | ||
| { | ||
| //---------------------------------------------------------------------------// |
There was a problem hiding this comment.
| //---------------------------------------------------------------------------// |
|
|
||
| //! Number of detectors | ||
| DetectorId::size_type size() const { return volume_ids_.size(); } | ||
| DetectorId::size_type size() const { return detectors_.detectors.size(); } |
There was a problem hiding this comment.
detectors.detectors sounds silly, even though I know what's going on. Just wondering if there is a better naming for the vector in inp::Detectors...
| for (size_type det_num = 0; det_num < detectors_.detectors.size(); | ||
| ++det_num) |
There was a problem hiding this comment.
| for (size_type det_num = 0; det_num < detectors_.detectors.size(); | |
| ++det_num) | |
| for (auto det_num : range(detectors_.detectors.size())) |
| surface_ = std::make_shared<SurfaceParams>(mi.surfaces, *volume_); | ||
|
|
||
| detector_ = std::make_shared<SDParams>(*core_geo, mi.detectors); | ||
| std::cout << "Detector size " << mi.detectors.detectors.size() << std::endl; |
There was a problem hiding this comment.
| std::cout << "Detector size " << mi.detectors.detectors.size() << std::endl; |
| { | ||
| namespace optical | ||
| { | ||
|
|
There was a problem hiding this comment.
Missing documentation throughout the file.
|
@lebuller If this is ready for review (it sounded like it was based on your coments?) please merge in the latest upstream, fix the failing CI tests, and mark as ready for review. @stognini will take a first crack at it (maybe leave all your comments in a single review rather than indivually?) and then I will take a look too |
3 participants
Description
This MR adds a query for checking if the new volume entered in the
postBoundaryExecutoris a sensitive detector and outputs the track energy, id, and new volume to screen. To enable this, the SD params are constructed in the core params and passed through to the optical core params. TheSDparamsdata was added to the core track data and a sensitive detector view was added to the core track view to query theSDParamsin thepostBoundaryExecutor. In addition, theSDParamsclass was updated to accept aninput::detectorsat construction instead of a volume id vector