refactor: update notifier callback return type and simplify notify implementation

Author: celeste-wahlquist

.github/workflows/test-subprojects.yml

@@ -14,6 +14,7 @@ jobs:
   test-subprojects:
     runs-on: ubuntu-latest
     name: Subproject ${{matrix.project.org}}/${{matrix.project.name}} - OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}}
+    if: ${{ github.repository == 'ash-project/ash' || matrix.project.name != 'ash_oban' }}
     strategy:
       fail-fast: false
       matrix:

lib/ash/behaviour_helpers.ex

@@ -9,9 +9,9 @@ defmodule Ash.BehaviourHelpers do
   ## Behaviour invocation pattern
 
   Implementation modules (e.g. a module that `@behaviour Ash.Resource.Change`) should be invoked
-  **only through the behaviour’s public wrapper functions** (e.g. `Ash.Resource.Change.change/4`,
-  `Ash.Resource.Change.atomic/4`). Call sites must call `SomeBehaviour.callback(implementation_module, ...)`
-  rather than `implementation_module.callback(...)`.
+  **only through the behaviour module's public wrapper callbacks**. Call sites must call
+  `SomeBehaviour.callback(implementation_module, ...)` rather than
+  `implementation_module.callback(...)`.
 
   Those wrappers:
 

lib/ash/changeset/changeset.ex

@@ -1233,7 +1233,8 @@ defmodule Ash.Changeset do
          {:atomic, condition} <-
            atomic_condition(where, changeset, context),
          {{:atomic, modified_changeset?, new_changeset, atomic_changes, validations,
-           create_atomics}, condition} <-
+           create_atomics},
+          condition} <-
            {atomic_with_changeset(
               Ash.Resource.Change.atomic(
                 module,

lib/ash/notifier/notifier.ex

@@ -6,7 +6,7 @@ defmodule Ash.Notifier do
   @moduledoc """
   A notifier is an extension that receives various events
   """
-  @callback notify(Ash.Notifier.Notification.t()) :: :ok
+  @callback notify(Ash.Notifier.Notification.t()) :: any()
   @callback requires_original_data?(Ash.Resource.t(), Ash.Resource.Actions.action()) :: boolean
 
   @doc """
@@ -29,16 +29,9 @@ defmodule Ash.Notifier do
   require Logger
 
   @doc false
-  @spec notify(module(), Ash.Notifier.Notification.t()) :: :ok
+  @spec notify(module(), Ash.Notifier.Notification.t()) :: any()
   def notify(notifier_module, notification) do
-    Ash.BehaviourHelpers.call_and_validate_return(
-      notifier_module,
-      :notify,
-      [notification],
-      [:ok],
-      behaviour: __MODULE__,
-      callback_name: "notify/1"
-    )
+    apply(notifier_module, :notify, [notification])
   end
 
   @doc false