chore: improve start/end row proof validation

rach-id · rach-id · commit 788d7f6653a8 · 2024-09-11T20:52:51.000+02:00
diff --git a/types/row_proof.go b/types/row_proof.go
@@ -34,6 +34,11 @@ func (rp RowProof) Validate(root []byte) error {
 	if len(rp.Proofs) != len(rp.RowRoots) {
 		return fmt.Errorf("the number of proofs %d must equal the number of row roots %d", len(rp.Proofs), len(rp.RowRoots))
 	}
+	if len(rp.Proofs) != 0 &&
+		(int64(rp.StartRow) != rp.Proofs[0].Index ||
+			int64(rp.StartRow) != rp.Proofs[len(rp.Proofs)-1].Index) {
+		return fmt.Errorf("invalid start/end row")
+	}
 	if !rp.VerifyProof(root) {
 		return errors.New("row proof failed to verify")
 	}

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,11 @@ func (rp RowProof) Validate(root []byte) error {`
`34`	`34`	`if len(rp.Proofs) != len(rp.RowRoots) {`
`35`	`35`	`return fmt.Errorf("the number of proofs %d must equal the number of row roots %d", len(rp.Proofs), len(rp.RowRoots))`
`36`	`36`	`}`
	`37`	`+ if len(rp.Proofs) != 0 &&`
	`38`	`+ (int64(rp.StartRow) != rp.Proofs[0].Index \|\|`
	`39`	`+ int64(rp.StartRow) != rp.Proofs[len(rp.Proofs)-1].Index) {`
	`40`	`+ return fmt.Errorf("invalid start/end row")`
	`41`	`+ }`
`37`	`42`	`if !rp.VerifyProof(root) {`
`38`	`43`	`return errors.New("row proof failed to verify")`
`39`	`44`	`}`