fix: ensure we're waiting long enough to avoid retriggering waits

evan-forbes · evan-forbes · commit c320a4c2d5dd · 2025-11-04T07:46:20.000-06:00
diff --git a/consensus/state.go b/consensus/state.go
@@ -2123,7 +2123,10 @@ func (cs *State) isReadyToPrecommit() (bool, time.Duration) {
 	if _, ok := cs.privValidator.(*privval.SignerClient); ok {
 		waitTime = waitTime - KMSSigningDelay
 	}
-	return waitTime <= 0, waitTime
+	// return the wait time plus some overhead to guarantee that p
+	// this call doesn't accidently hit this wait a second time with
+	// a few nanoseconds
+	return waitTime <= 0, waitTime + (20 * time.Millisecond)
 }
 
 //-----------------------------------------------------------------------------

Original file line number	Diff line number	Diff line change
`@@ -2123,7 +2123,10 @@ func (cs *State) isReadyToPrecommit() (bool, time.Duration) {`
`2123`	`2123`	`if _, ok := cs.privValidator.(*privval.SignerClient); ok {`
`2124`	`2124`	`waitTime = waitTime - KMSSigningDelay`
`2125`	`2125`	`}`
`2126`		`- return waitTime <= 0, waitTime`
	`2126`	`+ // return the wait time plus some overhead to guarantee that p`
	`2127`	`+ // this call doesn't accidently hit this wait a second time with`
	`2128`	`+ // a few nanoseconds`
	`2129`	`+ return waitTime <= 0, waitTime + (20 * time.Millisecond)`
`2127`	`2130`	`}`
`2128`	`2131`
`2129`	`2132`	`//-----------------------------------------------------------------------------`