Skip to content

Fix incorrect default for indexer #1720

@adlerjohn

Description

@adlerjohn

Per celestiaorg/celestia-app#1178, the default indexer for app was changed to null from kv. However this was never reflected in

# 2) "kv" (default) - the simplest possible indexer, backed by key-value storage (defaults to levelDB; see DBBackend).

I'm not sure however if core still uses kv by default, and if this should be changed in this file. See celestiaorg/celestia-app#1178 (comment)


Aside: actually the default was changed back to kv in celestiaorg/celestia-app#2039, but only in the branch v1.x, and not backported to main. main was then refactored in celestiaorg/celestia-app#2188, which still had null as the default.

Activity

added theissue type on Apr 10, 2025
rootulp

rootulp commented on Apr 10, 2025

@rootulp
Collaborator

Seems like the proposal is to modify the default config.toml to:

# Options:
#   1) "null" (default)
#   2) "kv" - the simplest possible indexer, backed by key-value storage (defaults to levelDB; see DBBackend).
# 		- When "kv" is chosen "tx.height" and "tx.hash" will always be indexed.
#   3) "psql" - the indexer services backed by PostgreSQL.
# When "kv" or "psql" is chosen "tx.height" and "tx.hash" will always be indexed.
indexer = "null"

IMO the descriptions for those options could also be improved.

linked a pull request that will close this issue on Apr 10, 2025
self-assigned this
on Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C:documentationImprovements or additions to documentationconfig

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Fix incorrect default for indexer · Issue #1720 · celestiaorg/celestia-core