-
Notifications
You must be signed in to change notification settings - Fork 346
Open
Labels
breakingproto breakingChanges that break protobuf compatabilityChanges that break protobuf compatability
Description
Context
Problem
We made a proto breaking change here. Notice how field 2 was previously used for timeout_commit and now it's used for timeout_propose_delta.
This leads to broken behavior in celestia-app.
v0.38.x-celestia
celestia-core/proto/tendermint/abci/types.proto
Lines 534 to 537 in c3c1376
| message TimeoutInfo { | |
| google.protobuf.Duration timeout_propose = 1 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration timeout_commit = 2 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| } |
v0.39.x-celestia
celestia-core/proto/tendermint/abci/types.proto
Lines 534 to 543 in 1dea4a9
| message TimeoutInfo { | |
| google.protobuf.Duration timeout_propose = 1 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration timeout_propose_delta = 2 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration timeout_prevote = 3 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration timeout_prevote_delta = 4 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration timeout_precommit = 5 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration timeout_precommit_delta = 6 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration timeout_commit = 7 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| google.protobuf.Duration delayed_precommit_timeout = 8 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true]; | |
| } |
evan-forbes and rach-id
Metadata
Metadata
Assignees
Labels
breakingproto breakingChanges that break protobuf compatabilityChanges that break protobuf compatability