Skip to content

TimeoutInfo proto breakage #2645

@rootulp

Description

@rootulp

Context

celestiaorg/celestia-app#6203

Problem

We made a proto breaking change here. Notice how field 2 was previously used for timeout_commit and now it's used for timeout_propose_delta.

This leads to broken behavior in celestia-app.

v0.38.x-celestia

message TimeoutInfo {
google.protobuf.Duration timeout_propose = 1 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration timeout_commit = 2 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
}

v0.39.x-celestia

message TimeoutInfo {
google.protobuf.Duration timeout_propose = 1 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration timeout_propose_delta = 2 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration timeout_prevote = 3 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration timeout_prevote_delta = 4 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration timeout_precommit = 5 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration timeout_precommit_delta = 6 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration timeout_commit = 7 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
google.protobuf.Duration delayed_precommit_timeout = 8 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
}

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions