Skip to content

Commit 301cdbe

Browse files
authored
refactor(nodebuilder/share): don't wrap store getter with tee getter (#2229)
## Overview The change will save extra dagstore lookup operation on every call to store getter resulting with success. For free.
1 parent d4e70e2 commit 301cdbe

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

nodebuilder/share/constructors.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,8 @@ func fullGetter(
8383
var cascade []share.Getter
8484
cascade = append(cascade, storeGetter)
8585
if cfg.UseShareExchange {
86-
cascade = append(cascade, shrexGetter)
86+
cascade = append(cascade, getters.NewTeeGetter(shrexGetter, store))
8787
}
88-
cascade = append(cascade, ipldGetter)
89-
90-
return getters.NewTeeGetter(
91-
getters.NewCascadeGetter(cascade),
92-
store,
93-
)
88+
cascade = append(cascade, getters.NewTeeGetter(ipldGetter, store))
89+
return getters.NewCascadeGetter(cascade)
9490
}

0 commit comments

Comments
 (0)