fix: autotls lint issues

Author: koenmtb1

Diff for: nodebuilder/p2p/autotls.go

@@ -5,15 +5,14 @@ import (
 
 	"github.com/caddyserver/certmagic"
 	p2pForge "github.com/ipshipyard/p2p-forge/client"
-	"github.com/libp2p/go-libp2p/core/peer"
 )
 
 // User-Agent to use during DNS-01 ACME challenge
 const userAgent = "go-libp2p/celestia-node"
 
 // setupAutoTLS attempts to obtain TLS certificates automatically using p2p-forge.
 // It returns a TLS config if successful, or nil if AutoTLS is not enabled or fails.
-func setupAutoTLS(peerId peer.ID, certstore certmagic.FileStorage) (*tls.Config, error) {
+func setupAutoTLS(certstore certmagic.FileStorage) (*tls.Config, error) {
 	// p2pforge is the AutoTLS client library.
 	// The cert manager handles the creation and management of certificate
 	certManager, err := p2pForge.NewP2PForgeCertMgr(
@@ -35,7 +34,12 @@ func setupAutoTLS(peerId peer.ID, certstore certmagic.FileStorage) (*tls.Config,
 	}
 
 	// Start the cert manager
-	certManager.Start()
+	certError := certManager.Start()
+	// Handle certManager errors
+	if certError != nil {
+		return nil, err
+	}
+
 	defer certManager.Stop()
 
 	return certManager.TLSConfig(), nil

Diff for: nodebuilder/p2p/host.go

@@ -72,7 +72,7 @@ func (ua *UserAgent) String() string {
 func newHost(params hostParams) (HostBase, error) {
 	ua := newUserAgent().WithNetwork(params.Net).WithNodeType(params.Tp)
 
-	tlsCfg, isEnabled, err := tlsEnabled(params.Cfg, params.ID, params.Certstore)
+	tlsCfg, isEnabled, err := tlsEnabled(params.Cfg, params.Tp, params.Certstore)
 	if err != nil {
 		return nil, err
 	}

Diff for: nodebuilder/p2p/tls.go

@@ -7,10 +7,10 @@ import (
 
 	"github.com/caddyserver/certmagic"
 	"github.com/libp2p/go-libp2p"
-	"github.com/libp2p/go-libp2p/core/peer"
 	ws "github.com/libp2p/go-libp2p/p2p/transport/websocket"
 
 	"github.com/celestiaorg/celestia-node/libs/utils"
+	"github.com/celestiaorg/celestia-node/nodebuilder/node"
 )
 
 const (
@@ -23,7 +23,12 @@ var tlsPath = "CELESTIA_TLS_PATH"
 // tlsEnabled checks whether `tlsPath` is not empty and creates a certificate.
 // it returns the cfg itself, the bool flag that specifies whether the config was created
 // and an error.
-func tlsEnabled(cfg *Config, peerId peer.ID, certstore certmagic.FileStorage) (*tls.Config, bool, error) {
+func tlsEnabled(cfg *Config, nodeType node.Type, certstore certmagic.FileStorage) (*tls.Config, bool, error) {
+	// Disable on light nodes
+	if nodeType == node.Light {
+		return nil, false, nil
+	}
+
 	if !cfg.TLSEnabled {
 		return nil, false, nil
 	}
@@ -32,7 +37,7 @@ func tlsEnabled(cfg *Config, peerId peer.ID, certstore certmagic.FileStorage) (*
 	if path == "" {
 		// use autotls if tls is enabled but no path is set
 		log.Debug("the CELESTIA_TLS_PATH was not set, using autotls")
-		autoTLSConfig, err := setupAutoTLS(peerId, certstore)
+		autoTLSConfig, err := setupAutoTLS(certstore)
 		if err != nil {
 			return nil, false, err
 		}