fix(nodebuilder/share): Revert providing shrex.Getter and its associated components to light node (#1770)

This PR reverts providing shrex-getter and its associated components to
light nodes as they are both unnecessary for now and are buggy, causing
the following error to occur:

light node tries to sample a recent header and fails on the first try
with
```
"PT2agmOhBwBuDZu++Vq+LGcATmrI9UZbJKEsvlHKlls=", "err": "getter/shrex: GetShare is not supported; getter/ipld: failed to retrieve share: promise channel was closed", "errCauses": [{"error": "getter/shrex: GetShare is not supported"}, {"error": "getter/ipld: failed to retrieve share: **promise channel was closed**"}]} 
```
but succeeds on a second try when the `catchUp` routine inside the DASer
samples once again over that height.

For now, we will remove this feature (which will only impact the "speed"
of the RPC call for requesting data by namespace) and debug it at a
later date.

Author: renaynay

nodebuilder/share/constructors.go

@@ -13,6 +13,7 @@ import (
 	"go.uber.org/fx"
 
 	"github.com/celestiaorg/celestia-app/pkg/da"
+
 	"github.com/celestiaorg/celestia-node/share"
 	"github.com/celestiaorg/celestia-node/share/availability/cache"
 	disc "github.com/celestiaorg/celestia-node/share/availability/discovery"
@@ -60,21 +61,6 @@ func ensureEmptyCARExists(ctx context.Context, store *eds.Store) error {
 	return err
 }
 
-func lightGetter(
-	shrexGetter *getters.ShrexGetter,
-	ipldGetter *getters.IPLDGetter,
-) share.Getter {
-	return getters.NewCascadeGetter(
-		[]share.Getter{
-			shrexGetter,
-			ipldGetter,
-		},
-		// based on the default value of das.SampleTimeout.
-		// will no longer be needed when async cascadegetter is merged
-		time.Minute,
-	)
-}
-
 func fullGetter(
 	store *eds.Store,
 	shrexGetter *getters.ShrexGetter,

nodebuilder/share/module.go

@@ -7,6 +7,7 @@ import (
 	"github.com/libp2p/go-libp2p/core/host"
 	"go.uber.org/fx"
 
+	"github.com/celestiaorg/celestia-node/libs/fxutil"
 	"github.com/celestiaorg/celestia-node/nodebuilder/node"
 	modp2p "github.com/celestiaorg/celestia-node/nodebuilder/p2p"
 	"github.com/celestiaorg/celestia-node/share"
@@ -30,36 +31,6 @@ func ConstructModule(tp node.Type, cfg *Config, options ...fx.Option) fx.Option
 		fx.Options(options...),
 		fx.Provide(discovery(*cfg)),
 		fx.Provide(newModule),
-		fx.Provide(getters.NewIPLDGetter),
-		fx.Provide(peers.NewManager),
-		fx.Provide(
-			func(ctx context.Context, h host.Host, network modp2p.Network) (*shrexsub.PubSub, error) {
-				return shrexsub.NewPubSub(
-					ctx,
-					h,
-					string(network),
-				)
-			},
-		),
-		fx.Provide(
-			func(host host.Host, network modp2p.Network) (*shrexnd.Client, error) {
-				return shrexnd.NewClient(host, shrexnd.WithProtocolSuffix(string(network)))
-			},
-		),
-		fx.Provide(
-			func(host host.Host, network modp2p.Network) (*shrexeds.Client, error) {
-				return shrexeds.NewClient(host, shrexeds.WithProtocolSuffix(string(network)))
-			},
-		),
-		fx.Provide(fx.Annotate(
-			getters.NewShrexGetter,
-			fx.OnStart(func(ctx context.Context, getter *getters.ShrexGetter) error {
-				return getter.Start(ctx)
-			}),
-			fx.OnStop(func(ctx context.Context, getter *getters.ShrexGetter) error {
-				return getter.Stop(ctx)
-			}),
-		)),
 	)
 
 	switch tp {
@@ -68,7 +39,7 @@ func ConstructModule(tp node.Type, cfg *Config, options ...fx.Option) fx.Option
 			"share",
 			baseComponents,
 			fx.Invoke(share.EnsureEmptySquareExists),
-			fx.Provide(lightGetter),
+			fxutil.ProvideAs(getters.NewIPLDGetter, new(share.Getter)),
 			// shrexsub broadcaster stub for daser
 			fx.Provide(func() shrexsub.BroadcastFn {
 				return func(context.Context, share.DataHash) error {
@@ -144,6 +115,36 @@ func ConstructModule(tp node.Type, cfg *Config, options ...fx.Option) fx.Option
 				return shrexSub.Broadcast
 			}),
 			fx.Provide(fullGetter),
+			fx.Provide(
+				func(host host.Host, network modp2p.Network) (*shrexnd.Client, error) {
+					return shrexnd.NewClient(host, shrexnd.WithProtocolSuffix(string(network)))
+				},
+			),
+			fx.Provide(
+				func(host host.Host, network modp2p.Network) (*shrexeds.Client, error) {
+					return shrexeds.NewClient(host, shrexeds.WithProtocolSuffix(string(network)))
+				},
+			),
+			fx.Provide(fx.Annotate(
+				getters.NewShrexGetter,
+				fx.OnStart(func(ctx context.Context, getter *getters.ShrexGetter) error {
+					return getter.Start(ctx)
+				}),
+				fx.OnStop(func(ctx context.Context, getter *getters.ShrexGetter) error {
+					return getter.Stop(ctx)
+				}),
+			)),
+			fx.Provide(
+				func(ctx context.Context, h host.Host, network modp2p.Network) (*shrexsub.PubSub, error) {
+					return shrexsub.NewPubSub(
+						ctx,
+						h,
+						string(network),
+					)
+				},
+			),
+			fx.Provide(peers.NewManager),
+			fx.Provide(getters.NewIPLDGetter),
 		)
 	default:
 		panic("invalid node type")